Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing propagation backend. #2950

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Sharing propagation backend. #2950

merged 10 commits into from
Jan 29, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 23, 2025 •
edited
Loading

Adds a single end-point (PUT) on Sharing to support propagation.
a boolean is required to define whether the overwritten or update strategy is chosen.

Contains #2938

Fixes #292

@ildyria ildyria requested a review from a team as a code owner January 23, 2025 21:03
@ildyria ildyria changed the base branch from master to refactor-sharing-modal January 23, 2025 21:04
@ildyria ildyria added the Review: medium Medium review expected: not many files, some attention to details required. label Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (6fe7bf5) to head (6220a05).
Report is 16 commits behind head on master.

Additional details and impacted files

sancsin
sancsin approved these changes Jan 24, 2025
View reviewed changes
app/Actions/Sharing/Propagate.php Outdated Show resolved Hide resolved
app/Actions/Sharing/Propagate.php Show resolved Hide resolved
@sancsin
Copy link
Contributor

sancsin commented Jan 24, 2025

Awesome feature! Thanks for creating this feature @ildyria.

Base automatically changed from refactor-sharing-modal to master January 29, 2025 17:37
@ildyria ildyria merged commit 11a99d3 into master Jan 29, 2025
48 checks passed
@ildyria ildyria deleted the sharing-propagation-backend branch January 29, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonMillward JasonMillward JasonMillward approved these changes

@sancsin sancsin sancsin approved these changes

Assignees
No one assigned
Labels
Review: medium Medium review expected: not many files, some attention to details required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Permit sharing of subalbums at creation
3 participants
@ildyria @sancsin @JasonMillward