Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal for creating sharing #2938

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Add modal for creating sharing #2938

merged 4 commits into from
Jan 29, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 20, 2025

This replaces the sharing form directly in the page.
Yes, it adds a click but it makes it easier for the user to understand the process.

@ildyria ildyria requested a review from a team as a code owner January 20, 2025 16:11
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (6fe7bf5) to head (8b25712).
Report is 15 commits behind head on master.

Additional details and impacted files

@tinohager

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@tinohager

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as outdated.

@ildyria ildyria force-pushed the refactor-sharing-modal branch from ed63fac to 42b7543 Compare January 21, 2025 21:33
@ildyria

This comment was marked as outdated.

@ildyria
Copy link
Member Author

ildyria commented Jan 21, 2025

@LycheeOrg/reviewers ready for reviews. :)

@ildyria ildyria merged commit a341b80 into master Jan 29, 2025
52 checks passed
@ildyria ildyria deleted the refactor-sharing-modal branch January 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants