Skip to content

fix: pin ForwardDiff and CUDA versions #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2025
Merged

fix: pin ForwardDiff and CUDA versions #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e256c27
fix: pin ForwardDiff version
avik-pal Sep 15, 2025
1b293f9
fix: pin CUDA version
avik-pal Sep 15, 2025
fb0a3c2
fix: use special NCCL
avik-pal Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Lux"
uuid = "b2108857-7c20-44ae-9111-449ecde12c47"
authors = ["Avik Pal <[email protected]> and contributors"]
version = "1.21.1"
version = "1.21.2"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down Expand Up @@ -91,7 +91,7 @@ Enzyme = "0.13.74"
EnzymeCore = "0.8.13"
FastClosures = "0.3.2"
Flux = "0.16.3"
ForwardDiff = "0.10.36, 1"
ForwardDiff = "0.10.36, =1"
Copy link

@gemini-code-assist gemini-code-assist bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The current syntax for the [compat] entry specifies an empty set of allowed versions for ForwardDiff, which will likely cause package resolution to fail.

According to Julia's Pkg documentation, comma-separated version specifiers are treated as an intersection.

  • "0.10.36" resolves to the range [0.10.36, 0.11.0).
  • "=1" resolves to the range [1.0.0, 1.1.0).

The intersection of these two ranges is empty. The previous value ("0.10.36, 1") had the same problem.

To pin the version to avoid issues with v1.0 (as suggested by the linked PR), you should probably restrict compatibility to the 0.10 series. The suggested change does this.

Please note that other dependencies in this file (e.g., Zygote, LossFunctions) seem to have the same syntactical issue.

Suggested change
ForwardDiff = "0.10.36, =1"
ForwardDiff = "0.10.36"

FunctionWrappers = "1.1.3"
Functors = "0.5"
GPUArraysCore = "0.2"
Expand Down
1 change: 1 addition & 0 deletions test/distributed/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Lux = {path = "../.."}
LuxCUDA = {path = "../../lib/LuxCUDA"}
MLDataDevices = {path = "../../lib/MLDataDevices"}
NCCL = { url = "https://github.com/LuxDL/NCCL.jl", rev = "cd85e9f7830be425b64d2eee407df7d61a6a9635" }

[compat]
ComponentArrays = "0.15.29"
Expand Down
2 changes: 1 addition & 1 deletion test/distributed/common_distributedtest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ end

const backend_type = input_args[2] == "nccl" ? NCCLBackend : MPIBackend

if input_args[1] == "nccl"
if input_args[2] == "nccl"
using NCCL
end

Expand Down
2 changes: 1 addition & 1 deletion test/distributed/data_distributedtest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ end

const backend_type = input_args[2] == "nccl" ? NCCLBackend : MPIBackend

if input_args[1] == "nccl"
if input_args[2] == "nccl"
using NCCL
end

Expand Down
2 changes: 1 addition & 1 deletion test/distributed/optimizer_distributedtest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ end

const backend_type = input_args[2] == "nccl" ? NCCLBackend : MPIBackend

if input_args[1] == "nccl"
if input_args[2] == "nccl"
using NCCL
end

Expand Down
2 changes: 1 addition & 1 deletion test/distributed/synchronize_distributedtest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ end

const backend_type = input_args[2] == "nccl" ? NCCLBackend : MPIBackend

if input_args[1] == "nccl"
if input_args[2] == "nccl"
using NCCL
end

Expand Down
Loading