-
Notifications
You must be signed in to change notification settings - Fork 81
fix: pin ForwardDiff and CUDA versions #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses recent continuous integration failures by temporarily pinning specific versions of the ForwardDiff and CUDA dependencies. This proactive measure aims to stabilize the build process and prevent unnecessary CI red states until critical upstream pull requests are merged and integrated, ensuring the project remains functional and reliable.
Highlights
- Dependency Version Pinning: The
ForwardDiffpackage is now explicitly pinned to major version1inProject.tomlto prevent potential breaking changes from newer versions. - CUDA Compatibility Range: The
CUDApackage compatibility inlib/LuxCUDA/Project.tomlhas been narrowed to5.8 - 5.8.1to ensure stability and avoid CI failures related to upstream changes. - Project Version Bumps: The main
Luxproject version has been updated to1.21.2, and theLuxCUDAsub-project version has been updated to0.3.5.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the versions of ForwardDiff and CUDA to work around issues in upstream packages and keep CI green. The version numbers for Lux and LuxCUDA are also bumped.
The change to pin the CUDA version in lib/LuxCUDA/Project.toml is correct and effectively constrains the version as intended. However, the change to the ForwardDiff compatibility in the root Project.toml uses a syntax that results in an empty set of allowed versions, which will likely break package installation for users. I've provided a critical comment with a suggested fix for this issue. It's worth noting that the same syntactical problem might exist for other dependencies in that file.
| FastClosures = "0.3.2" | ||
| Flux = "0.16.3" | ||
| ForwardDiff = "0.10.36, 1" | ||
| ForwardDiff = "0.10.36, =1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current syntax for the [compat] entry specifies an empty set of allowed versions for ForwardDiff, which will likely cause package resolution to fail.
According to Julia's Pkg documentation, comma-separated version specifiers are treated as an intersection.
"0.10.36"resolves to the range[0.10.36, 0.11.0)."=1"resolves to the range[1.0.0, 1.1.0).
The intersection of these two ranges is empty. The previous value ("0.10.36, 1") had the same problem.
To pin the version to avoid issues with v1.0 (as suggested by the linked PR), you should probably restrict compatibility to the 0.10 series. The suggested change does this.
Please note that other dependencies in this file (e.g., Zygote, LossFunctions) seem to have the same syntactical issue.
| ForwardDiff = "0.10.36, =1" | |
| ForwardDiff = "0.10.36" |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
===========================================
- Coverage 84.13% 69.85% -14.28%
===========================================
Files 166 166
Lines 6724 6711 -13
===========================================
- Hits 5657 4688 -969
- Misses 1067 2023 +956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
83ea5a2 to
6ab2b92
Compare
6ab2b92 to
fb0a3c2
Compare
I am going to pin these till upstream PRs get merged. Can't have CI red unnecessarily.
@checked+ support for CUDA 13 JuliaGPU/NCCL.jl#63