Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that PTP is low after reset #475

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

houkhouk
Copy link

@houkhouk houkhouk commented Feb 2, 2024

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

After power-on or a reset, it can happen that the PTP line stays high due to some parasitic capacitance on the line combined to the high impedance default configuration of GPIOs. It has been observed that this behavior can trigger interrupts that sends the µcontroller to the hardfault handler.
Forcing GPIOs to a low level during start-up is recommended.

Changes

Please choose the relevant options:

  • [ x] Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault added this to the 3.1.0 milestone Feb 2, 2024
@nicolas-rabault nicolas-rabault requested review from nicolas-rabault and removed request for nicolas-rabault February 2, 2024 10:19
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@nicolas-rabault nicolas-rabault changed the base branch from main to rc_3.1.0 February 2, 2024 11:49
@nicolas-rabault nicolas-rabault mentioned this pull request Feb 2, 2024
8 tasks
@nicolas-rabault nicolas-rabault merged commit 4ed1943 into Luos-io:rc_3.1.0 Feb 2, 2024
1 of 3 checks passed
@houkhouk houkhouk deleted the fix/PTP_reset_value branch October 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants