fix: missing favicon #261
fix: missing favicon #261
Conversation
|
| @@ -44,6 +45,7 @@ const url = "https://lumeweb.com"; | |||
| <meta property="twitter:description" content={description} /> | |||
| <meta property="twitter:image" content={opengraph.src} /> | |||
| <link rel="sitemap" href="/sitemap-index.xml" /> | |||
| <link rel="icon" type="image/x-icon" href={favicon}> | |||
There was a problem hiding this comment.
We dont change the favicon depending on the route, so no need for the layout to receive the favicon, we can simply import it directly
There was a problem hiding this comment.
Also please use this favicon https://github.com/LumeWeb/web/pull/262/files#diff-818aad2366db5a8bfcdaf1c251383895f1fdc612d487f62a064ae1c6f51fa485
Feel free to copy/paste the .svg file. (prefer to use svg file for the favicon)
|
Thanks for the contribution @forbesus! This looks good, small change tho, no need to be passing the favicon as a parameter as we dont plan to change the favicon |
|
Hello @ditorodev Some browser like safari is not supporting svg favicon now https://caniuse.com/link-icon-svg Are you still okay with this? |
|
@forbesus if you want me to merge/use this, please squash all commits into 1 conventional commit. There is too much noise here, and im not wanting 5-6 commits for this to be in the repo. Kudos. |
fix: add new file to .gitignore fix: add favicon to all pages fix: import favicon directly in layout fix: remove unnecessary space
forbesus
force-pushed
the
fix/missing-favicon
branch
from
bd04069 to
68dc472
Compare
|
Hello @pcfreak30 I just squashed all commits |
ref