Conversation
…ved-mechanism to codeql-detection memory Two follow-up fixes from Codex P2 review on PR #665 (post-merge): 1. memory/feedback_speculation_leads_investigation_not_defines_root_cause_aaron_2026_04_28.md — composes-with referenced `feedback_otto_352_live_lock_term_split_three_distinct_classes_2026_04_26.md` which doesn't exist on main. The same content lives at `feedback_otto_358_live_lock_too_broad_catch_all_narrow_to_cs_standard_concurrent_state_thrashing_2026_04_27.md` (Aaron's correction renamed the live-lock-narrowing memo; both the speculation memo and Otto-358 reference the missing 352 file per repo grep). Updated the cross-ref to point at the existing file. 2. memory/feedback_codeql_umbrella_neutral_vs_per_language_detection_pattern_aaron_2026_04_28.md — replaces the speculative "Open question (deferred)" section with the EVIDENCE-BASED resolved-mechanism from primary-source query (umbrella check's own details URL: "1 configuration present on refs/heads/main was not found: codeql.yml /language:java-kotlin"). Originally a deferred follow-up after PR #663 merged; now applied. Includes the structural fix landed via PR #662 (merged 2026-04-28T16:22:42Z) for full mechanism + remediation trail. Composes with PR #663 (codeql-detection memory original landing) + PR #665 (speculation rule original landing) + PR #662 (the structural fix). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…solved-mechanism modification The memory-paired-edit CI check requires MEMORY.md be touched when memory/* changes, even for modifications (not just additions). My PR #668 modified two memory files without touching MEMORY.md. Updated the codeql-detection entry to mark the mechanism as RESOLVED 2026-04-28T14:32Z with pointer to PR #662 for the structural fix. The speculation-rule entry doesn't change since its content didn't materially change (just a cross-ref fix to Otto-358). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates two memory files to correct an internal cross-reference and replace a speculative “open question” with a primary-source-grounded explanation of the CodeQL umbrella NEUTRAL mechanism (and its structural fix trail to PR #662).
Changes:
- Fix broken
Otto-352filename reference by pointing to the existingOtto-358memo. - Replace the “Open question (deferred)” section in the CodeQL umbrella detection memory with the resolved mechanism grounded in the umbrella check’s own summary output and link it to the structural fix in PR #662.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
memory/feedback_speculation_leads_investigation_not_defines_root_cause_aaron_2026_04_28.md |
Updates a broken cross-ref to the correct existing Otto-358 memory file. |
memory/feedback_codeql_umbrella_neutral_vs_per_language_detection_pattern_aaron_2026_04_28.md |
Replaces speculative suspects with the resolved, primary-source mechanism + fix trail to PR #662. |
AceHack
deleted the
memory/speculation-cross-refs-resolved-mechanism-2026-04-28
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Codex P2 findings from the PR #665 post-merge review:
Broken cross-ref: speculation memory references
feedback_otto_352_*which doesn't exist on main. Same content lives at the Otto-358 file (Aaron's renamed live-lock-narrowing memo). Updated.Resolved-mechanism update: codeql-detection memory still had the speculative "Open question (deferred)" section with org-level-inheritance suspects. Replaces with primary-source-grounded mechanism (umbrella check's verbatim details URL output) + structural-fix trail to PR ci(codeql): treat Java like every other managed runtime — add java-kotlin matrix + scan AlloyRunner.java #662.
Both deferred-then-due updates from PR #665's landing chain. 🤖 Generated with Claude Code