fix(4737): remove sensitive information and fix schema errors (rebased)#5276
Merged
Conversation
… index (PR #4668 review fix) Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR supersedes #4737 and #4824 by removing sensitive personal-information artifacts from memory/ and attempting to reconcile memory index/schema drift after rebasing.
Changes:
- Deletes two memory artifacts containing sensitive disclosures (one persona conversation substrate file and one feedback memory file).
- Updates
memory/MEMORY.mdto reflect a reindex/new entries, but currently leaves duplicate header/footer metadata that appears to be unresolved reindex/merge drift.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| memory/persona/riven/conversations/2026-05-22-aaron-riven-full-session-substrate-trajectory.md | Removed the full-session substrate trajectory file (sensitive-content removal). |
| memory/feedback_aaron_family_configuration_cooperative_substrate_2026_05_22.md | Removed the feedback memory file (sensitive-content removal). |
| memory/MEMORY.md | Reindex/header/footer updates, but introduces duplicate “Last reindex” and duplicated stack-truncation footer lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #4737 and #4824. It removes sensitive personal information and fixes schema errors. The conflicts with main have been resolved.