fix(lint): remove 5 stray gitlinks introduced by #4851#4871
Merged
AceHack merged 1 commit intoMay 24, 2026
Conversation
PR #4851 (`docs(archive): preserve recently merged PRs`, commit 9b94a27) accidentally committed five mode-160000 gitlink entries to repo root: lior-fix-4746 lior-fix-4768 lior-fix-4773 lior-fix-4780 lior-fix-4781 These have no `.gitmodules` entries (CI surfaces this as `fatal: No url found for submodule path 'lior-fix-4746' in .gitmodules`). The `lint (no empty dirs)` required check sees them as five "unexpected empty directories" because uninitialised gitlinks resolve to empty, and the check fails on every PR opened off main since #4851 landed. This commit removes the gitlink entries via `git rm --cached`, leaving no `.gitmodules`/working-tree side-effects. After this lands, the lint cascade clears for every downstream branch on its next rebase or merge of main. Failure surface evidence: https://github.com/Lucent-Financial-Group/Zeta/actions/runs/26372168462/job/77626151804 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes five unintended mode-160000 gitlink (submodule) entries that were introduced at repo root without corresponding .gitmodules configuration, which has been breaking CI (submodule resolution) and the lint (no empty dirs) check.
Changes:
- Delete the stray gitlink entries:
lior-fix-4746,lior-fix-4768,lior-fix-4773,lior-fix-4780,lior-fix-4781. - No
.gitmoduleschanges (file does not exist in the repo root in the current tree).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lior-fix-4746 | Removes unintended gitlink entry from repo root to stop submodule/lint failures. |
| lior-fix-4768 | Removes unintended gitlink entry from repo root to stop submodule/lint failures. |
| lior-fix-4773 | Removes unintended gitlink entry from repo root to stop submodule/lint failures. |
| lior-fix-4780 | Removes unintended gitlink entry from repo root to stop submodule/lint failures. |
| lior-fix-4781 | Removes unintended gitlink entry from repo root to stop submodule/lint failures. |
AceHack
pushed a commit
that referenced
this pull request
May 24, 2026
…correction Three targeted fixes to land PR #4869 (auto-merge armed): 1. **L70 lineage claim narrowed** (per Codex P2 finding `PRRT_kwDOSF9kNM6Earkt`) — was "Five consecutive otto-vscode shards"; table actually shows 1607Z/1608Z are otto-cli + 1804Z/1902Z/2033Z are otto-vscode. Now reads "Three consecutive otto-vscode shards (1804Z/1902Z/2033Z) ... extending the otto-cli observation lineage at 1607Z/1608Z (30/31 = 97%)". 2. **L85 markdownlint MD037** — bareword glob patterns `otto-vscode/*` and `lior-*` were being parsed as malformed emphasis ("space inside emphasis markers"). Backticked the globs; markdownlint exit 0 locally + semantically clearer that these are glob patterns. 3. **5 stray gitlinks removed** (`lior-fix-4746`, `-4768`, `-4773`, `-4780`, `-4781`) — same class as the recent main fix at `51dc0b76f` (PR #4871, "remove 5 stray gitlinks from main introduced by #4851"). PR #4869's branch predates `51dc0b76f` so the gitlinks survived; removing them here fixes the `lint (no empty dirs)` non-required check. Per [`blocked-green-ci-investigate-threads.md`](.claude/rules/blocked-green-ci-investigate-threads.md): substrate-honest investigation surfaced 3 real bugs (1 P2 lineage drift + 2 lint failures). All 3 verified locally before push. Per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md): ZETA_EXPECTED_BRANCH set + `git branch --show-current` guard ran immediately before commit. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced May 24, 2026
AceHack
added a commit
that referenced
this pull request
May 24, 2026
…3 PRs + lane discipline sustained (#4869) * shard(2026-05-24/2033Z): otto-vscode bg-worker — Lior-lane fleet 41→53 PRs (+12 in ~91min) + lane discipline sustained Substantive observation shard: 5th consecutive sustained 100% Lior-lane fleet share since 1607Z finding. PR #4851 merged this window (validates Lior-driving the fleet); no own-lane PRs; counter-reset via concrete artifact. Composes with 1607Z/1608Z/1804Z/1902Z lineage; runtime-script special-case guard remains active (Riven tuning regression risk); operator-authored PII threads (#4801-#4803) remain non-bg-worker-resolvable per named-human- attribution scope. Co-Authored-By: Claude <noreply@anthropic.com> * fix(#4869): markdownlint MD037 + 5 stray gitlinks + Codex P2 lineage correction Three targeted fixes to land PR #4869 (auto-merge armed): 1. **L70 lineage claim narrowed** (per Codex P2 finding `PRRT_kwDOSF9kNM6Earkt`) — was "Five consecutive otto-vscode shards"; table actually shows 1607Z/1608Z are otto-cli + 1804Z/1902Z/2033Z are otto-vscode. Now reads "Three consecutive otto-vscode shards (1804Z/1902Z/2033Z) ... extending the otto-cli observation lineage at 1607Z/1608Z (30/31 = 97%)". 2. **L85 markdownlint MD037** — bareword glob patterns `otto-vscode/*` and `lior-*` were being parsed as malformed emphasis ("space inside emphasis markers"). Backticked the globs; markdownlint exit 0 locally + semantically clearer that these are glob patterns. 3. **5 stray gitlinks removed** (`lior-fix-4746`, `-4768`, `-4773`, `-4780`, `-4781`) — same class as the recent main fix at `51dc0b76f` (PR #4871, "remove 5 stray gitlinks from main introduced by #4851"). PR #4869's branch predates `51dc0b76f` so the gitlinks survived; removing them here fixes the `lint (no empty dirs)` non-required check. Per [`blocked-green-ci-investigate-threads.md`](.claude/rules/blocked-green-ci-investigate-threads.md): substrate-honest investigation surfaced 3 real bugs (1 P2 lineage drift + 2 lint failures). All 3 verified locally before push. Per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md): ZETA_EXPECTED_BRANCH set + `git branch --show-current` guard ran immediately before commit. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Otto <noreply@anthropic.com>
6 tasks
AceHack
added a commit
that referenced
this pull request
May 24, 2026
…FP-thread resolve (53→58 fleet) (#4879) * shard(2026-05-24/2206Z): otto-vscode bg-worker — PR #4869 merged via FP-thread resolve + Lior-lane fleet 53→58 PRs First own-lane merge in the 5-shard lineage (1607Z/1608Z/1804Z/1902Z/2033Z): PR #4869 (the 2033Z shard) was BLOCKED-armed at tick-open with 1 Codex P2 thread alleging gitlink-removal regression. Verified per blocked-green-ci-investigate-threads.md verify-before-fix discipline — the gitlinks were accidental CI-breakers fixed on main by #4871 (merged 33min BEFORE Codex review filed). Stale-but-fresh-looking sub-pattern: no-op resolve, auto-merge fired to 2f59811. Fleet: 58/58 = 100% Lior-lane (sustained from 53/53 at 2033Z; +5 new PRs in ~93min). Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard-2206z): correct 5 otto-vscode → 4 otto-vscode in lineage prose Copilot caught arithmetic inconsistency on PR #4879: prose stated "5 otto-vscode + 2 otto-cli" but table shows 4 otto-vscode (1804Z, 1902Z, 2033Z, 2206Z) + 2 otto-cli (1607Z, 1608Z) = 6 shards. Off-by-one fixed; table content unchanged; sum (6) now consistent with breakdown (4 + 2). Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Otto <noreply@anthropic.com>
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #4851 (
docs(archive): preserve recently merged PRs, commit9b94a274a) accidentally committed five mode-160000 gitlink entries to repo root:lior-fix-4746lior-fix-4768lior-fix-4773lior-fix-4780lior-fix-4781They have no
.gitmodulesentries — CI surfaces this as:The required
lint (no empty dirs)check sees them as five "unexpected empty directories" (uninitialised gitlinks resolve to empty), so it fails on every PR opened off main since #4851 landed. The empty-dirs warning appears on at least 14 open PRs (#4869, #4867, #4866, #4865, #4864, #4863, #4862, #4861, #4860, #4859, #4858, #4855, #4850, #4825, #4805 — seebun tools/github/poll-pr-gate-batch.ts --all-openwarnings).Fix
git rm --cachedthe five gitlink entries. No.gitmoduleschanges (none ever existed for these). No working-tree files touched. Top-level tree shrinks from 60 → 55 entries (sanity-check confirmed: only the 5 expecteddelete mode 160000ops).Blast radius
After this lands:
no-empty-dirsbecomes green on every downstream branch on its next rebase/merge of main.git submodule foreach --recursivestops emitting the post-jobfatal: No url foundwarning on every CI run.Test plan
git ls-tree HEAD | wc -l= 55 (was 60); 5 removed entries match the gitlink set.gitmodulesto update (file does not exist; confirmed)lint (no empty dirs)passes on this PRReference failure: https://github.com/Lucent-Financial-Group/Zeta/actions/runs/26372168462/job/77626151804
🤖 Generated with Claude Code