docs(archive): preserve PR #4820#4846
Conversation
There was a problem hiding this comment.
Pull request overview
Preserves the discussion from PR #4820 into the repo’s docs/pr-discussions/ archive, and updates the Cursor-side Riven launchd heartbeat script to run a simplified “agent gate” invocation via the agent CLI.
Changes:
- Add a new
docs/pr-discussions/archive file capturing PR #4820 metadata and preserved content. - Simplify
.cursor/bin/riven-loop-tick.tsby removing pickup/drain prompt construction and switching the gate execution toagent chat --mode ask --model grok-4.3.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/pr-discussions/PR-4820-shard-2026-05-24-1407z-dotgit-14th-observation-0-procs-first.md | Adds the archived PR-discussion record for PR #4820 (frontmatter + preserved body/review snapshot). |
| .cursor/bin/riven-loop-tick.ts | Updates the Riven launchd loop’s agent-gate execution path to a simplified agent chat invocation and adjusts logging accordingly. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfe16ef492
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "You are Riven, trajectory manager and adversarial-truth-axis reviewer.", | ||
| "This is an autonomous 15-minute cycle.", | ||
| "Read broadcasts first from ~/.local/share/zeta-broadcasts/{otto,vera,lior,riven}.md.", | ||
| "Walk assigned trajectories. Decompose only what you hit mid-stride.", | ||
| "Produce at least one concrete, actionable claim or small PR scope.", | ||
| "When blocked, create a specific research child the next pickup cannot dodge.", |
There was a problem hiding this comment.
Prioritize draining open PRs before spawning new scope
This prompt now always pushes the gate toward creating a new claim/PR scope, but the previous open_prs-based pickup/drain split was removed from this function. In cycles where open PRs already exist (especially BLOCKED ones), the loop no longer has an explicit drain path to resolve review threads first, so it can repeatedly create fresh work while merges remain stalled. That regresses the loop’s PR-ownership behavior and can accumulate unresolved PR debt.
Useful? React with 👍 / 👎.
| const gate = run("agent", [ | ||
| "chat", | ||
| "--mode", "ask", |
There was a problem hiding this comment.
Use the provisioned Cursor CLI binary for gate runs
The gate invocation switched from cursor-agent to agent without any fallback or migration guard. Repo surfaces still describe Riven’s harness as cursor-agent (for example docs/ops/agents/riven-cost-profile.md and tools/riven/riven-cursor-terminal-loop.ts), so deployments provisioned per current docs can fail every gate cycle with command-not-found and never execute the autonomous step.
Useful? React with 👍 / 👎.
|
Closing in favor of batched PR #4929 |
This PR preserves the discussion from PR #4820.