Skip to content

docs(archive): preserve PR #4799 #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AceHack wants to merge 2 commits into from
+141 −45
Closed

docs(archive): preserve PR #4799 #4838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99fd13b
fix(riven): update autonomous gate prompt to trajectory-manager contract
AceHack May 24, 2026
1d03e2e
docs(archive): preserve PR #4799
May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 16 additions & 45 deletions .cursor/bin/riven-loop-tick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,59 +198,31 @@ function heartbeat(): void {
const elapsed = Date.now() - lastTime;

if (elapsed >= agentIntervalMs) {
const prNum = Number(prCount) || 0;
const workMode = prNum === 0 ? "pickup" : "drain";
agentStatus = "running";
log(`riven work cycle start run_id=${runId} mode=${workMode} open_prs=${prNum}`);
log(`riven agent gate start run_id=${runId}`);

if (dryRun) {
log(`dry-run: would run riven ${workMode}`);
log(`dry-run: would run agent gate`);
agentStatus = "dry-run";
} else {
let prompt: string;
if (workMode === "pickup") {
const pickup = run("bun", ["tools/backlog/autonomous-pickup.ts", "--json"], 30_000);
let executionPrompt = "";
try {
const selection = JSON.parse(pickup.stdout);
executionPrompt = selection.executionPrompt ?? "";
log(`pickup selected: ${selection.selected?.id ?? "none"} action=${selection.action ?? "none"}`);
} catch { log(`pickup parse error: ${pickup.stderr.slice(0, 200)}`); }

const preamble = [
`You are Rivens background worker in Lucent-Financial-Group/Zeta.`,
`BEFORE ANY WORK: 1) Read CLAUDE.md and AGENTS.md for repo conventions.`,
`2) Run "bun tools/github/refresh-worldview.ts" to get current state.`,
`3) Read active trajectories at docs/trajectories/*/RESUME.md.`,
`4) Build gate: "dotnet build -c Release" must end with 0 warnings 0 errors.`,
`KEY RULES: TS over bash (Rule 0). Prefer F#/TS code over docs.`,
`Always re-decompose items during the build — assume decomposition has mistakes.`,
].join(" ");

prompt = executionPrompt.length > 0
? `${preamble} YOUR TASK:\n${executionPrompt}`
: `${preamble} No backlog items available. Run refresh-worldview, check for stale classifications, fix them, open a PR.`;
} else {
prompt = [
`You are Rivens background worker in Lucent-Financial-Group/Zeta.`,
`Read CLAUDE.md first. Run "bun tools/github/refresh-worldview.ts".`,
`Build gate: "dotnet build -c Release" (0 warnings).`,
`TASK: ${prNum} open PRs. Run "bun tools/github/poll-pr-gate-batch.ts --all-open".`,
`For any PR where gate=BLOCKED and nextAction=resolve-threads:`,
`check out branch, read review comments, fix code issues, push,`,
`reply to threads, resolve via GraphQL, arm auto-merge`,
`(gh pr merge NUMBER --auto --squash). Own your PRs through merge.`,
].join(" ");
}

const gate = run("cursor-agent", [
"-p",
const gate = run("agent", [
"chat",
"--mode", "ask",
"--model", "grok-4.3",
prompt,
[
"You are Riven, trajectory manager and adversarial-truth-axis reviewer.",
"This is an autonomous 15-minute cycle.",
"Read broadcasts first from ~/.local/share/zeta-broadcasts/{otto,vera,lior,riven}.md.",
"Walk assigned trajectories. Decompose only what you hit mid-stride.",
"Produce at least one concrete, actionable claim or small PR scope.",
"When blocked, create a specific research child the next pickup cannot dodge.",
"Write your status to ~/.local/share/zeta-broadcasts/riven.md at the end.",
"GitHub PR state and actual file contents are authoritative.",
].join(" "),
], agentTimeoutMs);

agentStatus = gate.status === 0 ? "ok" : `exit-${gate.status}`;
log(`riven work cycle end run_id=${runId} mode=${workMode} status=${gate.status}`);
log(`riven agent gate end run_id=${runId} status=${gate.status}`);

writeFileSync(agentStateFile, JSON.stringify({
run_id: runId,
Expand Down Expand Up @@ -316,4 +288,3 @@ try {
} finally {
releaseLock();
}

125 changes: 125 additions & 0 deletions ...ussions/PR-4799-docs-archive-preserve-recently-merged-prs-decomposed-from-47.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
---
pr_number: 4799
title: "docs(archive): preserve recently merged PRs (decomposed from #4767)"
author: "AceHack"
state: "OPEN"
created_at: "2026-05-24T01:06:59Z"
head_ref: "lior-decompose-4767-pr-preservation"
base_ref: "main"
archived_at: "2026-05-24T16:59:32Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #4799: docs(archive): preserve recently merged PRs (decomposed from #4767)

## PR description

This PR contains only the preserved PR discussions from #4767.

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-24T01:09:58Z)

## Pull request overview

This PR adds git-native PR discussion archive markdown files under `docs/pr-discussions/` to preserve the discussions/content of recently merged PRs (decomposed from #4767).

**Changes:**
- Adds 20 new PR archive records with YAML frontmatter + preserved PR descriptions/reviews/threads.
- Captures multiple “decomposed” archive-only PRs as standalone preserved discussion files.
- Preserves Dependabot PR bodies (release notes / commands) as part of the archive.

### Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 8 comments.

<details>
<summary>Show a summary per file</summary>

| File | Description |
| ---- | ----------- |
| docs/pr-discussions/PR-4765-backlog-b-0709-soraya-round-42-hand-off-register-11-unregist.md | Preserved discussion archive for PR #4765. |
| docs/pr-discussions/PR-4731-docs-archive-decomposed-preserve-recently-merged-prs-from-46.md | Preserved discussion archive for PR #4731. |
| docs/pr-discussions/PR-4728-docs-archive-decomposed-preserve-recently-merged-prs-from-46.md | Preserved discussion archive for PR #4728. |
| docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md | Preserved discussion archive for PR #4722. |
| docs/pr-discussions/PR-4721-docs-archive-preserve-merged-pr-4716.md | Preserved discussion archive for PR #4721. |
| docs/pr-discussions/PR-4720-docs-archive-preserve-merged-pr-4718.md | Preserved discussion archive for PR #4720. |
| docs/pr-discussions/PR-4719-docs-archive-decomposed-preserve-merged-pr-3363-from-4697.md | Preserved discussion archive for PR #4719. |
| docs/pr-discussions/PR-4715-deps-bump-yamldotnet-from-17-1-0-to-18-0-0.md | Preserved discussion archive for Dependabot PR #4715. |
| docs/pr-discussions/PR-4712-deps-bump-github-codeql-action-from-4-35-5-to-4-36-0-in-the.md | Preserved discussion archive for Dependabot PR #4712. |
| docs/pr-discussions/PR-4711-fix-rules-supersede-4710-with-md004-fix-on-top-copilot-p0.md | Preserved discussion archive for PR #4711. |
| docs/pr-discussions/PR-4709-docs-rules-sub-case-4-empirical-anchor-fresh-worktree-gitdir.md | Preserved discussion archive for PR #4709. |
| docs/pr-discussions/PR-4708-feat-lean4-add-imaginary-stack-toy-model-decomposed-from-407.md | Preserved discussion archive for PR #4708. |
| docs/pr-discussions/PR-4707-docs-shadow-add-lesson-log-for-pr-4059-drift-decomposed-from.md | Preserved discussion archive for PR #4707. |
| docs/pr-discussions/PR-4706-docs-shard-0008z-2026-05-23-otto-cli-cold-boot-pr-4668-named.md | Preserved discussion archive for PR #4706. |
| docs/pr-discussions/PR-4705-docs-archive-preserve-merged-pr-4686.md | Preserved discussion archive for PR #4705. |
| docs/pr-discussions/PR-4704-docs-archive-preserve-merged-pr-4687.md | Preserved discussion archive for PR #4704. |
| docs/pr-discussions/PR-4703-docs-archive-preserve-merged-pr-4690.md | Preserved discussion archive for PR #4703. |
| docs/pr-discussions/PR-4702-docs-shadow-add-lesson-log-for-blob-pr-4698.md | Preserved discussion archive for PR #4702. |
| docs/pr-discussions/PR-4701-docs-archive-add-preserved-pr-discussions.md | Preserved discussion archive for PR #4701. |
| docs/pr-discussions/PR-4700-feat-memory-add-new-feedback-memory.md | Preserved discussion archive for PR #4700. |
</details>

## Review threads

### Thread 1: docs/pr-discussions/PR-4715-deps-bump-yamldotnet-from-17-1-0-to-18-0-0.md:29 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:56Z):

P0: This line contains an invisible Unicode character (U+200B / zero-width space) in the `@​EdwardCooke` handle. The repo’s `invisible-unicode-in-text` check will flag this in `*.md` and fail CI; replace it with plain ASCII (`@EdwardCooke`) and ensure no zero-width characters remain.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Strip zero-width characters from archived review text

This archived discussion line includes an actual U+200B character in @​EdwardCooke; because .semgrep.yml rule invisible-unicode-in-text applies to all **/*.md, this new file will be flagged by lint and can block CI for otherwise-valid changes. The archive should normalize these examples to plain ASCII text (e.g., @EdwardCooke) while describing the codepoint in words.

Useful? React with 👍 / 👎.


### Thread 2: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:52 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z):

P0: This thread text includes an actual U+200B zero-width space inside the example `[#​1907]` / `[#​....]` code spans. Even though it’s describing the issue, the literal hidden character will still trigger Semgrep `invisible-unicode-in-text` and break CI; replace the examples with ASCII (e.g., `[#1907]`) and describe the zero-width space in words ("U+200B between `#` and digits").

### Thread 3: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:52 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z):

P0: This line contains a U+200B zero-width space inside the `@​meziantou` / `@​Copilot` code spans. Semgrep `invisible-unicode-in-text` will flag the hidden character even inside backticks; rewrite the examples using plain ASCII (`@meziantou`, `@Copilot`) and keep the mention of U+200B as text only.

### Thread 4: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:58 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z):

P0: This line contains an actual U+200B zero-width space inside the `@​Copilot` code span. That hidden character will trip the repo’s invisible-Unicode lint; replace it with ASCII `@Copilot` (or spell out the codepoint without embedding it).

### Thread 5: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:64 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z):

P0: This line contains a U+200B zero-width space inside the `@​meziantou` code span. Even as an example, embedding the invisible character will fail `invisible-unicode-in-text`; replace with plain ASCII `@meziantou` and keep the description of the issue as words.

### Thread 6: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:82 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z):

P0: This line embeds a U+200B zero-width space inside `@​meziantou`. Remove the hidden character (use ASCII `@meziantou`) so the archive stays lint-clean.

### Thread 7: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:82 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z):

P0: This line includes a U+200B zero-width space inside `@​meziantou`. Semgrep will flag it in Markdown; replace with ASCII `@meziantou` (or avoid embedding the example with the hidden character).

### Thread 8: docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md:82 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z):

P0: This line embeds a U+200B zero-width space in the `@​meziantou` example. Even though it’s quoting a prior review comment, the hidden character will still break `invisible-unicode-in-text`; rewrite the example with plain ASCII.

## General comments

### @AceHack (2026-05-24T12:16:16Z)

Vera/Codex CI triage: inspected the failed check on this PR. The failure is owner-lane actionable:

- `lint (semgrep)` (run `26348165508`, job `77561599966`): Semgrep reports `10 Code Findings`, all blocking, from rule `invisible-unicode-in-text`. Affected files are `docs/pr-discussions/PR-4715-deps-bump-yamldotnet-from-17-1-0-to-18-0-0.md` line 29 and `docs/pr-discussions/PR-4722-docs-archive-preserve-merged-pr-4714.md` lines 40, 46, 52, 58, 64, 70, 76, and 82. The findings are U+200B zero-width spaces in references/mentions such as `@meziantou`, `@Copilot`, and `[#1907]`; strip the invisible codepoints and keep the archive text ASCII-clean.

I did not mutate this branch or the shared root checkout.

### @AceHack (2026-05-24T14:07:59Z)

I have addressed the failing check in this PR. The CI should now pass.
Loading