docs(archive): preserve PR #4799#4838
Closed
AceHack wants to merge 2 commits into
Closed
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d03e2e009
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:56Z): | ||
|
|
||
| P0: This line contains an invisible Unicode character (U+200B / zero-width space) in the `@EdwardCooke` handle. The repo’s `invisible-unicode-in-text` check will flag this in `*.md` and fail CI; replace it with plain ASCII (`@EdwardCooke`) and ensure no zero-width characters remain. |
There was a problem hiding this comment.
This archived discussion line includes an actual U+200B character in @EdwardCooke; because .semgrep.yml rule invisible-unicode-in-text applies to all **/*.md, this new file will be flagged by lint and can block CI for otherwise-valid changes. The archive should normalize these examples to plain ASCII text (e.g., @EdwardCooke) while describing the codepoint in words.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR preserves the discussion transcript for PR #4799 under docs/pr-discussions/ and updates the Cursor-side Riven heartbeat loop to use the newer “trajectory-manager contract” gate prompt via the agent CLI.
Changes:
- Added a preserved PR discussion archive file for PR #4799 (YAML frontmatter + summary + threads).
- Updated
.cursor/bin/riven-loop-tick.tsto run a simplifiedagent chat“gate” prompt (removing the old pickup/drain prompt construction).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| docs/pr-discussions/PR-4799-docs-archive-preserve-recently-merged-prs-decomposed-from-47.md | Adds the preserved PR #4799 discussion archive. |
| .cursor/bin/riven-loop-tick.ts | Updates the autonomous gate invocation and prompt contract for the Riven loop tick. |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:56Z): | ||
|
|
||
| P0: This line contains an invisible Unicode character (U+200B / zero-width space) in the `@EdwardCooke` handle. The repo’s `invisible-unicode-in-text` check will flag this in `*.md` and fail CI; replace it with plain ASCII (`@EdwardCooke`) and ensure no zero-width characters remain. |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z): | ||
|
|
||
| P0: This thread text includes an actual U+200B zero-width space inside the example `[#1907]` / `[#....]` code spans. Even though it’s describing the issue, the literal hidden character will still trigger Semgrep `invisible-unicode-in-text` and break CI; replace the examples with ASCII (e.g., `[#1907]`) and describe the zero-width space in words ("U+200B between `#` and digits"). |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z): | ||
|
|
||
| P0: This line contains a U+200B zero-width space inside the `@meziantou` / `@Copilot` code spans. Semgrep `invisible-unicode-in-text` will flag the hidden character even inside backticks; rewrite the examples using plain ASCII (`@meziantou`, `@Copilot`) and keep the mention of U+200B as text only. |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z): | ||
|
|
||
| P0: This line contains an actual U+200B zero-width space inside the `@Copilot` code span. That hidden character will trip the repo’s invisible-Unicode lint; replace it with ASCII `@Copilot` (or spell out the codepoint without embedding it). |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:57Z): | ||
|
|
||
| P0: This line contains a U+200B zero-width space inside the `@meziantou` code span. Even as an example, embedding the invisible character will fail `invisible-unicode-in-text`; replace with plain ASCII `@meziantou` and keep the description of the issue as words. |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z): | ||
|
|
||
| P0: This line embeds a U+200B zero-width space inside `@meziantou`. Remove the hidden character (use ASCII `@meziantou`) so the archive stays lint-clean. |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z): | ||
|
|
||
| P0: This line includes a U+200B zero-width space inside `@meziantou`. Semgrep will flag it in Markdown; replace with ASCII `@meziantou` (or avoid embedding the example with the hidden character). |
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-24T01:09:58Z): | ||
|
|
||
| P0: This line embeds a U+200B zero-width space in the `@meziantou` example. Even though it’s quoting a prior review comment, the hidden character will still break `invisible-unicode-in-text`; rewrite the example with plain ASCII. |
Member
Author
|
Closing in favor of batched PR #4929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the discussion from PR #4799.