fix(lint): correct ../ depth on 0608Z + 0803Z tick shards#4358
Merged
AceHack merged 1 commit intoMay 19, 2026
Conversation
Tick shards at docs/hygiene-history/ticks/YYYY/MM/DD/X.md need 6 levels of ../ to reach repo-root .claude/rules/, not 5. PR #4343 introduced 10 broken links on 0608Z.md; PR #4357 inherited the pattern with 3 broken links on 0803Z.md (my own fix raced with auto-merge and lost — the non-required lint check didn't block the CLEAN gate before my second commit landed). This PR fixes both files; audit-tick-shard-relative-paths now passes with 0 NEW findings (12 grandfathered baseline unchanged). Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes broken relative links from tick shards under docs/hygiene-history/ticks/YYYY/MM/DD/ to files under repo-root .claude/rules/ by correcting the required directory traversal depth from 5 to 6 ../ segments.
Changes:
- Update
.claude/rules/*relative links in0608Z.mdto use../../../../../../(6 levels) instead of the prior too-shallow depth. - Update
.claude/rules/*relative links in0803Z.mdto use../../../../../../(6 levels) instead of the prior too-shallow depth.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/hygiene-history/ticks/2026/05/19/0608Z.md | Fix multiple .claude/rules/* links by increasing relative path depth to repo root. |
| docs/hygiene-history/ticks/2026/05/19/0803Z.md | Fix .claude/rules/* links by increasing relative path depth to repo root. |
This was referenced May 19, 2026
AceHack
added a commit
that referenced
this pull request
May 19, 2026
…on (#4362) Brief-ack #1 of new cycle (named-dep PR #4357 merged → counter reset). Picked highest-leverage work: closing the 13 NEW lint findings across 0608Z.md (PR #4343 inherited) + 0803Z.md (PR #4357 auto-merge-race). Both fixed in PR #4358; auto-merge armed. Auto-merge-race substrate-honest lesson: arming auto-merge with non-required lint failing + follow-up commit can race. PR #4357 merged on the first commit before my fix landed. GraphQL 51 post-spend → Pure-git tier. This shard committed + pushed via pure-git; PR creation for the shard branch deferred to post-reset tick. Co-authored-by: Claude <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 19, 2026
Cycle-new after 2 named-deps merged (PR #4358 my combined lint fix + PR #4356 peer-Otto B-0211 slice 1). GraphQL 4 → Pure-git tier; 2 shard branches sit pushed-but-un-PRed pending reset (~8 min). Lint frontier closed (0 NEW; 12 grandfathered). Auto-merge-race lesson generalized: don't arm auto-merge with non-required-checks-failing if follow-up commit likely. Rule-extension candidate for blocked-green-ci-investigate-threads.md deferred to post-reset tick. Co-authored-by: Claude <noreply@anthropic.com>
This was referenced May 19, 2026
AceHack
added a commit
that referenced
this pull request
May 19, 2026
…k-shard relative-paths baseline (#4396) Re-shipping the baseline fix that was on PR #4393 branch but did NOT land via the squash-merge (auto-merge fired on first SHA before second commit pushed; merge sha d3a8159 only included substrate landing, not the lint fix). Without this fix, the tick-shard relative-paths lint fails for ALL future PRs that trigger full-tree scan. Pre-existing finding: docs/hygiene-history/ticks/2026/05/19/0007Z-c.md references B-0668-compositional-dbsp-* via a 6-level relative path, but no B-0668-* file landed on origin/main (PRs #4281 + #4386 both CLOSED-without-merge per gh pr view --json state). Per tick-shard immutability discipline (.claude/rules/tick-must-never-stop.md: shards write-once at docs/hygiene-history/ticks/YYYY/MM/DD/HHMMZ.md), the link cannot be edited in-place. Baseline-grandfathering is the substrate-honest fix: detect-only signal preserved, CI gate passes. Verified locally: bun tools/hygiene/audit-tick-shard-relative-paths.ts --enforce --baseline ... exit=0; "13 broken relative-path links (13 grandfathered by baseline, 0 new)". Composes with #4180 (baseline mechanism shipped) and other prior baseline-extension PRs (e.g., #4358 peer Otto's PR-fix batch). Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
AceHack
added a commit
that referenced
this pull request
May 28, 2026
PR #5698 (B-0867.23 architectural-question row) merged at 1f218a2 with non-required check failure: docs/BACKLOG.md generated-index drift. Auto-merge fired on the unfixed state per the race-window documented in blocked-green-ci-investigate-threads.md (canonical empirical anchor PR #4357 → #4358 follow-up pattern). Regenerated via `BACKLOG_WRITE_FORCE=1 bun tools/backlog/generate-index.ts`. +3 lines for B-0867.23 entry. Co-authored-by: Lior <lior@zeta.dev> Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
AceHack
added a commit
that referenced
this pull request
May 29, 2026
… lint (#5939) PR #5938 race-merged before non-required 'lint (tick-shard relative-paths)' finished, per blocked-green-ci-investigate-threads.md Auto-merge-race-with- follow-up-commit anti-pattern (canonical anchor PR #4358). 4 broken links resolved to docs/.claude/rules/... (5 ups short of repo root); shard is 6 levels deep so 6 ups needed. Verified locally: 'audit-tick-shard-relative-paths.ts --enforce' returns '0 broken relative-path links' over 1208 scanned shards. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/hygiene-history/ticks/YYYY/MM/DD/X.mdneed 6 levels of../to reach repo-root.claude/rules/, not 50608Z.md(NEW lint findings; non-required check so didn't block merge)9c9c8e69raced with auto-merge and lost (the CLEAN-gate transition fired on the first commit because lint is non-required; 0803Z.md merged with 3 broken links still present)audit-tick-shard-relative-paths --enforce --baselinenow passes with 0 NEW findings (12 grandfathered baseline unchanged)Substrate-honest framing
The
--baselinemode of the audit lets historical findings sit and blocks NEW ones; this PR closes the NEW-findings frontier introduced by the last two PRs. Grandfathered 12 are separate substrate-engineering scope.Test plan
bun tools/hygiene/audit-tick-shard-relative-paths.ts --enforce --baselineexits 0🤖 Generated with Claude Code