shard(2139Z): substrate-honest finding — lint(tick-shard relative-paths) NOT enforced (no branch protection); 21 NEW findings on main; advisory-only gap#4216
Merged
AceHack merged 1 commit intoMay 18, 2026
Conversation
…hs) reports FAILURE on #4212 but doesn't block merge because main branch has NO required status checks configured (404 on /branches/main/protection/required_status_checks); auto-merge fires; substrate-debt lands. Correction to prior tick's framing: peer Otto-CLI DID apply 5→6 level path fix at 2012Z:7 but NOT 4→6 fix at 2012Z:20 + did NOT rename otto-cli-secondary. 21 NEW findings on main from today's peer shards; advisory-only enforcement gap. Low-priority follow-up: promote lint to required-check OR accept advisory + document.
AceHack
deleted the
shard/tick-2139z-substrate-debt-lint-not-enforced-finding-2026-05-18
branch
There was a problem hiding this comment.
Pull request overview
Adds a 2139Z hygiene-history tick shard documenting an investigation into tick-shard relative-path lint enforcement and branch-protection behavior.
Changes:
- Adds a new autonomous-loop tick shard for 2026-05-18 2139Z.
- Records findings about #4212, relative-path audit failures, and status-check enforcement.
Comments suppressed due to low confidence (1)
docs/hygiene-history/ticks/2026/05/18/2139Z.md:19
- P2: The referenced
2012Z.md:20links currently use five..segments (../../../../../...), not four. The line is indeed still broken for a shard at this depth, but the stated 4-level→6-level correction misrecords the actual relative-path state.
- Peer DID NOT apply the 4-level → 6-level fix at `2012Z.md:20` (still broken)
| @@ -0,0 +1,40 @@ | |||
| # Tick 2139Z — 2026-05-18 | |||
Comment on lines
+18
to
+19
| - Peer Otto-CLI's #4212 DID apply the 5-level → 6-level path depth fix (verified `2012Z.md:7` shows 6-level `../../../../../../`) | ||
| - Peer DID NOT apply the 4-level → 6-level fix at `2012Z.md:20` (still broken) |
|
|
||
| **Root cause finding**: per `gh api repos/.../branches/main/protection/required_status_checks` → 404. **Main branch has NO required status checks configured.** The `lint (tick-shard relative-paths)` job runs in CI + reports FAILURE on #4212, but doesn't block merge because no branch protection is enforcing it. Auto-merge fires; substrate-debt lands. | ||
|
|
||
| Per `tools/github/poll-pr-gate.ts:244` — when `requiredCheckNames` is undefined (branch protection not configured), the poll falls back to treating ALL checks as required. That's why my prior tick's poll output showed `requiredChecks.failed: 1` for the lint — it was the poll's inference under no-branch-protection, not actual enforcement. |
AceHack
added a commit
that referenced
this pull request
May 18, 2026
AceHack
added a commit
that referenced
this pull request
May 18, 2026
…entries, grandfather 21 legacy findings from peer Otto-CLI shards in #4212 + earlier batches); restores lint to PASSING on CI gate; future-NEW findings (after TEMPLATE.md write-time fix #4220) will surface cleanly; substrate-debt finding from #4216 still tracked but no longer noisy on every PR (#4227)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tick shard for 2139Z. Substantive finding:
lint (tick-shard relative-paths)reports FAILURE in CI but isn't blocking merge because main branch has NO required status checks configured. 21 NEW findings landed via #4212 + earlier peer shards. Low-priority follow-up candidate: either promote to required-check OR document the advisory-only gap.