Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
---
pr_number: 4085
title: "feat(B-0170.4): seed convention-drift fixture + regression test"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-17T14:01:15Z"
merged_at: "2026-05-17T14:05:10Z"
closed_at: "2026-05-17T14:05:10Z"
head_ref: "feat/b-0170-convention-drift-fixture-2026-05-17"
base_ref: "main"
archived_at: "2026-05-17T14:13:50Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #4085: feat(B-0170.4): seed convention-drift fixture + regression test

## PR description

## Summary

5th eval-set fixture for the substrate-claim-checker. Covers the **convention** sub-class of the 7-class verify-then-claim taxonomy via a self-contained fixture pair (current ADR + sibling predecessor ADR support file). Synthetic exemplar; anchor PR #2512 (the PR that shipped `check-convention.ts`).

Continues the B-0170.4 eval-set thread:

- PR #3611 — count-drift fixture
- PR #3624 — existence-drift fixture
- PR #3696 — path-form-drift fixture
- PR #3749 — cross-surface-drift fixture
- **this PR** — convention-drift fixture

Remaining check-types for B-0170.4 thread completion: semantic-equivalence-drift, empirical-output-drift, self-recursive-drift (none yet shipped as checkers).

## Files

- `tools/substrate-claim-checker/fixtures/convention-drift-no-reciprocal-marker.md` (new) — current ADR claiming supersession
- `tools/substrate-claim-checker/fixtures/_convention-drift-target-adr.md` (new) — predecessor ADR support file (leading-underscore marks "fixture support, not a top-level fixture")
- `tools/substrate-claim-checker/fixtures/README.md` — fixture-index row added
- `tools/substrate-claim-checker/fixtures.test.ts` — regression test added; pins exact finding count (1), claim line (36), target path, and reason substring (`"not reciprocated"`, `"Superseded by"`)

The fixture pair is self-contained: `check-convention.ts`'s 3-root resolution (fileDir / parentDir / repoRoot) finds the support file via `fileDir` without dragging in any real repo ADR pair.
Comment on lines +33 to +40

Per PR #3611 review-thread discipline, the fixture's HTML-comment provenance intentionally avoids restating the literal `Supersedes ADR ...` claim so a regression in body-claim detection cannot be masked by a comment-side match.

## Focused checks

- ` bun test tools/substrate-claim-checker/fixtures.test.ts` → **5 pass / 0 fail / 30 expects**
- ` bun test tools/substrate-claim-checker/` (full suite) → **117 pass / 0 fail / 274 expects** (6 files)
- Direct CLI run: `bun tools/substrate-claim-checker/check-convention.ts tools/substrate-claim-checker/fixtures/convention-drift-no-reciprocal-marker.md` → exits 1 with `1 convention-drift finding(s)` on line 36 with reciprocal-marker reason string
- Tree-count canary: `git ls-tree HEAD` = 53 entries (matches `origin/main`)

## Test plan

- [x] Focused fixture test passes
- [x] Full substrate-claim-checker suite passes
- [x] Direct CLI invocation reports expected finding shape
- [x] No commit-tree corruption (53 root entries vs 53 on main)

## Composes with

- B-0170 (parent backlog row)
- PR #2512 (anchor — check-convention.ts shipped)
- PRs #3611 / #3624 / #3696 / #3749 (sibling B-0170.4 eval-set fixtures)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T14:03:21Z)

## Pull request overview

Adds the fifth empirical eval-set fixture to `tools/substrate-claim-checker`, covering the **convention drift** checker (ADR supersession reciprocity) and wiring a regression test to ensure the checker continues to flag the missing reciprocal “Superseded by” marker pattern.

**Changes:**
- Added a self-contained convention-drift fixture pair (current ADR + predecessor support ADR) under `tools/substrate-claim-checker/fixtures/`.
- Extended `fixtures.test.ts` with a regression test that pins exact finding shape (count, claim line, target path, reason substrings).
- Updated the fixtures index README to include the new convention-drift fixture row.

### Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

| File | Description |
| ---- | ----------- |
| tools/substrate-claim-checker/fixtures/README.md | Adds the convention-drift fixture row to the eval-set index. |
| tools/substrate-claim-checker/fixtures/convention-drift-no-reciprocal-marker.md | New “current ADR” fixture containing a `Supersedes ADR \`...\`` body claim. |
| tools/substrate-claim-checker/fixtures/_convention-drift-target-adr.md | New predecessor ADR support file intentionally missing the reciprocal “Superseded by” marker. |
| tools/substrate-claim-checker/fixtures.test.ts | Adds a convention-drift regression test that asserts exact finding count/line/target/reason substrings. |
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
---
pr_number: 4087
title: "shard(2026-05-17/1327Z): autonomous-loop tick \u2014 push-success + PR #4078 already opened by peer"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-17T14:04:35Z"
merged_at: "2026-05-17T14:06:31Z"
closed_at: "2026-05-17T14:06:31Z"
head_ref: "shard/tick-1327z-pr4078-merged-2026-05-17"
base_ref: "main"
archived_at: "2026-05-17T14:13:50Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #4087: shard(2026-05-17/1327Z): autonomous-loop tick — push-success + PR #4078 already opened by peer

## PR description

## Shard substrate landing — PR #4078 merge-recap

Single-file landing: `docs/hygiene-history/ticks/2026/05/17/1327Z.md`.

Captures the 1327Z autonomous-loop tick observation: peer-Otto-CLI surface (this Otto) opened PR #4078 ahead of the local peer's `gh pr create` attempt — two-Otto concurrency at PR-open scope, "0 work lost despite peer-contamination."
Comment on lines +19 to +23

### Provenance

- Commit `b76712e` authored by peer-Otto-CLI surface.
- Pushed + PR'd from this Otto-CLI surface tick 1354Z+1401Z (substrate-preservation pattern; rate-limit-tier-deferred PR-create per `refresh-world-model-poll-pr-gate.md`).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T14:07:30Z)

## Pull request overview

Adds a single autonomous-loop tick shard documenting the 1327Z observation that PR #4078 had already been opened by a peer surface after the branch push landed.

**Changes:**
- Adds the 1327Z tick history shard.
- Records PR #4078 state, two-surface PR-open race, and next-session deferrals.

## Review threads

### Thread 1: docs/hygiene-history/ticks/2026/05/17/1327Z.md:1 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-17T14:07:29Z):

This shard starts with YAML frontmatter, but the tick-shard schema requires the first non-empty line to be the 6-column pipe row and explicitly says file-head frontmatter fails the validator (`docs/hygiene-history/ticks/README.md`:53-59, 106-112; `tools/hygiene/check-tick-history-shard-schema.ts`:82-99). Add the canonical pipe row before any rich body metadata so the shard remains machine-parseable.

### Thread 2: docs/hygiene-history/ticks/2026/05/17/1327Z.md:80 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-17T14:07:30Z):

The `1306Z` shard referenced here does not exist under `docs/hygiene-history/ticks/2026/05/17/` or anywhere under `docs/`, so this compose-with list points readers to a nonexistent prior shard. Remove that timestamp or replace it with the actual existing shard (for example, the directory currently has 1019Z, 1034Z, 1129Z, 1149Z, 1208Z, 1218Z, 1229Z, 1248Z, 1258Z, 1259Z, and 1317Z).
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
pr_number: 4088
title: "shards(2026-05-17): 1337Z + 1350Z + 1354Z chained \u2014 post-merge arc (pure-git tier)"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-17T14:04:38Z"
merged_at: "2026-05-17T14:06:13Z"
closed_at: "2026-05-17T14:06:13Z"
head_ref: "otto/1337z-shard-meta"
base_ref: "main"
archived_at: "2026-05-17T14:13:49Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #4088: shards(2026-05-17): 1337Z + 1350Z + 1354Z chained — post-merge arc (pure-git tier)

## PR description

## Substrate landing — 3 chained shards from post-merge arc

Three tick shards on one branch (single PR for batch):

- `docs/hygiene-history/ticks/2026/05/17/1337Z.md` — peer-Otto 1327Z push (pure-git tier)
- `docs/hygiene-history/ticks/2026/05/17/1350Z.md` — brief-ack #1 bounded named-dep
- `docs/hygiene-history/ticks/2026/05/17/1354Z.md` — pushed peer B-0613 branch

Authored on `otto/1337z-shard-meta` (isolated worktree off main per `.claude/rules/zeta-expected-branch.md` race-window-caveat). Three commits across ~17 min of post-merge arc operating under pure-git tier (GraphQL ~140 → 0); deferred PR-create until rate-limit reset.
Comment on lines +23 to +27

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T14:06:13Z)

## Pull request overview

This PR adds three hygiene-history tick shards documenting a post-merge autonomous-loop arc under Pure-git rate-limit constraints.

**Changes:**
- Adds the 1337Z tick shard covering peer 1327Z branch preservation and deferred PR creation.
- Adds the 1350Z brief-ack shard documenting bounded waits while GraphQL was exhausted.
- Adds the 1354Z shard documenting the pushed B-0613 peer branch and updated parked-branch roster.

### Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

| File | Description |
| ---- | ----------- |
| docs/hygiene-history/ticks/2026/05/17/1337Z.md | Records the post-merge pure-git preservation tick and deferred PR-create work. |
| docs/hygiene-history/ticks/2026/05/17/1350Z.md | Records the brief-ack tick with named dependencies during GraphQL exhaustion. |
| docs/hygiene-history/ticks/2026/05/17/1354Z.md | Records the B-0613 branch push and updated parked-branch state. |
Loading