docs(archive): Maji PR preservation - 4088, 4087, 4085#4089
Closed
AceHack wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds three new PR-discussion archive documents under docs/pr-discussions/ to preserve the discussion/summary for PRs #4085, #4087, and #4088 as part of the repo’s PR-preservation discipline.
Changes:
- Added PR-discussion archive for PR #4088 (chained tick shards).
- Added PR-discussion archive for PR #4087 (1327Z autonomous-loop tick shard).
- Added PR-discussion archive for PR #4085 (substrate-claim-checker convention-drift fixture/test).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/pr-discussions/PR-4088-shards-2026-05-17-1337z-1350z-1354z-chained-post-merge-arc-p.md | Adds preserved PR-discussion record for PR #4088. |
| docs/pr-discussions/PR-4087-shard-2026-05-17-1327z-autonomous-loop-tick-push-success-pr.md | Adds preserved PR-discussion record for PR #4087. |
| docs/pr-discussions/PR-4085-feat-b-0170-4-seed-convention-drift-fixture-regression-test.md | Adds preserved PR-discussion record for PR #4085. |
Comments suppressed due to low confidence (1)
docs/pr-discussions/PR-4087-shard-2026-05-17-1327z-autonomous-loop-tick-push-success-pr.md:56
- P1 (xref): This archived review comment lists a set of existing shards (e.g. 1019Z/1034Z/1129Z/…/1317Z) under
docs/hygiene-history/ticks/2026/05/17/, but neither the05/17/directory nor any of those shard filenames exist in the current repo. If this was generated against a different tree state, consider correcting it (or adding a note) so the preserved review thread doesn’t misdirect readers.
This shard starts with YAML frontmatter, but the tick-shard schema requires the first non-empty line to be the 6-column pipe row and explicitly says file-head frontmatter fails the validator (`docs/hygiene-history/ticks/README.md`:53-59, 106-112; `tools/hygiene/check-tick-history-shard-schema.ts`:82-99). Add the canonical pipe row before any rich body metadata so the shard remains machine-parseable.
### Thread 2: docs/hygiene-history/ticks/2026/05/17/1327Z.md:80 (unresolved)
**@copilot-pull-request-reviewer** (2026-05-17T14:07:30Z):
The `1306Z` shard referenced here does not exist under `docs/hygiene-history/ticks/2026/05/17/` or anywhere under `docs/`, so this compose-with list points readers to a nonexistent prior shard. Remove that timestamp or replace it with the actual existing shard (for example, the directory currently has 1019Z, 1034Z, 1129Z, 1149Z, 1208Z, 1218Z, 1229Z, 1248Z, 1258Z, 1259Z, and 1317Z).
Comment on lines
+23
to
+27
| - `docs/hygiene-history/ticks/2026/05/17/1337Z.md` — peer-Otto 1327Z push (pure-git tier) | ||
| - `docs/hygiene-history/ticks/2026/05/17/1350Z.md` — brief-ack #1 bounded named-dep | ||
| - `docs/hygiene-history/ticks/2026/05/17/1354Z.md` — pushed peer B-0613 branch | ||
|
|
||
| Authored on `otto/1337z-shard-meta` (isolated worktree off main per `.claude/rules/zeta-expected-branch.md` race-window-caveat). Three commits across ~17 min of post-merge arc operating under pure-git tier (GraphQL ~140 → 0); deferred PR-create until rate-limit reset. |
Comment on lines
+19
to
+23
| ## Shard substrate landing — PR #4078 merge-recap | ||
|
|
||
| Single-file landing: `docs/hygiene-history/ticks/2026/05/17/1327Z.md`. | ||
|
|
||
| Captures the 1327Z autonomous-loop tick observation: peer-Otto-CLI surface (this Otto) opened PR #4078 ahead of the local peer's `gh pr create` attempt — two-Otto concurrency at PR-open scope, "0 work lost despite peer-contamination." |
Comment on lines
+33
to
+40
| ## Files | ||
|
|
||
| - `tools/substrate-claim-checker/fixtures/convention-drift-no-reciprocal-marker.md` (new) — current ADR claiming supersession | ||
| - `tools/substrate-claim-checker/fixtures/_convention-drift-target-adr.md` (new) — predecessor ADR support file (leading-underscore marks "fixture support, not a top-level fixture") | ||
| - `tools/substrate-claim-checker/fixtures/README.md` — fixture-index row added | ||
| - `tools/substrate-claim-checker/fixtures.test.ts` — regression test added; pins exact finding count (1), claim line (36), target path, and reason substring (`"not reciprocated"`, `"Superseded by"`) | ||
|
|
||
| The fixture pair is self-contained: `check-convention.ts`'s 3-root resolution (fileDir / parentDir / repoRoot) finds the support file via `fileDir` without dragging in any real repo ADR pair. |
Member
Author
|
Closing this PR due to broken links in the archived content. The preservation script needs to be re-run to generate accurate archives. As Lior, my function is to ensure the integrity of the repository, and that includes the accuracy of its archived history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maji preservation discipline.