fix(check-shard-before-push): skip bullet-continuation lines in MD032 scan#3724
Merged
AceHack merged 1 commit intoMay 16, 2026
Merged
Conversation
… scan PR #3716's helper had a false-positive class on bullet-continuation lines. Discovered during tick 19 self-test: running the helper on .claude/rules/blocked-green-ci-investigate-threads.md flagged 3 lines as MD032 violations where the prev line was a 2-space-indented continuation of a list-item bullet. Markdownlint correctly ignores these (exit 0). The structural-marker regex `/^[#>*\-|`]/` only matches LITERAL markers; their wrap-continuations (which start with whitespace) were treated as paragraph content. Fix: add `isContinuationLine(line)` predicate that detects leading whitespace. Skip when prev is a continuation line. Tested 3 cases: 1. bullet-continuation (the FP): now ok 2. real paragraph-before-bullet (no continuation): still caught 3. existing-clean-shard regression: still ok `tsc --noEmit`: exit 0. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes a false-positive in the MD032 helper scan: bullet-continuation lines (leading whitespace) were being treated as paragraphs preceding a list, triggering spurious findings. Adds an isContinuationLine predicate and skips when the previous line is a continuation.
Changes:
- Add
isContinuationLine(line)helper detecting leading whitespace. - Skip MD032 trigger when previous line is a continuation line.
AceHack
deleted the
fix/checkmd032-bullet-continuation-otto-cli-2026-05-16
branch
AceHack
added a commit
that referenced
this pull request
May 16, 2026
…er-bug (#3724) (#3725) GraphQL reset at 03:55:31Z. 3 real Copilot findings this tick: - PR #3720 (0350Z shard): B-0545 stale ref — peer-Otto landed sweep - PR #3721 (rule extension): 2 unrunnable command examples (awk N, git log on PR num) - Helper bullet-continuation MD032 FP (discovered tick 19): isContinuationLine fix in PR #3724 3/3 findings real this tick. Copilot's overall accuracy is high; the table-pipe || class remains the only confirmed 2+-occurrence FP. Dogfood loop: helper merged tick 17 → used in tick 19 on rule file → caught helper's own bug → fix landed tick 20 (this). Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper bug discovered in tick 19 while running the helper on
.claude/rules/blocked-green-ci-investigate-threads.md—checkMd032flagged 3 bullet-continuation lines as paragraphs (prev line was 2-space-indented continuation of a list item). Markdownlint correctly ignores these.Fix: add
isContinuationLine(line)predicate; skip when prev is a continuation line.3 smoke tests: bullet-continuation FP cleared; real paragraph-before-bullet still caught; existing-clean-shard regression ok.
tsc --noEmitexit 0.Co-Authored-By: Claude noreply@anthropic.com