Skip to content

fix(check-shard-before-push): skip bullet-continuation lines in MD032 scan #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 1 commit into from
May 16, 2026
Merged

fix(check-shard-before-push): skip bullet-continuation lines in MD032 scan #3724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tools/hygiene/check-shard-before-push.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@ function buildCodeFenceFlags(lines: readonly string[]): boolean[] {
return flags;
}

// A line starting with whitespace is typically a wrap-continuation of the
// previous structural element (list-item continuation, blockquote-continuation,
// fenced-block-continuation). markdownlint correctly treats these as part
// of the prior element, NOT as a paragraph that would need a blank line
// before a following list. Detect by leading whitespace on the prev line.
function isContinuationLine(line: string): boolean {
return /^\s/.test(line);
}

function checkMd032(file: string): Md032Finding[] {
const text = readFileSync(file, "utf8");
const lines = text.split("\n");
Expand All @@ -90,9 +99,11 @@ function checkMd032(file: string): Md032Finding[] {
const cur = lines[i]!;
// Trigger: cur starts with "- " bullet AND prev is non-blank
// AND prev is not itself a structural marker (#, >, *, -, |, ```)
// AND prev is not a wrap-continuation of a prior structural element
if (!cur.startsWith("- ")) continue;
if (prev.trim() === "") continue;
if (/^[#>*\-|`]/.test(prev)) continue;
if (isContinuationLine(prev)) continue;
findings.push({ file, line: i + 1, paragraph: prev, bullet: cur });
}
return findings;
Expand Down
Loading