core: PLV mean phase offset — 19th graduation (Amara 18th-ferry #6) by AceHack · Pull Request #340 · Lucent-Financial-Group/Zeta

AceHack · 2026-04-24T08:59:29Z

Summary

Addresses Amara 18th-ferry correction #6: PLV = 1 can mean anti-phase locking, not same-time synchronization. Detectors that rely on "PLV = 1 => synchronized" misread anti-phase coordinators as same-time coordinators.

Two new functions added to TemporalCoordinationDetection:

meanPhaseOffset — returns the argument (angle) of the mean complex phase-difference vector whose magnitude is the PLV. Returns None when undefined (empty / mismatched / zero-magnitude).
phaseLockingWithOffset — returns both magnitude and offset in one sequence pass; convenience for callers that need both.

Existing phaseLockingValue contract unchanged; new primitives are additive.

Key test: anti-phase regression

// Anti-phase: magnitude = 1 AND offset = ±π
let a = [ 0.0; 0.5; 1.0; 1.5 ]
let b = a |> List.map (fun x -> x + Math.PI)
TemporalCoordinationDetection.meanPhaseOffset a b
// => Some(π)  (distinct from in-phase which is Some(0))

Without meanPhaseOffset, both cases return identical PLV = 1 and are indistinguishable. This is the regression Amara flagged.

Test coverage

8 new xUnit tests: identical / constant-offset / anti-phase-vs-in-phase / zero-magnitude / empty / mismatched / single-element / magnitude-consistency / phaseLockingWithOffset variants. All 37 TemporalCoordinationDetection tests pass.

Build

dotnet build -c Release — 0 Warnings / 0 Errors.

18th-ferry correction tracking

6th of 10 operationalized (after #338 parser-tech, #339 test-classification). Remaining: Wilson CIs in CartelToy tests (waits on #323), MAD=0 percentile-rank fallback (waits on #333), conductance-sign doc (waits on #331), artifact-output layout (Stage-2 calibration harness).

Test plan

dotnet build -c Release clean.
dotnet test on TemporalCoordinationDetection passes (37/37).
Non-breaking — existing PLV contract unchanged.

🤖 Generated with Claude Code

chatgpt-codex-connector · 2026-04-24T08:59:36Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

Adds phase-offset awareness to PLV-based temporal coordination detection so callers can distinguish in-phase vs anti-phase (and other constant offsets) even when PLV magnitude is 1.

Changes:

Add meanPhaseOffset to return the argument of the mean complex phase-difference vector (when defined).
Add phaseLockingWithOffset to return PLV magnitude and offset in a single accumulation pass.
Add xUnit coverage for offset semantics, anti-phase regression, zero-magnitude behavior, and input edge cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
src/Core/TemporalCoordinationDetection.fs	Introduces offset-returning primitives alongside existing `phaseLockingValue`.
tests/Tests.FSharp/Algebra/TemporalCoordinationDetection.Tests.fs	Adds tests validating offset behavior (in-phase vs anti-phase), undefined-offset cases, and consistency with PLV magnitude.

…-ferry §B + §F + corrections #2 #7 #9 (#342) Research-grade design doc for the Stage-2 rung of Amara's corrected promotion ladder. Specifies: (a) placement under src/Experimental/CartelLab/ (not src/Core/ — that's Stage 4); (b) MetricVector type with PLV magnitude AND offset split (correction #6); (c) INullModelGenerator interface + Preserves/Avoids table columns; (d) IAttackInjector forward-looking interface (Stage 3); (e) Wilson-interval reporting contract with {successes, trials, lowerBound, upperBound} schema (correction #2 — no more "~95% CI ±5%" handwave); (f) RobustZScoreMode with Hybrid fallback (correction #7 — percentile-rank when MAD < epsilon); (g) explicit artifact-output layout under artifacts/ coordination-risk/ with five files + run-manifest.json (correction #9). 6-stage promotion path (0 doc / 1 ADR / 2.a skeleton / 2.b full null-models + first attack / 3 attack suite / 4 Core/NetworkIntegrity / 5 Aurora-KSK) matches Amara's corrected ladder and Otto-105 cadence. Doc-only change; no code, no tests, no workflow, no BACKLOG tail touch (avoids positional-conflict pattern that cost #334 → #341 re-file this session). This is the 7th of 10 18th-ferry operationalizations: - #1/#10 test-classification (#339) - #2 Wilson-interval design specified (this doc) - #6 PLV phase-offset shipped (#340) - #7 MAD=0 Hybrid mode specified (this doc) - #9 artifact layout specified (this doc) - #4 exclusivity already shipped (#331) - #5 modularity relational already shipped (#324) Remaining: Wilson-interval IMPLEMENTATION (waits on #323 + Stage 2.a), MAD=0 Hybrid IMPLEMENTATION (waits on #333 + Stage 2.a), conductance-sign doc (waits on #331), Stage-2.a skeleton itself. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

…-216) Active PR-resolve-loop on #340 (PLV mean phase offset). 1. Sentinel-default in test (thread 59WGi9): replaced Option.defaultValue -1.0 pattern in the phaseLockingWithOffset-magnitude-matches-phaseLockingValue consistency test with explicit pattern-match + fail on None. Sentinel form would silently pass the equality assertion if BOTH primitives returned None, masking regressions. 2. Broken ferry cross-reference path (thread 59WGjn): doc comment referenced docs/aurora/2026-04-24-amara- calibration-ci-hardening-deep-research-plus-5-5- corrections-18th-ferry.md which doesn't exist on main (only 7th / 17th / 19th ferries landed as standalone docs). Rewrote provenance to describe the ferry topically + cross-reference the related 19th- ferry DST audit that IS in the repo. 3. Misleading "same PLV-magnitude floor" wording (thread 59WGj4): doc said meanPhaseOffset's zero-magnitude check uses "the same PLV-magnitude floor" — phaseLockingValue has NO floor (returns values arbitrarily close to 0). Fixed: clarified that the phasePairEpsilon floor applies ONLY to the offset-undefined decision; phaseLockingValue returns magnitude without threshold. 4. Name-attribution in doc comment (thread 59WGkP): "Aaron + Amara 11th ferry" replaced with "the 11th ferry" per factory role-reference convention. Audit- trail surfaces (commit messages, tick-history, memory) retain direct attribution; code/doc comments use role references. 5. Duplicate sin/cos accumulation across 3 functions (thread 59WGkn): extracted private helpers phasePairEpsilon + meanPhaseDiffVector. All three functions (phaseLockingValue, meanPhaseOffset, phaseLockingWithOffset) now route through the shared accumulator. Eliminates drift risk — one function can no longer silently diverge from the others on accumulation or threshold. Build: 0 Warning(s) / 0 Error(s). All 37 TemporalCoordinationDetection tests pass. All 5 threads replied via GraphQL next step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Addresses Amara 18th-ferry correction #6: PLV = 1 can mean anti-phase locking, not same-time synchronization. Downstream detectors that rely on "PLV = 1 => synchronized" misread anti-phase coordinators as same-time coordinators. Two new functions in `TemporalCoordinationDetection`: - `meanPhaseOffset phasesA phasesB : double option` Returns the argument (angle) of the mean complex phase- difference vector whose magnitude is the PLV. Returns None when series are empty, mismatched-length, or when the mean vector has effectively zero magnitude (1e-12 floor) — in which case direction is mathematically undefined. - `phaseLockingWithOffset phasesA phasesB : struct (double * double) option` Returns both magnitude and offset in one sequence pass. Zero-magnitude case: magnitude near 0, offset = nan; near-zero magnitude is the caller's reliable "offset is undefined" signal. Existing `phaseLockingValue` contract unchanged; new primitives are additive. Downstream `Graph.coordinationRiskScore*` and any other detector consuming PLV can now add a separate offset- based term instead of collapsing both into one scalar (Amara's explicit recommendation in correction #6). 8 new xUnit tests covering: - Identical series (offset = 0) - Constant pi/4 offset (observed = -pi/4, a-minus-b convention) - Anti-phase series (magnitude 1, offset = pi) — the correction #6 regression test, contrasted against in-phase (offset 0) with identical magnitude - Uniformly-distributed differences (zero-magnitude => None) - Empty / mismatched-length / single-element edge cases - phaseLockingWithOffset magnitude matches phaseLockingValue (consistency property preventing silent detector divergence) - phaseLockingWithOffset zero-magnitude returns (near-zero, nan) - phaseLockingWithOffset returns None on empty/mismatched All 37 TemporalCoordinationDetection tests pass locally. 0 Warnings / 0 Errors build. 6th of the 10 18th-ferry corrections operationalized this week (after test-classification doc in #339, parser-tech in #338). Remaining: Wilson CIs in CartelToy tests (needs #323 landed), MAD=0 percentile-rank fallback (needs #333 landed), conductance-sign doc (needs #331 landed), artifact-output layout (Stage-2 with calibration harness). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

…-216) Active PR-resolve-loop on #340 (PLV mean phase offset). 1. Sentinel-default in test (thread 59WGi9): replaced Option.defaultValue -1.0 pattern in the phaseLockingWithOffset-magnitude-matches-phaseLockingValue consistency test with explicit pattern-match + fail on None. Sentinel form would silently pass the equality assertion if BOTH primitives returned None, masking regressions. 2. Broken ferry cross-reference path (thread 59WGjn): doc comment referenced docs/aurora/2026-04-24-amara- calibration-ci-hardening-deep-research-plus-5-5- corrections-18th-ferry.md which doesn't exist on main (only 7th / 17th / 19th ferries landed as standalone docs). Rewrote provenance to describe the ferry topically + cross-reference the related 19th- ferry DST audit that IS in the repo. 3. Misleading "same PLV-magnitude floor" wording (thread 59WGj4): doc said meanPhaseOffset's zero-magnitude check uses "the same PLV-magnitude floor" — phaseLockingValue has NO floor (returns values arbitrarily close to 0). Fixed: clarified that the phasePairEpsilon floor applies ONLY to the offset-undefined decision; phaseLockingValue returns magnitude without threshold. 4. Name-attribution in doc comment (thread 59WGkP): "Aaron + Amara 11th ferry" replaced with "the 11th ferry" per factory role-reference convention. Audit- trail surfaces (commit messages, tick-history, memory) retain direct attribution; code/doc comments use role references. 5. Duplicate sin/cos accumulation across 3 functions (thread 59WGkn): extracted private helpers phasePairEpsilon + meanPhaseDiffVector. All three functions (phaseLockingValue, meanPhaseOffset, phaseLockingWithOffset) now route through the shared accumulator. Eliminates drift risk — one function can no longer silently diverge from the others on accumulation or threshold. Build: 0 Warning(s) / 0 Error(s). All 37 TemporalCoordinationDetection tests pass. All 5 threads replied via GraphQL next step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Thread 59Yqkl (P1) — stale provenance reference: The doc cited `docs/aurora/2026-04-24-amara-temporal- coordination-detection-cartel-graph-influence-surface- 11th-ferry.md`, but the 11th ferry has not yet landed under `docs/aurora/` (it's queued in the Otto-105 operationalize cadence; PR #296 is its pending absorb). Replaced with the intent-preserving form: role references ("external AI collaborator's 11th courier ferry") plus a pointer at the MEMORY.md queue entry, so the provenance survives regardless of when the file-path question resolves. Also dropped the direct first-name so this factory-produced doc-comment tracks the name-attribution discipline. Thread 59YqlC (P2) — atan2 range correction: Doc said `(-pi, pi]` but `System.Math.Atan2` is documented as `[-pi, pi]` (both endpoints reachable under IEEE-754 signed-zero semantics: atan2(0, -1) = +pi, atan2(-0, -1) = -pi). Updated the doc to match the implementation. Behaviour unchanged.

Copilot AI review requested due to automatic review settings April 24, 2026 08:59

AceHack enabled auto-merge (squash) April 24, 2026 08:59

Copilot started reviewing on behalf of AceHack April 24, 2026 08:59 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

AceHack mentioned this pull request Apr 24, 2026

docs: calibration-harness Stage-2 design — Amara 18th-ferry §B/§F + corrections #2/#7/#9 #342

Merged

2 tasks

Copilot AI review requested due to automatic review settings April 24, 2026 11:53

AceHack force-pushed the core/plv-mean-phase-offset-amara-18th-ferry branch from 1dec76c to 0c73a12 Compare April 24, 2026 11:53

Copilot started reviewing on behalf of AceHack April 24, 2026 11:53 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread src/Core/TemporalCoordinationDetection.fs Outdated

Comment thread src/Core/TemporalCoordinationDetection.fs Outdated

AceHack and others added 3 commits April 24, 2026 08:07

AceHack force-pushed the core/plv-mean-phase-offset-amara-18th-ferry branch from 0c73a12 to 5562c7d Compare April 24, 2026 12:08

AceHack merged commit da02e5d into main Apr 24, 2026
11 checks passed

AceHack deleted the core/plv-mean-phase-offset-amara-18th-ferry branch April 24, 2026 12:10

This was referenced Apr 24, 2026

fix: strip history-log commentary from TemporalCoordinationDetection #361

Open

loop: tick-history row — Otto-219..221 drain + Otto-220 correction #362

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: PLV mean phase offset — 19th graduation (Amara 18th-ferry #6)#340

core: PLV mean phase offset — 19th graduation (Amara 18th-ferry #6)#340
AceHack merged 3 commits intomainfrom
core/plv-mean-phase-offset-amara-18th-ferry

AceHack commented Apr 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AceHack commented Apr 24, 2026

Summary

Key test: anti-phase regression

Test coverage

Build

18th-ferry correction tracking

Test plan

Uh oh!

chatgpt-codex-connector Bot commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants