shard(tick): 0503Z — PR #3359 four review threads addressed; recovery-worktree-borrowing 3x with peer-WIP preserved#3361
Merged
Conversation
…-worktree-borrowing used 3x with peer-WIP preserved PR #3359 had 4 unresolved threads (Codex P1 pipe-row schema, Copilot Nit rule-ref linking, Copilot untracked-survive caveat x2). All four addressed in commits 3392368 + 3aa67b7 and resolved via gh api graphql resolveReviewThread. PR auto-merged at 05:13:21Z (commit 19e7362). Shard documents: - poll-pr-gate.ts thread-count truncation (reported 1, actual 4) — investigate-threads discipline empirically validated. - Substrate-wide tick-shard-schema validator-vs-practice drift (all May 2026 shards violate the documented 6-column pipe-row schema; this PR's fix added pipe-row to 0414Z + 0458Z but the substrate-wide drift remains; follow-on B-NNNN row proposed). - Recovery-worktree-borrowing pattern used 3x on same PR (0452Z, 0458Z, 0503Z-x2) with peer-Otto WIP on .claude/skills/save-ai-memory/SKILL.md + 2 untracked files preserved across all borrows. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR adds a new hygiene-history tick shard (0503Z) documenting the resolution of review threads on PR #3359, plus observations about validator vs practice drift and a “recovery worktree borrowing” workflow.
Changes:
- Adds a pipe-row header and narrative tick entry for 2026-05-15 0503Z.
- Documents poll-pr-gate vs GraphQL thread-count mismatch and shard-schema validator drift.
- Records repeated worktree-borrowing usage with WIP preserved across branch switches.
|
|
||
| The `bun tools/github/poll-pr-gate.ts 3359` output reported `unresolvedThreads: 1`, but GraphQL `repository.pullRequest.reviewThreads(first:5)` returned 4 actually unresolved. The poll-pr-gate output is summarizing somehow (possibly filtering for "actionable" threads, or counting only the most-recent batch). If it had reported 4, the work-pickup decision would have been the same — but the data-honesty gap is worth flagging. | ||
|
|
||
| Per [`.claude/rules/blocked-green-ci-investigate-threads.md`](../../../../../.claude/rules/blocked-green-ci-investigate-threads.md) the discipline is to investigate threads directly via GraphQL, not rely on poll-pr-gate's summary count alone. This tick validated that discipline empirically. |
| VIOLATION: docs/hygiene-history/ticks/2026/05/15/0043Z.md — first row has 0 pipes; schema requires 6 columns (7+) | ||
| ``` | ||
|
|
||
| The validator is NOT wired into CI (`grep -rn "shard-schema" .github/workflows/` returns only `check-tick-history-order.ts` is wired). The practice diverged from the schema; the validator silently failed for the whole cohort. |
AceHack
added a commit
that referenced
this pull request
May 15, 2026
… drift (#3362) Codex P1 review on PR #3359 surfaced that tools/hygiene/check-tick-history-shard-schema.ts expects a 6-column pipe-row first line per docs/hygiene-history/ticks/README.md, but the May 2026 shard cohort universally starts with H1 (substrate-wide drift). Validator is NOT wired to CI, so violations have been invisible. This row proposes Option 3 (hybrid): pipe-row first line + H1-rich body. Three sub-tasks sequenced: backfill May 2026 shards, update README, wire validator to CI gate. Refs: - PR #3359 (Codex P1 surface) - PR #3361 (this tick's shard following hybrid pattern) Co-authored-by: Claude <noreply@anthropic.com>
6 tasks
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…estigation cleared 4 standard agent loops (#3365) Negative-finding substrate: cleared Lior, Riven, Codex/Vera, Copilot loops + lane-allocator + git worktree prune + git gc.pruneexpire as suspects for the worktree-pruning race observed in tick 0414Z. Source remains untraced; remaining candidates (claude-loop, otto-forward, peer-Otto, .git/hooks/, macOS system services) listed for next-tick investigation. Investigation-budget discipline: 12 tool calls; diminishing returns; next-tick continuation. Co-authored-by: Claude <noreply@anthropic.com>
This was referenced May 15, 2026
AnnamalaiMaheswaran
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/rules/...pathsgit switchrefusal condition +git stash -umitigation19e7362).Test plan
bun tools/hygiene/check-tick-history-shard-schema.ts --files docs/hygiene-history/ticks/2026/05/15/0503Z.md→ 0 violationsbun x markdownlint-cli2 docs/hygiene-history/ticks/2026/05/15/0503Z.md→ 0 violations🤖 Generated with Claude Code