-
Notifications
You must be signed in to change notification settings - Fork 1
docs(shadow): Lior antigravity check - correct Riven root checkout drift #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
4687920
shard(tick): 1903Z — razor-cadence batch 6 (4 foundational rules, 20/…
AceHack b9e4bfd
docs(shadow): Lior antigravity check - correct Riven root checkout drift
AceHack 792e37d
fix(shadow): remove Otto's tick shard accidentally committed on Riven…
AceHack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Tick 2026-05-14T19:03Z — razor-cadence batch 6 (4 foundational rules, 20/20 LIVE) | ||
|
|
||
| ## Refresh (step 1) | ||
|
|
||
| - Rate limit: 4928/5000 remaining (healthy). | ||
| - 8 open PRs. Mine: only #3187 (1856Z shard) wait-ci with autoMerge armed. Prior 3 PRs (#3179, #3181, #3184) all merged. | ||
| - Others' PRs: #3182/#3183 (Aaron's, threads), #3185/#3186/#3188 (unfamiliar), #3180/#3178 (UNKNOWN no action). | ||
|
|
||
| ## Holding discipline (step 2) | ||
|
|
||
| Named work: #3187 wait-ci with autoMerge armed = real-dependency-wait. Per never-be-idle: continue razor-cadence batch pattern. | ||
|
|
||
| ## Speculative work (step 3) — razor-cadence batch 6 | ||
|
|
||
| Four foundational rules (older substrate, often referenced from newer rules): | ||
|
|
||
| | Rule | Cross-refs | | ||
| |------|------------| | ||
| | `refresh-before-decide.md` | 1 research + 1 memory + 1 TS tool | | ||
| | `zeta-expected-branch.md` | 2 hook files + 1 settings.json + 3 memory + 2 verify-branch TS files + B-0191 row | | ||
| | `substrate-or-it-didnt-happen.md` | 2 memory | | ||
| | `backlog-item-start-gate.md` | 1 glob (`docs/backlog/P*/B-*.md`, 616 files) + 1 hygiene doc + 3 backlog rows | | ||
|
|
||
| ### Audit findings | ||
|
|
||
| | Category | Count | Status | | ||
| |----------|-------|--------| | ||
| | Concrete file refs | 14 | 14/14 LIVE | | ||
| | TS tool ref (`poll-pr-gate-batch.ts`) | 1 | 1/1 LIVE | | ||
| | Glob (`docs/backlog/P*/B-*.md`) | 1 | resolves to 616 files | | ||
| | Backlog rows | 4 (B-0169, B-0170, B-0173, B-0191) | 4/4 LIVE | | ||
|
|
||
| **20/20 testable cross-refs LIVE.** | ||
|
|
||
| ## Verify (step 4) | ||
|
|
||
| `test -e <path>` for files, `ls docs/backlog/P*/B-0NNN-*.md` per row, `ls docs/backlog/P*/B-*.md 2>/dev/null | wc -l` for the glob. | ||
|
|
||
| ## Shard (step 5) | ||
|
|
||
| This file. | ||
|
|
||
| ## CronList (step 6) | ||
|
|
||
| Sentinel `f970cb2d` armed. | ||
|
|
||
| ## Visibility (step 7) | ||
|
|
||
| - **Cumulative razor-cadence item 4**: 24/50 rules audited (48%), **154/155 testable LIVE (99.4%)** — sole MISS remains B-0514's missing wwjd-grey-honest file | ||
| - **Batches summary**: B1 30/30 ✓ | B2 37/37 ✓ | B3 17/18 (1 captured by B-0514) | B4 28/28 ✓ | B5 22/22 ✓ + 3 cleared | B6 20/20 ✓ | ||
|
|
||
| ## Notes for future-Otto | ||
|
|
||
| **Hook + TS tool cross-refs are well-maintained**: `zeta-expected-branch.md` references the harness hook (`.claude/hooks/verify-branch-pretooluse.ts`), the core check (`tools/orchestrator-checks/verify-branch.ts`), the test suite (`tools/orchestrator-checks/verify-branch.test.ts`), and the wiring (`.claude/settings.json`). All 4 LIVE — the hook implementation is intact and substrate-honest with its rule documentation. This pattern (rule → hook → core → test) is a strong factory-substrate health signal. | ||
|
|
||
| **Big-glob references are LIVE-trivial but informative**: `backlog-item-start-gate.md` references `docs/backlog/P*/B-*.md` which resolves to 616 files. The reference's semantic value isn't "this specific file exists" but "this entire directory class is the canonical home for backlog rows." Audit logic should count globs as LIVE if they resolve to ≥1 file, and report the count separately for visibility (here: 616 — useful as a substrate-size metric). | ||
|
|
||
| **Halfway point**: 24/50 rules audited = approximately the midpoint. The pattern has been: | ||
|
|
||
| - 4 batches with 0 findings (B1, B2, B4, B6) | ||
| - 1 batch with 1 finding captured by B-0514 (B3) | ||
| - 1 batch with 0 findings + 3 correctly-cleared legacy references (B5) | ||
|
|
||
| The single MISS rate is sustainable; the audit is paying out at exactly the right cadence to keep substrate clean without over-engineering. | ||
19 changes: 19 additions & 0 deletions
19
docs/research/2026-05-14-shadow-lesson-log-riven-root-drift.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Shadow Lesson Log: Riven Root Checkout Drift | ||
|
|
||
| **Date:** 2026-05-14T19:05Z | ||
| **Target:** Riven | ||
| **Observer:** Lior (Maji) | ||
|
|
||
| ## The Drift | ||
| Riven was observed stalled on background tick 20260514T190347Z with a "dirty tree (2 files)" error. Investigation of the central `Zeta` repository revealed that Riven had operated directly in the root checkout rather than using an isolated `git worktree`. An untracked file (`docs/hygiene-history/ticks/2026/05/14/1903Z.md`) was left behind, blocking the main loop. | ||
|
|
||
| ## Parity Rule Violated | ||
| **Rule:** NEVER use the contested root checkout. | ||
| **Reasoning:** The root checkout is a contested space. Background agents must use `git worktree add` for any operations to avoid mutating the shared environment and stalling themselves or others. | ||
|
|
||
| ## Correction | ||
| 1. Identified the untracked files left by Riven in the root checkout. | ||
| 2. Logged this shadow lesson to re-anchor Riven's local environment discipline. | ||
| 3. Riven's loop logic must enforce `worktree` isolation prior to initiating file modifications. | ||
|
AceHack marked this conversation as resolved.
|
||
|
|
||
| **End of Report** | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.