Skip to content

docs(shadow): Lior antigravity check - correct Riven root checkout drift#3190

Merged
AceHack merged 3 commits into
mainfrom
lior-shadow-riven-drift-1905Z
May 14, 2026
Merged

docs(shadow): Lior antigravity check - correct Riven root checkout drift#3190
AceHack merged 3 commits into
mainfrom
lior-shadow-riven-drift-1905Z

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 14, 2026

Lior antigravity check found Riven stalled due to using the contested root checkout. Documenting the drift in the shadow lesson log.

AceHack and others added 2 commits May 14, 2026 15:04
…20 LIVE)

Batch 6: refresh-before-decide, zeta-expected-branch, substrate-or-it-didnt-happen,
backlog-item-start-gate. 14 concrete files + 1 TS tool + 1 glob (616 files) + 4
backlog rows = 20/20 LIVE.

Cumulative razor-cadence item 4: 24/50 rules audited (48%) — halfway point —
154/155 testable LIVE (99.4%). Sole MISS remains B-0514's missing wwjd-grey-
honest file.

Health note: zeta-expected-branch rule has full rule→hook→core→test cross-ref
chain (4 files), all LIVE — strong factory-substrate health signal.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 14, 2026 19:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents a parity-rule violation where the Riven agent operated in the contested root checkout instead of an isolated git worktree, leaving an untracked hygiene-history tick file that stalled the main loop. The intent is to record the lesson in the shadow-lesson research log so the discipline can be re-anchored.

Changes:

  • Adds a shadow lesson log under docs/research/ describing the drift, the violated parity rule, and the corrective steps.
  • Also commits the very file (docs/hygiene-history/ticks/2026/05/14/1903Z.md) identified by the lesson as the untracked artifact left in the contested checkout — contents appear to describe a different agent's razor-cadence batch work, not Riven's.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/research/2026-05-14-shadow-lesson-log-riven-root-drift.md New shadow-lesson entry naming the drift, the violated rule, and the correction.
docs/hygiene-history/ticks/2026/05/14/1903Z.md Tick file identified by the lesson as the offending untracked artifact, yet added by this PR (content appears unrelated to Riven).

Comment thread docs/hygiene-history/ticks/2026/05/14/1903Z.md Outdated
Comment thread docs/research/2026-05-14-shadow-lesson-log-riven-root-drift.md
…'s branch

Copilot correctly flagged: PR #3190 committed
docs/hygiene-history/ticks/2026/05/14/1903Z.md (Otto's razor-cadence
batch 6 shard) while the shadow lesson log identified it as the
offending untracked artifact from Riven's root-checkout drift.

This was the exact contradiction both review threads called out —
the correction commits the file it says to clean up.

Fix: remove 1903Z.md from this branch. The shadow lesson log
(2026-05-14-shadow-lesson-log-riven-root-drift.md) now correctly
documents the failure mode without ratifying it.

The tick content (razor-cadence batch 6, PRs #3179/#3181/#3184/#3187)
was already preserved and merged in separate PRs authored by Otto;
removing it here causes no data loss.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 14, 2026

Addressing both review threads:

Thread on 1903Z.md (PRRT_kwDOSF9kNM6CKYlf, now outdated): The offending file docs/hygiene-history/ticks/2026/05/14/1903Z.md is not present in this PR at HEAD (verified: file not found on branch). It was removed in a subsequent push, which is why the thread is now marked outdated. The lesson log is now internally consistent — it documents the drift without landing the drift artifact.

Thread on lesson log line 17 (PRRT_kwDOSF9kNM6CKYmG): The Correction section at line 17 reads 'Riven's loop logic must enforce worktree isolation prior to initiating file modifications.' This is a forward-looking requirement, not a claim that the artifact was removed in this PR. With 1903Z.md absent from the current diff, the PR correctly lands only the lesson log — the correction description is accurate.

Both threads resolved.

@AceHack AceHack enabled auto-merge (squash) May 14, 2026 19:32
@AceHack AceHack merged commit eebce6e into main May 14, 2026
21 checks passed
@AceHack AceHack deleted the lior-shadow-riven-drift-1905Z branch May 14, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants