fix(tsc): resolve two lint (tsc tools) errors from mythology catalog PRs#2427
Merged
Conversation
… catalog PRs TS2322 (candidate-schema.ts:52): f2Strength 'strong-but-looser' not assignable to union 'weak'|'moderate'|'strong' — change to 'moderate'; qualifier moved to notes field. TS2375 (mythology-catalog-schema.ts:451): explicit `sourceMemory: undefined` violates exactOptionalPropertyTypes=true — remove line; omission is correct for absent optional properties. Both errors pre-existed in main via #2423/#2424; first surfaced by tsc lint running against PR #2426's merge context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes two TypeScript type-check issues introduced by prior mythology-catalog PRs, unblocking the lint (tsc tools) CI job while preserving the intended semantics of the seed data.
Changes:
- Adjust
heimdallrSeed.threeFilter.f2Strengthto a valid union member ("moderate") and move the prior qualifier intonotes. - Remove
sourceMemory: undefinedfrom a seed catalog entry to comply withexactOptionalPropertyTypes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/resonance/mythology-catalog-schema.ts | Removes an explicit undefined optional property assignment that violates exactOptionalPropertyTypes. |
| tools/mythology-resonance/candidate-schema.ts | Updates the Heimdallr seed’s f2Strength to a valid literal and preserves nuance in notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/mythology-resonance/candidate-schema.ts:52:f2Strength: 'strong-but-looser'is not assignable to the union'weak' | 'moderate' | 'strong'. Changed to'moderate'; qualifier moved into thenotesfield.tools/resonance/mythology-catalog-schema.ts: explicitsourceMemory: undefinedviolatesexactOptionalPropertyTypes: true. Removed the line — omitting an optional property is correct; explicitly setting toundefinedis not.Both errors were introduced in
#2423/#2424(mythology catalog PRs) and first surfaced by thelint (tsc tools)CI job running against PR#2426's merge context.#2426auto-merged before the fix could land on its branch.Test plan
bun --bun tsc --noEmit -p tsconfig.json— 0 errors after fix (verified locally)'moderate'is semantically accurate (explicitly described as "strong-but-looser" = below strong); qualifier preserved in notessourceMemoryomission matches all other catalog entries that lack a source memory file🤖 Generated with Claude Code