fix(B-0272): parse single-quoted DAT attributes#2172
Merged
Conversation
Teach the Logiqx DAT parser to accept single-quoted XML attribute values while preserving the existing double-quoted path. Add a focused parser regression for single-quoted ROM attributes. Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
Updates the Logiqx DAT XML parsing in the ROM canonicalizer to accept both double-quoted and single-quoted attribute values, matching real-world DAT variants, and adds a regression test to prevent future breakage.
Changes:
- Extend ROM attribute parsing to support single-quoted XML attributes in
<rom ... />tags. - Add a focused
parseDatfiletest covering single-quoted attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/roms/canonicalize.ts | Expands the attribute regex to parse both " and ' quoted values and uses the correct capture group. |
| tools/roms/canonicalize.test.ts | Adds a regression test ensuring single-quoted attributes are parsed into the SHA1-keyed lookup. |
AceHack
added a commit
that referenced
this pull request
May 16, 2026
…th pure-drift this session) (#3820) 10th pure-drift close of the resume-session sequence. All 3 acceptance items verifiably shipped via PRs #2166 + #2168 + #2172: - Script at tools/roms/canonicalize.ts (8953 bytes) - TOSEC + No-Intro matching via Logiqx XML - Rename + unmatched-hash reporting Surfaced by peer Otto's audit-backlog-status-drift.ts (PR #3758); per-acceptance verification confirmed pure-drift. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
Co-Authored-By: Codex noreply@openai.com