fix(B-0272): address ROM tool review nits#2166
Merged
Merged
Conversation
Tighten the ROM canonicalizer review surface by documenting the actual JSON fields, hashing files with bounded memory, ignoring extensionless files by default, using dirname for rename targets, validating option values, bumping the backlog timestamp, and keeping the DAT fixture realistic. Focused checks: bun test tools/roms/canonicalize.test.ts; git diff --check. Local typecheck remains blocked because tsc is not installed in this worktree. Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2ebe24e29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Refines the ROM canonicalization tool introduced for B-0272 by tightening CLI behavior, making hashing more memory-bounded, and aligning docs/tests with the actual JSON output and filtering semantics.
Changes:
- Document the actual JSON output shape and adjust rename target directory handling (
dirname). - Switch SHA1 hashing to buffered reads (bounded memory) and ignore extensionless files by default in directory scans.
- Improve CLI option validation, fix the test DAT fixture, add a CLI error-path test, and bump B-0272
last_updated.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/roms/canonicalize.ts | Updates hashing to streaming reads, tightens scan filtering, improves option parsing, and fixes rename target dir handling/documented output fields. |
| tools/roms/canonicalize.test.ts | Fixes DAT fixture and adds coverage for extensionless-file ignoring and clearer CLI error messaging. |
| docs/backlog/P1/B-0272-atari-rom-canonical-naming-tosec-lookup-2026-05-08.md | Updates last_updated for the backlog row. |
AceHack
added a commit
that referenced
this pull request
May 16, 2026
…th pure-drift this session) (#3820) 10th pure-drift close of the resume-session sequence. All 3 acceptance items verifiably shipped via PRs #2166 + #2168 + #2172: - Script at tools/roms/canonicalize.ts (8953 bytes) - TOSEC + No-Intro matching via Logiqx XML - Rename + unmatched-hash reporting Surfaced by peer Otto's audit-backlog-status-drift.ts (PR #3758); per-acceptance verification confirmed pure-drift. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
Follow-up to #2165 after the auto-merge raced the review-nit commit.