Conversation
…st-risk first per #1376 risk-stratification) Per Aaron 2026-05-03 "fully converted" directive + B-0156 TS standardization, deferred 5 .sh files in tools/hygiene/ all referenced from CI workflows. #1376 stratified by risk: - LOW: memory-index-duplicate-lint.yml (this PR — single-tool, scoped path filter) - LOW: memory-reference-existence-lint.yml (next) - HIGH: gate.yml (3 of 5 .sh refs; load-bearing all-PR gate; last) This PR (lowest-risk first) tests the pattern: 1. Add `./tools/setup/install.sh` step (provides bun via mise per GOVERNANCE §24, same pattern as gate.yml) 2. Update path filters .sh → .ts 3. Replace `tools/hygiene/audit-memory-index-duplicates.sh --enforce` with `bun tools/hygiene/audit-memory-index-duplicates.ts --enforce` Verified locally: both .sh and .ts produce identical output ("no duplicate memory-index links in memory/MEMORY.md") and exit code (0) for current MEMORY.md state. If this PR's CI passes, apply same pattern to memory-reference-existence-lint.yml next, then gate.yml. Each is its own bounded PR per risk-stratified deferral discipline. The .sh file is NOT removed in this PR — keep both .ts and .sh during the transition; .sh removal happens AFTER all 3 workflows are .ts-based AND verified.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Updates the memory-index-duplicate-lint GitHub Actions workflow to run the TypeScript+Bun implementation of the duplicate-link audit tool, aligning this workflow with the repo’s ongoing TS+Bun tooling standardization and the staged rollout plan described in PR #1376.
Changes:
- Switch workflow path filters and documentation references from
audit-memory-index-duplicates.shtoaudit-memory-index-duplicates.ts. - Add a toolchain bootstrap step via
./tools/setup/install.shto ensure Bun is available on the runner. - Replace the lint invocation from the
.shtool tobun ...audit-memory-index-duplicates.ts --enforce.
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…flow Reviewer-caught: FACTORY-HYGIENE.md row 59 documented `tools/hygiene/audit-memory-references.sh --enforce` as the shipped tool, but PR #1378 switches the workflow to call `bun tools/hygiene/audit-memory-references.ts --enforce`. The doc and the workflow would have disagreed the moment #1378 merged. Two changes in row 59: - Tool invocation: `tools/hygiene/audit-memory-references.sh --enforce` → `bun tools/hygiene/audit-memory-references.ts --enforce` - Composes-with pointer: `tools/hygiene/audit-memory-references.sh` → `tools/hygiene/audit-memory-references.ts` Composes with #1377 (memory-index-duplicate-lint.yml .sh→.ts), which landed without a corresponding FACTORY-HYGIENE row update because no row documents that workflow yet (the audit-memory-index-duplicates.ts tool was never called out by row in the same way row 59 calls out audit-memory-references). Future TS-port work should grep FACTORY-HYGIENE.md for the .sh pointer before opening the workflow PR.
3 tasks
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…same pattern as #1377) (#1378) * ci(memory-reference-existence-lint): switch from .sh to .ts via bun (same pattern as #1377; second-lowest-risk) * docs(factory-hygiene): row 59 — point at .ts tool to match #1378 workflow Reviewer-caught: FACTORY-HYGIENE.md row 59 documented `tools/hygiene/audit-memory-references.sh --enforce` as the shipped tool, but PR #1378 switches the workflow to call `bun tools/hygiene/audit-memory-references.ts --enforce`. The doc and the workflow would have disagreed the moment #1378 merged. Two changes in row 59: - Tool invocation: `tools/hygiene/audit-memory-references.sh --enforce` → `bun tools/hygiene/audit-memory-references.ts --enforce` - Composes-with pointer: `tools/hygiene/audit-memory-references.sh` → `tools/hygiene/audit-memory-references.ts` Composes with #1377 (memory-index-duplicate-lint.yml .sh→.ts), which landed without a corresponding FACTORY-HYGIENE row update because no row documents that workflow yet (the audit-memory-index-duplicates.ts tool was never called out by row in the same way row 59 calls out audit-memory-references). Future TS-port work should grep FACTORY-HYGIENE.md for the .sh pointer before opening the workflow PR.
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…t tier per #1376) (#1380) The gate.yml workflow ran three lint scripts as .sh: - tools/hygiene/check-tick-history-order.sh - tools/hygiene/check-no-conflict-markers.sh - tools/hygiene/check-archive-header-section33.sh All three have a TS+Bun port in tools/hygiene/<name>.ts with full output / exit-code parity verified locally (179 tick-history rows non-decreasing; 0 conflict-marker violations; 0 §33 archive-header violations). Why this PR closes the .sh→.ts cleanup loop: - #1377 converted memory-index-duplicate-lint.yml (lowest-risk — only fires on memory/MEMORY.md changes) - #1378 converted memory-reference-existence-lint.yml (lowest-risk — only fires on memory/** changes) - This PR converts gate.yml's three lint jobs (highest-risk — fires on every PR via the all-PR gate critical path) - #1379 (rerere ALLOWLIST parity) was a prerequisite — the .ts port of check-no-conflict-markers had to ALLOWLIST the rerere memo to match the .sh version BEFORE running on every PR After this lands and CI verifies green, the 5 deferred .sh files can be removed (audit-memory-index-duplicates.sh, audit-memory-references .sh, check-archive-header-section33.sh, check-no-conflict-markers.sh, check-tick-history-order.sh) — completing the .sh cleanup the maintainer asked for in #1371 ("we should clean up .sh and any .sh where we have the .ts I thought we were fully converted"). Conversion pattern (identical for all three jobs): - Add "Install toolchain via three-way-parity script" step calling ./tools/setup/install.sh — same shape as #1377 + #1378 - Change `run: tools/hygiene/<name>.sh` to `run: bun tools/hygiene/<name>.ts` Three lint jobs run in parallel (one job each), so the bun install cost is bounded by the slowest job's path — does not compound.
3 tasks
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…conversion completed (#1382) The maintainer asked in #1371: *"we should clean up .sh and any .sh where we have the .ts I thought we were fully converted."* Initially 13 zero-ref .sh files were removed; 5 were deferred because they were still referenced from CI workflows. Those 3 workflows are now all converted (#1377 + #1378 + #1380), and #1379 fixed the prerequisite allowlist parity bug in check-no-conflict-markers.ts. Removed: - tools/hygiene/audit-memory-index-duplicates.sh (→ memory-index-duplicate-lint.yml via #1377) - tools/hygiene/audit-memory-references.sh (→ memory-reference-existence-lint.yml via #1378) - tools/hygiene/check-archive-header-section33.sh (→ gate.yml via #1380) - tools/hygiene/check-no-conflict-markers.sh (→ gate.yml via #1380) - tools/hygiene/check-tick-history-order.sh (→ gate.yml via #1380) All 5 .ts ports run clean locally post-deletion (exit 0; same output as the .sh equivalents — verified manually before this commit). Surface-update set (active substrate that pointed at the .sh as a current tool): - tools/hygiene/LOST-FILES-LOCATIONS.md — survey command + composes-with pointers updated from .sh to .ts (the only runtime-bound reference) - docs/trajectories/typescript-bun-migration/RESUME.md — Bucket D listing updated; 5 entries removed; new "Removed 2026-05-03" note added explaining why - tools/hygiene/audit-orphan-role-refs.sh — comment composes-with template updated to .ts - tools/hygiene/check-role-ref-on-current-state-surfaces.sh — comment composes-with sibling-pattern updated to .ts - tools/hygiene/sort-tick-history-canonical.ts — comment composes-with detection-check updated to .ts - tools/hygiene/check-tick-history-shard-schema.sh — comment composes-with legacy-monolithic-check updated to .ts - tools/lint/doc-comment-history-audit.baseline — 2 entries for the deleted audit-memory-references.sh removed (else baseline would diff against the next audit run that no longer matches a deleted path) Historical surfaces deliberately NOT updated (pure history record): - docs/hygiene-history/** (tick shards + loop-tick-history.md) - docs/pr-preservation/** (preservation logs) - docs/research/** (research reports) - memory/** (history-surface attribution carve-out) - docs/backlog/** rows (describe past tickets that referenced .sh) - docs/0-0-0-readiness/CLASSIFICATION.md (sync-classification audit of past LFG↔AceHack divergence) Closes the .sh→.ts cleanup loop opened in #1371. Composes with #1373 + #1374 (stale-ref sweeps that caught earlier comprehensive-ref-check misses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Aaron 2026-05-03 'fully converted' + B-0156 TS standardization. Lowest-risk-first per #1376 risk-stratification. Adds setup step for install.sh (mise+bun per GOVERNANCE §24); replaces .sh with bun .ts call. Verified locally: both produce identical output + exit code. .sh NOT removed in this PR — kept during transition; removal after all 3 workflows are .ts-based + verified.