Skip to content

fix(tsc strict): no-op-cadence-pattern.ts — fallback for regex match groups #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 2 commits into from
May 3, 2026
Merged

fix(tsc strict): no-op-cadence-pattern.ts — fallback for regex match groups #1369

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec422ef
fix(tsc strict): no-op-cadence-pattern.ts — fallback for m2[1] / m2[2…
AceHack May 3, 2026
8ab4efd
fix(#1369 review): use non-null assertion (m2[1]! / m2[2]!) preservin…
AceHack May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/hygiene/check-no-op-cadence-pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ export function collectShards(dir: string, dateFlat: string): Shard[] {
const m2 = name.match(/^(\d{6})Z-([0-9a-f]+)\.md$/);
if (m2) {
shards.push({
primary: `${dateFlat}${m2[1]}`,
disamb: m2[2],
primary: `${dateFlat}${m2[1] ?? ""}`,
disamb: m2[2] ?? "",
Comment thread
AceHack marked this conversation as resolved.
Outdated
path: join(dir, name),
});
}
Expand Down
Loading