fix(tsc strict): no-op-cadence-pattern.ts — fallback for regex match groups#1369
Merged
fix(tsc strict): no-op-cadence-pattern.ts — fallback for regex match groups#1369
Conversation
…] regex matches (TS strict-undefined check)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…g regex-required-groups invariant explicitly (vs ?? '' silent-fallback)
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…ix with non-null assertion vs silent fallback) (#1370)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-#1366-merge tsc strict-mode error on line 100:
m2[2]typed asstring | undefined. Same onm2[1]template interpolation. Added?? ""fallbacks. Behavior unchanged (regex guarantees both groups exist when m2 is truthy).