Repository navigation
fix(bot): defer-first in play command and guard deferReply against 40060 - #431
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
dependencies
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR addresses Discord interaction acknowledgement race conditions by deferring interaction replies earlier in the command execution lifecycle and wrapping acknowledgement calls with try-catch error handling to gracefully discard duplicate/concurrent acknowledgement errors (40060). Changes
Sequence Diagram(s)sequenceDiagram
actor Client as Discord Client
participant Play as Play Command
participant IH as Interaction Handler
Client->>Play: Execute play command
Play->>IH: deferReply() [at start]
IH->>IH: try: await deferReply()
IH-->>Play: Acknowledged (or error caught)
alt Validation Failure
Play->>IH: editReply(embed)
IH->>IH: try: await editReply()
IH-->>Play: Reply sent (or error caught)
else Success/Continue
Play->>Play: Queue/playback logic
Play->>IH: editReply(embed)
IH->>IH: try: await editReply()
IH-->>Play: Reply sent (or error caught)
end
Play-->>Client: Command result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 318 kB ℹ️ View Unchanged
|
|
This was referenced Apr 1, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferReply()to the top of play commandexecute, before guildId/voice/collaborative checks. Converts early-exitreply()toeditReply(). Fixes LUCKY-1Y (Unknown interaction on early exits).deferReply()inhandleChatInputCommandandhandleOtherInteractionin a try-catch — if the interaction is already acknowledged (40060) or expired (10062), we silently return instead of throwing. Fixes LUCKY-23.Test plan
/playcommand responds even when user is not in a voice channelDiscordAPIError[40060]in SentrySummary by CodeRabbit