Repository navigation
fix(bot): SoundCloud audio bridge + Track.setMetadata fix (v2.6.54) - #425
Conversation
|
Deployment failed with the following error: |
github-actions
Bot
added
dependencies
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 28 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughAdds a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BotPlayer as Bot Player
participant Youtubei as YoutubeiExtractor
participant StreamBridge as streamViaSoundCloud
participant SoundCloudAPI as SoundCloud API
participant AudioStream as ReadableStream
User->>BotPlayer: Request play (YouTube URL / search)
BotPlayer->>Youtubei: resolve metadata (generateWithPoToken: true)
Youtubei-->>BotPlayer: provide metadata (title, author, duration)
BotPlayer->>StreamBridge: createStream(track)
StreamBridge->>SoundCloudAPI: search by title+author (limit 5)
SoundCloudAPI-->>StreamBridge: search results
StreamBridge->>StreamBridge: validate best match (title similarity, duration ±15s)
StreamBridge->>SoundCloudAPI: request stream for chosen track
SoundCloudAPI-->>AudioStream: return Readable stream
StreamBridge-->>BotPlayer: return Readable stream
BotPlayer->>AudioStream: pipe to playback output
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
packages/bot/tests/handlers/player/playerFactory.test.ts (1)
57-75: The new!registeredpath still isn't covered.These tests verify the options passed to
register(), but they never assert the warning branch this PR adds for falsy registration results. Please add one explicitnull/undefinedregistration test, and make the config assertions run with a truthy mock so the happy path is exercised too.Based on learnings, "Add or adjust unit and integration tests when changing behavior; follow existing patterns in
packages/*/testsand roottests/directories".Also applies to: 78-93
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/tests/handlers/player/playerFactory.test.ts` around lines 57 - 75, Add a new unit test that forces the register() mock to return a falsy value (null or undefined) to cover the new "!registered" warning branch, then assert that the warning/log path is taken; additionally ensure the existing test still exercises the happy path by using a truthy mock return for player.extractors.register and keep the current assertions on options.streamOptions.useClient, options.streamOptions.highWaterMark, and options.generateWithPoToken. Locate and modify/create tests around createPlayer and player.extractors.register in playerFactory.test.ts (and duplicate the same null/undefined case mentioned for the block around lines 78–93) so one test explicitly mocks register() => null/undefined and asserts the warning, and another test mocks register() => truthy and asserts the config values.packages/bot/src/handlers/player/playerFactory.spec.ts (1)
34-45: These assertions don't protect the real extractor wiring.Both cases only assert fields on objects created inside the test, so they still pass if
playerFactory.tsstops settinggenerateWithPoTokenorcreateStream. Please point this suite at the real factory or drop it in favor of the existing handler test.Based on learnings, "Test behavior, not implementation details".
Also applies to: 48-61
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/src/handlers/player/playerFactory.spec.ts` around lines 34 - 45, The test currently asserts only on a locally-constructed extractorOptions object and not on the real wiring in playerFactory.ts; update the spec to exercise the real factory (e.g., import and call the factory function in playerFactory.ts that returns an extractor or stream) and assert that the returned extractor/stream has useClient === 'IOS', highWaterMark === 1<<25 (33554432), and that generateWithPoToken is applied (or that createStream behavior when generateWithPoToken is true is observed); alternatively remove this redundant spec and rely on the existing handler test. Reference playerFactory.ts, the factory function that creates the extractor/stream, and the generateWithPoToken and createStream behavior when making the change.packages/bot/src/functions/general/commands/version.spec.ts (2)
7-20: Avoid duplicating command logic inside the spec.
readVersionFromStreamin test code duplicates production parsing behavior, which can let both drift together and still pass. Prefer importing/exercising the command logic (or a shared exported parser) directly.Based on learnings: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/src/functions/general/commands/version.spec.ts` around lines 7 - 20, The test-defined readVersionFromStream duplicates production parsing logic; instead remove or replace readVersionFromStream and reuse the real parsing code by importing and exercising the production parser or command (e.g., import the parse/version function or invoke the Version command implementation used in production) so the spec validates behavior, not a twin implementation—update the test to call the production symbol (instead of readVersionFromStream) or expose a shared parseVersionFromStream/parser function from the command module and use that in the test.
44-47: Test name is misleading relative to the assertion.The test title says readline closure behavior, but it only asserts the returned value. Either rename it to outcome-focused behavior or assert close semantics explicitly.
Based on learnings: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/src/functions/general/commands/version.spec.ts` around lines 44 - 47, The test title "closes readline even when version is not found" is misleading for the assertion against readVersionFromStream; either rename the spec to describe the outcome (e.g., "returns 'unknown' when version is not found") or add an explicit assertion that the stream/readline was closed. Locate the test in version.spec.ts and update the it(...) invocation for readVersionFromStream: either change the description string to reflect the returned value, or keep the current title and assert closure semantics by checking the stream state (e.g., verify stream.destroyed or stream.readableEnded is true, or attach a spy/listener with stream.on('close', fn) and expect the spy to have been called).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 10-26: The README is missing docs matching the CHANGELOG: add a
short section documenting the new /version command (it replies ephemerally with
the bot version read from package.json), and update playback notes to mention
the YoutubeiExtractor changes—specifically that it registers with
generateWithPoToken and injects a createStream override to route audio via
SoundCloud (title+author search) when CDN blocking occurs—and also note the
metadata API change (use track.setMetadata(...) rather than assigning
Track.metadata). Ensure these entries reference the exact symbols (/version,
package.json, YoutubeiExtractor, generateWithPoToken, createStream,
track.setMetadata) so users and operators can find the behavior in code.
In `@packages/bot/src/functions/general/commands/version.spec.ts`:
- Line 53: The test's semver regex used in the assertion
expect(version).toMatch(...) is too permissive and allows trailing characters;
update that assertion to use an end-anchored semver pattern that validates
major.minor.patch and optional pre-release/build metadata (i.e., require the
string to end after the semver) so version only matches valid semver strings;
modify the expect(version).toMatch call accordingly (replace the current regex
with a stricter end-anchored semver regex).
In `@packages/bot/src/functions/general/commands/version.ts`:
- Around line 9-22: readVersion currently lets file-read errors bubble up;
change it to catch any exceptions from reading/parsing package.json, return
'unknown' on error, and ensure callers (the /version command handler) use
interactionReply and createUserFriendlyError from `@lucky/shared/general` to send
the response instead of throwing. Specifically, wrap the body of readVersion
(the createReadStream/for-await loop and rl.close) in a try/catch where the
catch returns 'unknown' and still closes rl in finally, and update the command
handler that calls readVersion to call interactionReply(interaction, { content:
version }) on success and interactionReply(interaction,
createUserFriendlyError(err)) on failure so no file IO error becomes a hard
rejection visible to the user.
In `@packages/bot/src/handlers/player/playerFactory.ts`:
- Around line 44-53: streamViaSoundCloud currently picks results[0] unvalidated
and can return wrong audio or throw; update streamViaSoundCloud (the function
passed as createStream in player.extractors.register for mod.YoutubeiExtractor)
to validate SoundCloud results against the original YouTube track metadata
(compare duration +/- tolerance, title/author fuzzy match, and any available
identifiers) before building a stream; if no result passes validation, do not
return an unvalidated stream—either return null so the extractor can fall back
to the native youtubei.js stream or throw a clear, specific error indicating
"SoundCloud validation failed: no matching result" so higher-level code can
decide to fallback. Ensure the validation logic checks that results.length>0
before accessing results[0] and centralize the matching rules inside
streamViaSoundCloud for maintainability.
---
Nitpick comments:
In `@packages/bot/src/functions/general/commands/version.spec.ts`:
- Around line 7-20: The test-defined readVersionFromStream duplicates production
parsing logic; instead remove or replace readVersionFromStream and reuse the
real parsing code by importing and exercising the production parser or command
(e.g., import the parse/version function or invoke the Version command
implementation used in production) so the spec validates behavior, not a twin
implementation—update the test to call the production symbol (instead of
readVersionFromStream) or expose a shared parseVersionFromStream/parser function
from the command module and use that in the test.
- Around line 44-47: The test title "closes readline even when version is not
found" is misleading for the assertion against readVersionFromStream; either
rename the spec to describe the outcome (e.g., "returns 'unknown' when version
is not found") or add an explicit assertion that the stream/readline was closed.
Locate the test in version.spec.ts and update the it(...) invocation for
readVersionFromStream: either change the description string to reflect the
returned value, or keep the current title and assert closure semantics by
checking the stream state (e.g., verify stream.destroyed or stream.readableEnded
is true, or attach a spy/listener with stream.on('close', fn) and expect the spy
to have been called).
In `@packages/bot/src/handlers/player/playerFactory.spec.ts`:
- Around line 34-45: The test currently asserts only on a locally-constructed
extractorOptions object and not on the real wiring in playerFactory.ts; update
the spec to exercise the real factory (e.g., import and call the factory
function in playerFactory.ts that returns an extractor or stream) and assert
that the returned extractor/stream has useClient === 'IOS', highWaterMark ===
1<<25 (33554432), and that generateWithPoToken is applied (or that createStream
behavior when generateWithPoToken is true is observed); alternatively remove
this redundant spec and rely on the existing handler test. Reference
playerFactory.ts, the factory function that creates the extractor/stream, and
the generateWithPoToken and createStream behavior when making the change.
In `@packages/bot/tests/handlers/player/playerFactory.test.ts`:
- Around line 57-75: Add a new unit test that forces the register() mock to
return a falsy value (null or undefined) to cover the new "!registered" warning
branch, then assert that the warning/log path is taken; additionally ensure the
existing test still exercises the happy path by using a truthy mock return for
player.extractors.register and keep the current assertions on
options.streamOptions.useClient, options.streamOptions.highWaterMark, and
options.generateWithPoToken. Locate and modify/create tests around createPlayer
and player.extractors.register in playerFactory.test.ts (and duplicate the same
null/undefined case mentioned for the block around lines 78–93) so one test
explicitly mocks register() => null/undefined and asserts the warning, and
another test mocks register() => truthy and asserts the config values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d0095633-d220-447f-a33b-fc6cc5fbb45f
📒 Files selected for processing (10)
CHANGELOG.mdpackages/bot/package.jsonpackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/twitch/index.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.tspackages/bot/src/utils/music/sessionSnapshots.tspackages/bot/tests/handlers/player/playerFactory.test.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (23)
{LICENSE,COPYING,COPYING.md,LICENSE.md,license.txt,**/package.json,**/requirements.txt,**/Cargo.toml,**/pom.xml,**/composer.json}
📄 CodeRabbit inference engine (.cursor/rules/accessibility-openness.mdc)
Respect OSS licenses for third-party code and declare license in repo
Files:
packages/bot/package.json
packages/bot/**
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
The
botpackage depends onsharedand contains Discord bot commands and player handlers using Discord.js and Discord Player
Files:
packages/bot/package.jsonpackages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{js,jsx,ts,tsx,vue,html}
📄 CodeRabbit inference engine (.cursor/rules/accessibility-openness.mdc)
Provide accessible UI components using semantic HTML and ARIA attributes where necessary
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/dependency-injection.mdc)
**/*.{ts,tsx,js,jsx}: Prefer constructor injection for classes that require dependencies
Avoid global mutable singletons unless necessary
Use explicit interfaces for external dependencies to make testing easier
**/*.{ts,tsx,js,jsx}: Include required references in PRs/code for non-trivial logic: TypeScript (official docs), MDN (JavaScript reference), and official docs for any runtime/framework/libraries used (e.g., Node.js, React) as applicable.
Before assuming behavior of an API, include the doc link and a ≤25-word quote when the change relies on it.
**/*.{ts,tsx,js,jsx}: Prefer named exports for clear usage and easier refactors in TypeScript/JavaScript
Keep import order consistent: external first, then internal modules
Remove dead code and unused imports
**/*.{ts,tsx,js,jsx}: Use PascalCase naming convention for React/UI components
Use camelCase naming convention for variables and functions
Use UPPER_SNAKE_CASE naming convention for constants
Maintain consistent import grouping and ordering within the project, keeping third-party imports separate from local imports
For external data sources (HTTP, database), always validate and sanitize input using type guards or schema validators
**/*.{ts,tsx,js,jsx}: Use Prettier with no semicolons, single quotes, 4-space indent, 80 character width
Files must not exceed 250 lines and this is enforcedImplement TypeScript typecheck and linter in CI quality checks
**/*.{ts,tsx,js,jsx}: Use TypeScript for enhanced type safety
Implement error handling and error logging
Avoid commenting code unless extremely necessary - code should explain itself with descriptive names
Leave NO todos, placeholders or missing pieces in the code
Variables and functions must use camelCase
Constants must use UPPER_SNAKE_CASE
Use arrow functions for methods and computed properties
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements
Maintain consistent import grouping/order: external imports first, then...
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
**/*.{js,jsx,ts,tsx}: Never throw strings. ThrowError(or typed subclasses) with descriptive messages
Include causal error ascausewhen available for better debugging
Define clear, stable error codes (e.g.,ERR_AUTH_EXPIRED,ERR_NETWORK_TIMEOUT)
Provide optional metadata (e.g.,details,retryable,status,correlationId) in error objects
Use domain error classes per area (e.g.,AuthenticationError,ValidationError,NetworkError)
Log errors with structure (message, code, stack, cause, correlationId, user context where appropriate)
MarkretryablevsnonRetryableerrors where helpful for operations
Set timeouts and handle aborts/cancellations; avoid dangling requests in API/network code
Implement backoff for transient failures; avoid infinite retries
Map HTTP status → domain errors; 4xx vs 5xx behave differently (e.g., retry for 5xx/network)
**/*.{js,jsx,ts,tsx}: Use functional components with hooks in React/React Native. Avoid class components.
Keep components focused on a single responsibility; extract complex logic into custom hooks.
Keep state local when possible. Use Context/Zustand/Redux only when necessary for state management.
If props or state traverse more than 3 levels, consider using context or a feature-scoped store instead of prop drilling.
Use performance optimization techniques:React.memo,useMemo,useCallback,Suspense(web), and virtualization for long lists; avoid unnecessary re-renders.
Web accessibility: use semantic HTML, labels, focus management, keyboard navigation, andaria-*attributes as needed.
React Native accessibility: use accessibility props (accessible,accessibilityLabel), proper roles and labels.
Identify and extract repetitive UI components proactively tocomponents/with clear props and minimal coupling.
Web styles: prefer co-located styles or design system tokens; avoid global style leakage.
React Native styles: preferStyleSheet.create, design tokens, and theme providers; avoid in...
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
Introduce interfaces at module boundaries to enable testing and substitutions
**/*.{ts,tsx}: Avoid usinganytype in TypeScript. If unavoidable, useunknownwith type guards and justify with a code comment
Preferinterfacefor defining public object shapes in TypeScript, usetypefor unions and utility types
Use TypeScript utility types such asPartial,Pick,Omit,Readonly, andRecordwhen appropriate
UseI{Name}naming convention for interfaces in TypeScript
UseT{Name}naming convention for type aliases and utility types in TypeScript
**/*.{ts,tsx}: Functions must be less than 50 lines with cyclomatic complexity less than 10
Do not useanytypes - ESLint enforces this at error level
**/*.{ts,tsx}: Prefer types over interfaces for most cases
Don't ever useany- type safety always
Avoid enums; use const objects instead
For complex types, create a separate file to declare them and import them
Avoid usinganytype; if unavoidable, useunknownwith type guards and justify with code comment
Preferinterfacefor public API shapes; usetypefor unions and utility types
Use TypeScript utility types (Partial, Pick, Omit, Readonly, Record)
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/documentation.mdc)
**/*.{js,ts,tsx,jsx}: Minimize comments in code; explain the 'why' when non-obvious, let code express the 'what' through clear naming
Document trade-offs briefly when deviating from ideal patterns
**/*.{js,ts,tsx,jsx}: Store secrets, ports, and hosts in environment variables (.env,.env.example) and never hardcode them
Avoid redundant or decorative AI comments; code should be self-explanatory and only commented when logic is non-obvious; prefer refactoring over lengthy commentsNever hardcode secrets, IPs, or ports; use
.envanddocs/for required configuration variables
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
packages/bot/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
packages/bot/**/*.{ts,tsx}: UseuseMainPlayer()fromdiscord-playerto access the player instance; do not instantiate player directly
Do not duplicate queue or player state outside Discord Player; use shared services from@lucky/sharedfor persistent data like track history and session information
UseerrorLoganddebugLogfrom@lucky/shared/utilsfor logging throughout the bot package
Use embed and reply utilities from@lucky/sharedfor consistent message formatting and error sanitization across the bot
Use services from@lucky/shared(DatabaseService, Redis client) for database and cache access; do not instantiate Prisma or Redis directly in the bot package
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{js,mjs,ts,mts}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Use Node.js version ≥22 with ESM (ECMAScript modules) only; no CommonJS
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
packages/bot/src/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/subagent-discord.mdc)
Use
@lucky/sharedfor database, Redis, logging, and embed utilities instead of implementing them locally
Files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/twitch/index.spec.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)
**/*.{test,spec}.{js,jsx,ts,tsx}: Test behavior, not implementation. Prefer Testing Library utilities for testing React/React Native components.
For React Native tests: mock native modules and test component interactions and accessibility labels.
Files:
packages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
**/*.{test,spec}.{ts,tsx,js,jsx}: Test behavior, not implementation details
Prefer unit tests for core logic; add integration tests at meaningful boundaries
Files:
packages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{test,spec}.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/testing-quality.mdc)
**/*.{test,spec}.{js,ts,jsx,tsx}: Use Jest + a React testing library for unit and component tests as applicable
Test behavior, not implementation details
Files:
packages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.{spec,test}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/quality.mdc)
**/*.{spec,test}.{ts,tsx,js,jsx}: Use Jest for unit and integration tests
Test behavior, not implementation details
Run unit, integration tests, and coverage report in CI quality checks
Files:
packages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/quality.mdc)
Unit tests must use naming convention
*.spec.ts
Files:
packages/bot/src/twitch/index.spec.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
{packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Add or adjust unit and integration tests when changing behavior; follow existing patterns in
packages/*/testsand roottests/directories
Files:
packages/bot/tests/handlers/player/playerFactory.test.ts
packages/bot/src/handlers/player/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
Track handling, errors, and lifecycle must be managed through dedicated handlers in
packages/bot/src/handlers/player/(trackHandlers, errorHandlers, lifecycleHandlers)
Files:
packages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
packages/bot/src/functions/**/commands/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Discord bot commands must be structured in
packages/bot/src/functions/<category>/commands/<name>.tswith handlers in<category>/handlers/
Files:
packages/bot/src/functions/general/commands/version.tspackages/bot/src/functions/general/commands/version.spec.ts
packages/bot/src/functions/*/commands/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
packages/bot/src/functions/*/commands/**/*.{ts,tsx}: Command model must includedata(slash builder),execute, andcategoryproperties exported frompackages/bot/src/models/Command.ts
Use@discordjs/buildersfor building thedata(SlashCommandBuilder) in command definitions
Commandexecutefunction must receive{ interaction, client }parameters fromCommandExecuteParamstype
UseinteractionReplyandcreateUserFriendlyErrorutilities from@lucky/shared/generalutils for command replies and error handling
Use existing validators frompackages/bot/src/utils/command/for voice channel, queue, and guild validations in commands
Files:
packages/bot/src/functions/general/commands/version.tspackages/bot/src/functions/general/commands/version.spec.ts
packages/bot/src/functions/{general,music,download}/commands/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/subagent-discord.mdc)
packages/bot/src/functions/{general,music,download}/commands/**/*.ts: Apply.cursor/rules/lucky-discord-bot.mdcrules for Discord bot commands and player implementation
Use.cursor/skills/discord-commands/SKILL.mdfor implementing slash commands
Files:
packages/bot/src/functions/general/commands/version.tspackages/bot/src/functions/general/commands/version.spec.ts
{CHANGELOG.md,README.md}
📄 CodeRabbit inference engine (.cursor/rules/agent-rules.mdc)
ALWAYS update CHANGELOG.md and README.md as changes are made.
Files:
CHANGELOG.md
CHANGELOG.md
📄 CodeRabbit inference engine (.cursor/rules/templates-examples.mdc)
CHANGELOG.md must be updated with all changes in pull requests
Always update CHANGELOG.md with all code changes
Update CHANGELOG.md with all changes, include breaking changes documentation, and reference issues and PRs
Files:
CHANGELOG.md
{CHANGELOG.md,docs/**}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Update
CHANGELOG.mdand relevantdocs/files when behavior or setup changes
Files:
CHANGELOG.md
🧠 Learnings (26)
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to packages/bot/** : The `bot` package depends on `shared` and contains Discord bot commands and player handlers using Discord.js and Discord Player
Applied to files:
packages/bot/package.jsonpackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/**/*.ts : Use `lucky/shared` for database, Redis, logging, and embed utilities instead of implementing them locally
Applied to files:
packages/bot/package.json
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Apply `.cursor/rules/lucky-discord-bot.mdc` rules for Discord bot commands and player implementation
Applied to files:
packages/bot/package.jsonpackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use embed and reply utilities from `lucky/shared` for consistent message formatting and error sanitization across the bot
Applied to files:
packages/bot/package.json
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use `errorLog` and `debugLog` from `lucky/shared/utils` for logging throughout the bot package
Applied to files:
packages/bot/package.json
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Do not duplicate queue or player state outside Discord Player; use shared services from `lucky/shared` for persistent data like track history and session information
Applied to files:
packages/bot/src/utils/music/sessionSnapshots.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details
Applied to files:
packages/bot/src/twitch/index.spec.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to {packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}} : Add or adjust unit and integration tests when changing behavior; follow existing patterns in `packages/*/tests` and root `tests/` directories
Applied to files:
packages/bot/src/twitch/index.spec.tspackages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use `useMainPlayer()` from `discord-player` to access the player instance; do not instantiate player directly
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/handlers/player/**/*.{ts,tsx} : Track handling, errors, and lifecycle must be managed through dedicated handlers in `packages/bot/src/handlers/player/` (trackHandlers, errorHandlers, lifecycleHandlers)
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/**/*.ts : Use existing voice/queue/guild validators before manipulating player or queue state
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
📚 Learning: 2026-03-09T20:21:38.098Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-backend.mdc:0-0
Timestamp: 2026-03-09T20:21:38.098Z
Learning: Applies to packages/backend/tests/**/*.ts : Follow existing patterns for unit and integration tests in `packages/backend/tests/`
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/functions/general/commands/version.spec.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Use `.cursor/skills/discord-commands/SKILL.md` for implementing slash commands
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Command model must include `data` (slash builder), `execute`, and `category` properties exported from `packages/bot/src/models/Command.ts`
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use `discordjs/builders` for building the `data` (SlashCommandBuilder) in command definitions
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-15T21:57:49.951Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-15T21:57:49.951Z
Learning: When adding or changing slash commands, use the `discord-commands` skill
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:23.892Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-09T20:20:23.892Z
Learning: Applies to packages/bot/src/functions/**/commands/*.ts : Discord bot commands must be structured in `packages/bot/src/functions/<category>/commands/<name>.ts` with handlers in `<category>/handlers/`
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use existing validators from `packages/bot/src/utils/command/` for voice channel, queue, and guild validations in commands
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use `interactionReply` and `createUserFriendlyError` utilities from `lucky/shared/general` utils for command replies and error handling
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Command `execute` function must receive `{ interaction, client }` parameters from `CommandExecuteParams` type
Applied to files:
packages/bot/src/functions/general/commands/version.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/commands/**/*.ts : Use `.cursor/skills/music-queue-player/SKILL.md` for play, queue, skip, volume commands and player lifecycle management
Applied to files:
packages/bot/src/handlers/player/playerFactory.tspackages/bot/src/utils/music/sessionSnapshots.spec.ts
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Use Jest for unit and integration tests
Applied to files:
packages/bot/src/functions/general/commands/version.spec.ts
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Run unit, integration tests, and coverage report in CI quality checks
Applied to files:
packages/bot/src/functions/general/commands/version.spec.ts
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.spec.ts : Unit tests must use naming convention `*.spec.ts`
Applied to files:
packages/bot/src/functions/general/commands/version.spec.ts
📚 Learning: 2026-03-09T20:20:38.694Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-backend-api.mdc:0-0
Timestamp: 2026-03-09T20:20:38.694Z
Learning: Applies to packages/backend/tests/**/*.{ts,tsx} : Organize tests in `packages/backend/tests/` with unit tests under `unit/` and integration tests under `integration/`, following existing patterns with fixtures and setup
Applied to files:
packages/bot/src/functions/general/commands/version.spec.ts
📚 Learning: 2026-03-15T21:57:49.951Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-15T21:57:49.951Z
Learning: When working on music queue/player features (play/queue/skip/volume, player lifecycle), use the `music-queue-player` skill
Applied to files:
packages/bot/src/utils/music/sessionSnapshots.spec.ts
🔇 Additional comments (3)
packages/bot/src/twitch/index.spec.ts (1)
153-168: Good fix for the flaky test.Replacing time-based assertions with a completion flag is the right approach. The
resolvedflag is set synchronously beforeresolve()is called, guaranteeing deterministic behavior regardless of CI runner timing variance. This tests the actual behavior (function awaits the promise) rather than implementation timing.Based on learnings: "Test behavior, not implementation details."
packages/bot/src/functions/general/commands/version.spec.ts (2)
24-42: Good behavioral coverage for positive and negative parsing paths.These cases are clear and user-visible in outcome (
foundvsunknown) without over-coupling to internals.
50-50: Line 50:__dirnameis safe in this Jest configuration.Jest uses
testEnvironment: 'node'withts-jestpreset, which runs tests in a Node.js CommonJS-compatible mode where__dirnameis available. The pattern is already used consistently across other test files in the same package without issues. No change needed.> Likely an incorrect or invalid review comment.
| async function readVersion(): Promise<string> { | ||
| const dirName = path.dirname(fileURLToPath(import.meta.url)) | ||
| const pkgPath = path.resolve(dirName, '../../../../package.json') | ||
| const rl = createInterface({ input: createReadStream(pkgPath) }) | ||
|
|
||
| try { | ||
| for await (const line of rl) { | ||
| const match = line.match(/"version"\s*:\s*"([^"]+)"/) | ||
| if (match) return match[1] | ||
| } | ||
| return 'unknown' | ||
| } finally { | ||
| rl.close() | ||
| } |
There was a problem hiding this comment.
Don't let /version fail hard on a file-read error.
If packages/bot/package.json is missing or unreadable, readVersion() rejects and this handler turns a diagnostic command into a generic slash-command failure. Please route the response through the shared command helpers and fall back to 'unknown' instead of bubbling the error to the user.
As per coding guidelines, "Use interactionReply and createUserFriendlyError utilities from @lucky/shared/general utils for command replies and error handling".
Also applies to: 30-35
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/bot/src/functions/general/commands/version.ts` around lines 9 - 22,
readVersion currently lets file-read errors bubble up; change it to catch any
exceptions from reading/parsing package.json, return 'unknown' on error, and
ensure callers (the /version command handler) use interactionReply and
createUserFriendlyError from `@lucky/shared/general` to send the response instead
of throwing. Specifically, wrap the body of readVersion (the
createReadStream/for-await loop and rl.close) in a try/catch where the catch
returns 'unknown' and still closes rl in finally, and update the command handler
that calls readVersion to call interactionReply(interaction, { content: version
}) on success and interactionReply(interaction, createUserFriendlyError(err)) on
failure so no file IO error becomes a hard rejection visible to the user.
There was a problem hiding this comment.
Fixed. Wrapped readVersion() in a try-catch inside execute — any file read error (e.g. ENOENT) now falls back to 'unknown' instead of bubbling to the user as a failed interaction.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
fd -e ts "version.ts" packages/bot/src/functions/general/commands/ --exec cat {}
Length of output: 1346
@LucasSantana-Dev, the try/catch in execute correctly prevents any ENOENT or other I/O error from surfacing as a failed interaction — that's the main concern resolved. ✅
One small follow-up: the execute handler still calls interaction.reply() directly rather than the shared interactionReply utility from lucky/shared/general, which is the project-standard for all command replies (per the coding guidelines stored in long-term memory). A minimal adjustment would look like:
execute: async ({ interaction }) => {
let version = 'unknown'
try {
version = await readVersion()
} catch {
// package.json unreadable — fall back to 'unknown'
}
await interactionReply(interaction, {
embeds: [createInfoEmbed('Bot Version', `v${version}`)],
ephemeral: true,
})
},This keeps error handling consistent with the rest of the bot's commands. Feel free to address it in a follow-up if preferred!
🧠 Learnings used
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use `discordjs/builders` for building the `data` (SlashCommandBuilder) in command definitions
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Use `.cursor/skills/discord-commands/SKILL.md` for implementing slash commands
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Command model must include `data` (slash builder), `execute`, and `category` properties exported from `packages/bot/src/models/Command.ts`
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use `interactionReply` and `createUserFriendlyError` utilities from `lucky/shared/general` utils for command replies and error handling
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Apply `.cursor/rules/lucky-discord-bot.mdc` rules for Discord bot commands and player implementation
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/commands/**/*.ts : Use `.cursor/skills/music-queue-player/SKILL.md` for play, queue, skip, volume commands and player lifecycle management
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use `errorLog` and `debugLog` from `lucky/shared/utils` for logging throughout the bot package
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use embed and reply utilities from `lucky/shared` for consistent message formatting and error sanitization across the bot
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/handlers/player/**/*.{ts,tsx} : Track handling, errors, and lifecycle must be managed through dedicated handlers in `packages/bot/src/handlers/player/` (trackHandlers, errorHandlers, lifecycleHandlers)
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Command `execute` function must receive `{ interaction, client }` parameters from `CommandExecuteParams` type
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-09T20:20:23.892Z
Learning: Applies to packages/backend/src/routes/**/*.ts : Backend route handlers must use `asyncHandler` wrapper and throw `AppError.xxx()` instead of manual try/catch blocks
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-15T21:57:49.951Z
Learning: When adding or changing slash commands, use the `discord-commands` skill
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to packages/bot/** : The `bot` package depends on `shared` and contains Discord bot commands and player handlers using Discord.js and Discord Player
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-09T20:20:23.892Z
Learning: Applies to packages/bot/src/functions/**/commands/*.ts : Discord bot commands must be structured in `packages/bot/src/functions/<category>/commands/<name>.ts` with handlers in `<category>/handlers/`
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/functions/*/commands/**/*.{ts,tsx} : Use existing validators from `packages/bot/src/utils/command/` for voice channel, queue, and guild validations in commands
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
packages/bot/src/handlers/player/playerFactory.ts (1)
97-112:⚠️ Potential issue | 🟠 MajorAlso require an author/uploader match before streaming.
The predicate still allows same-title, same-duration covers/remasters/unofficial uploads because
track.authoris only part of the search query, not the validation step.As per coding guidelines, "For external data sources (HTTP, database), always validate and sanitize input using type guards or schema validators".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/src/handlers/player/playerFactory.ts` around lines 97 - 112, The current match predicate in playerFactory.ts only checks title and duration so covers/remasters slip through; update the predicate used in results.find(...) to also require that the result's uploader/author (e.g., r.uploader, r.author, or r.user.name depending on PlayDL shape) matches the normalized track author (compare norm(r.uploader || r.author || r.user?.name) with norm(track.author)). Additionally, add a lightweight type guard / validation before using fields like r.name and r.durationInSec (and before calling playdl.stream) to ensure those properties exist and are the expected types (string/number) and sanitize them via norm() to avoid runtime errors from malformed external data. Ensure you reference and validate the same symbols used in the predicate: results.find, norm, titleNorm, trackSec, r.durationInSec, r.name, and the uploader/author field.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/bot/src/handlers/player/playerFactory.ts`:
- Around line 89-103: The current norm function strips non-ASCII characters
causing titles like "夜に駆ける" to become empty and match everything; update norm
(used to compute titleNorm and when checking norm(r.name) in the results.find
matcher) to first apply Unicode normalization (NFKD), then strip only characters
that are not letters, numbers or whitespace using a Unicode property escape
(e.g., keep \p{L}\p{N}\s with the u flag) so non-ASCII letters are preserved,
apply to both track.title and r.name, and after normalization throw/return an
error if the resulting titleNorm is empty to avoid false positives; keep the
duration comparison logic (parseDurationString, trackSec, r.durationInSec)
unchanged.
In `@README.md`:
- Around line 506-509: Update the "Latest Release" label in README.md to match
the deployed bot version 2.6.54 so the doc no longer contradicts the /version
check; locate the "Latest Release" section in README.md (the lines referencing
v2.6.38) and replace that version string with 2.6.54 to keep the README
consistent with the /version behavior.
---
Duplicate comments:
In `@packages/bot/src/handlers/player/playerFactory.ts`:
- Around line 97-112: The current match predicate in playerFactory.ts only
checks title and duration so covers/remasters slip through; update the predicate
used in results.find(...) to also require that the result's uploader/author
(e.g., r.uploader, r.author, or r.user.name depending on PlayDL shape) matches
the normalized track author (compare norm(r.uploader || r.author ||
r.user?.name) with norm(track.author)). Additionally, add a lightweight type
guard / validation before using fields like r.name and r.durationInSec (and
before calling playdl.stream) to ensure those properties exist and are the
expected types (string/number) and sanitize them via norm() to avoid runtime
errors from malformed external data. Ensure you reference and validate the same
symbols used in the predicate: results.find, norm, titleNorm, trackSec,
r.durationInSec, r.name, and the uploader/author field.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c13efe4e-bbcf-437c-a370-c7dfc98e7706
📒 Files selected for processing (4)
README.mdpackages/bot/src/functions/general/commands/version.spec.tspackages/bot/src/functions/general/commands/version.tspackages/bot/src/handlers/player/playerFactory.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/bot/src/functions/general/commands/version.spec.ts
- packages/bot/src/functions/general/commands/version.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (12)
{CHANGELOG.md,README.md}
📄 CodeRabbit inference engine (.cursor/rules/agent-rules.mdc)
ALWAYS update CHANGELOG.md and README.md as changes are made.
Files:
README.md
README.md
📄 CodeRabbit inference engine (.cursor/rules/templates-examples.mdc)
README.md must be updated if behavior changed
Update README.md if behavior changed
Files:
README.md
**/*.{js,jsx,ts,tsx,vue,html}
📄 CodeRabbit inference engine (.cursor/rules/accessibility-openness.mdc)
Provide accessible UI components using semantic HTML and ARIA attributes where necessary
Files:
packages/bot/src/handlers/player/playerFactory.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/dependency-injection.mdc)
**/*.{ts,tsx,js,jsx}: Prefer constructor injection for classes that require dependencies
Avoid global mutable singletons unless necessary
Use explicit interfaces for external dependencies to make testing easier
**/*.{ts,tsx,js,jsx}: Include required references in PRs/code for non-trivial logic: TypeScript (official docs), MDN (JavaScript reference), and official docs for any runtime/framework/libraries used (e.g., Node.js, React) as applicable.
Before assuming behavior of an API, include the doc link and a ≤25-word quote when the change relies on it.
**/*.{ts,tsx,js,jsx}: Prefer named exports for clear usage and easier refactors in TypeScript/JavaScript
Keep import order consistent: external first, then internal modules
Remove dead code and unused imports
**/*.{ts,tsx,js,jsx}: Use PascalCase naming convention for React/UI components
Use camelCase naming convention for variables and functions
Use UPPER_SNAKE_CASE naming convention for constants
Maintain consistent import grouping and ordering within the project, keeping third-party imports separate from local imports
For external data sources (HTTP, database), always validate and sanitize input using type guards or schema validators
**/*.{ts,tsx,js,jsx}: Use Prettier with no semicolons, single quotes, 4-space indent, 80 character width
Files must not exceed 250 lines and this is enforcedImplement TypeScript typecheck and linter in CI quality checks
**/*.{ts,tsx,js,jsx}: Use TypeScript for enhanced type safety
Implement error handling and error logging
Avoid commenting code unless extremely necessary - code should explain itself with descriptive names
Leave NO todos, placeholders or missing pieces in the code
Variables and functions must use camelCase
Constants must use UPPER_SNAKE_CASE
Use arrow functions for methods and computed properties
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements
Maintain consistent import grouping/order: external imports first, then...
Files:
packages/bot/src/handlers/player/playerFactory.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
**/*.{js,jsx,ts,tsx}: Never throw strings. ThrowError(or typed subclasses) with descriptive messages
Include causal error ascausewhen available for better debugging
Define clear, stable error codes (e.g.,ERR_AUTH_EXPIRED,ERR_NETWORK_TIMEOUT)
Provide optional metadata (e.g.,details,retryable,status,correlationId) in error objects
Use domain error classes per area (e.g.,AuthenticationError,ValidationError,NetworkError)
Log errors with structure (message, code, stack, cause, correlationId, user context where appropriate)
MarkretryablevsnonRetryableerrors where helpful for operations
Set timeouts and handle aborts/cancellations; avoid dangling requests in API/network code
Implement backoff for transient failures; avoid infinite retries
Map HTTP status → domain errors; 4xx vs 5xx behave differently (e.g., retry for 5xx/network)
**/*.{js,jsx,ts,tsx}: Use functional components with hooks in React/React Native. Avoid class components.
Keep components focused on a single responsibility; extract complex logic into custom hooks.
Keep state local when possible. Use Context/Zustand/Redux only when necessary for state management.
If props or state traverse more than 3 levels, consider using context or a feature-scoped store instead of prop drilling.
Use performance optimization techniques:React.memo,useMemo,useCallback,Suspense(web), and virtualization for long lists; avoid unnecessary re-renders.
Web accessibility: use semantic HTML, labels, focus management, keyboard navigation, andaria-*attributes as needed.
React Native accessibility: use accessibility props (accessible,accessibilityLabel), proper roles and labels.
Identify and extract repetitive UI components proactively tocomponents/with clear props and minimal coupling.
Web styles: prefer co-located styles or design system tokens; avoid global style leakage.
React Native styles: preferStyleSheet.create, design tokens, and theme providers; avoid in...
Files:
packages/bot/src/handlers/player/playerFactory.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
Introduce interfaces at module boundaries to enable testing and substitutions
**/*.{ts,tsx}: Avoid usinganytype in TypeScript. If unavoidable, useunknownwith type guards and justify with a code comment
Preferinterfacefor defining public object shapes in TypeScript, usetypefor unions and utility types
Use TypeScript utility types such asPartial,Pick,Omit,Readonly, andRecordwhen appropriate
UseI{Name}naming convention for interfaces in TypeScript
UseT{Name}naming convention for type aliases and utility types in TypeScript
**/*.{ts,tsx}: Functions must be less than 50 lines with cyclomatic complexity less than 10
Do not useanytypes - ESLint enforces this at error level
**/*.{ts,tsx}: Prefer types over interfaces for most cases
Don't ever useany- type safety always
Avoid enums; use const objects instead
For complex types, create a separate file to declare them and import them
Avoid usinganytype; if unavoidable, useunknownwith type guards and justify with code comment
Preferinterfacefor public API shapes; usetypefor unions and utility types
Use TypeScript utility types (Partial, Pick, Omit, Readonly, Record)
Files:
packages/bot/src/handlers/player/playerFactory.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/documentation.mdc)
**/*.{js,ts,tsx,jsx}: Minimize comments in code; explain the 'why' when non-obvious, let code express the 'what' through clear naming
Document trade-offs briefly when deviating from ideal patterns
**/*.{js,ts,tsx,jsx}: Store secrets, ports, and hosts in environment variables (.env,.env.example) and never hardcode them
Avoid redundant or decorative AI comments; code should be self-explanatory and only commented when logic is non-obvious; prefer refactoring over lengthy commentsNever hardcode secrets, IPs, or ports; use
.envanddocs/for required configuration variables
Files:
packages/bot/src/handlers/player/playerFactory.ts
packages/bot/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
packages/bot/**/*.{ts,tsx}: UseuseMainPlayer()fromdiscord-playerto access the player instance; do not instantiate player directly
Do not duplicate queue or player state outside Discord Player; use shared services from@lucky/sharedfor persistent data like track history and session information
UseerrorLoganddebugLogfrom@lucky/shared/utilsfor logging throughout the bot package
Use embed and reply utilities from@lucky/sharedfor consistent message formatting and error sanitization across the bot
Use services from@lucky/shared(DatabaseService, Redis client) for database and cache access; do not instantiate Prisma or Redis directly in the bot package
Files:
packages/bot/src/handlers/player/playerFactory.ts
packages/bot/src/handlers/player/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
Track handling, errors, and lifecycle must be managed through dedicated handlers in
packages/bot/src/handlers/player/(trackHandlers, errorHandlers, lifecycleHandlers)
Files:
packages/bot/src/handlers/player/playerFactory.ts
packages/bot/**
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
The
botpackage depends onsharedand contains Discord bot commands and player handlers using Discord.js and Discord Player
Files:
packages/bot/src/handlers/player/playerFactory.ts
**/*.{js,mjs,ts,mts}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Use Node.js version ≥22 with ESM (ECMAScript modules) only; no CommonJS
Files:
packages/bot/src/handlers/player/playerFactory.ts
packages/bot/src/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/subagent-discord.mdc)
Use
@lucky/sharedfor database, Redis, logging, and embed utilities instead of implementing them locally
Files:
packages/bot/src/handlers/player/playerFactory.ts
🧠 Learnings (10)
📓 Common learnings
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Apply `.cursor/rules/lucky-discord-bot.mdc` rules for Discord bot commands and player implementation
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/commands/**/*.ts : Use `.cursor/skills/music-queue-player/SKILL.md` for play, queue, skip, volume commands and player lifecycle management
Applied to files:
README.mdpackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:32.245Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/documentation.mdc:0-0
Timestamp: 2026-03-09T20:20:32.245Z
Learning: Applies to README.md : Update README.md if behavior changed
Applied to files:
README.md
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Use `.cursor/skills/discord-commands/SKILL.md` for implementing slash commands
Applied to files:
README.md
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use `useMainPlayer()` from `discord-player` to access the player instance; do not instantiate player directly
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/handlers/player/**/*.{ts,tsx} : Track handling, errors, and lifecycle must be managed through dedicated handlers in `packages/bot/src/handlers/player/` (trackHandlers, errorHandlers, lifecycleHandlers)
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Do not duplicate queue or player state outside Discord Player; use shared services from `lucky/shared` for persistent data like track history and session information
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/**/*.ts : Use existing voice/queue/guild validators before manipulating player or queue state
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to packages/bot/** : The `bot` package depends on `shared` and contains Discord bot commands and player handlers using Discord.js and Discord Player
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Apply `.cursor/rules/lucky-discord-bot.mdc` rules for Discord bot commands and player implementation
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
🔇 Additional comments (3)
README.md (1)
500-501: Nice operator-facing explanation.This sets the right expectation that YouTube metadata/search stay on
YoutubeiExtractorwhile audio is bridged from SoundCloud.packages/bot/src/handlers/player/playerFactory.ts (2)
44-62: Nice guard for silent extractor activation failures.Checking the
register()return value avoids logging a false success when extractor activation returnsnull.
115-121: Nice small helper.Pulling duration parsing out of the predicate keeps the matching logic readable and easy to unit-test.
| const norm = (s: string) => | ||
| s | ||
| .toLowerCase() | ||
| .replace(/[^a-z0-9\s]/g, '') | ||
| .trim() | ||
| const titleNorm = norm(track.title) | ||
| const trackSec = parseDurationString(track.duration) | ||
|
|
||
| const match = results.find((r) => { | ||
| const titleMatch = | ||
| norm(r.name).includes(titleNorm) || titleNorm.includes(norm(r.name)) | ||
| if (!titleMatch) return false | ||
| if (trackSec === null || !r.durationInSec) return true | ||
| return Math.abs(r.durationInSec - trackSec) <= 15 | ||
| }) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
node <<'NODE'
const norm = (s) => s.toLowerCase().replace(/[^a-z0-9\s]/g, '').trim()
for (const title of ['夜に駆ける', 'Señorita']) {
const titleNorm = norm(title)
console.log({
title,
titleNorm,
anyMatch: 'totally different result'.includes(titleNorm),
})
}
NODERepository: LucasSantana-Dev/Lucky
Length of output: 176
🏁 Script executed:
cat -n packages/bot/src/handlers/player/playerFactory.ts | head -120 | tail -40Repository: LucasSantana-Dev/Lucky
Length of output: 1603
🏁 Script executed:
node <<'NODE'
const norm = (s) =>
s
.normalize('NFKD')
.toLowerCase()
.replace(/\p{M}/gu, '')
.replace(/[^\p{L}\p{N}\s]/gu, '')
.replace(/\s+/g, ' ')
.trim()
for (const title of ['夜に駆ける', 'Señorita', 'Café au Lait', 'Normal Title']) {
const titleNorm = norm(title)
console.log({
title,
titleNorm,
isEmpty: titleNorm === '',
})
}
NODERepository: LucasSantana-Dev/Lucky
Length of output: 319
Non-ASCII titles produce empty normalized strings, causing false SoundCloud matches.
norm() removes all non-ASCII characters. Titles like 夜に駆ける become '', so both norm(r.name).includes(titleNorm) and titleNorm.includes(norm(r.name)) return true for any result. The first duration-compatible track is selected regardless of title relevance.
The fix uses Unicode normalization (NFKD), Unicode property escapes to preserve non-ASCII letters, and throws an error if the title has zero valid characters:
Proposed fix
const norm = (s: string) =>
s
+ .normalize('NFKD')
.toLowerCase()
- .replace(/[^a-z0-9\s]/g, '')
+ .replace(/\p{M}/gu, '')
+ .replace(/[^\p{L}\p{N}\s]/gu, '')
+ .replace(/\s+/g, ' ')
.trim()
const titleNorm = norm(track.title)
+if (!titleNorm) {
+ throw new Error(`SoundCloud: unable to normalize title for "${query}"`)
+}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/bot/src/handlers/player/playerFactory.ts` around lines 89 - 103, The
current norm function strips non-ASCII characters causing titles like "夜に駆ける" to
become empty and match everything; update norm (used to compute titleNorm and
when checking norm(r.name) in the results.find matcher) to first apply Unicode
normalization (NFKD), then strip only characters that are not letters, numbers
or whitespace using a Unicode property escape (e.g., keep \p{L}\p{N}\s with the
u flag) so non-ASCII letters are preserved, apply to both track.title and
r.name, and after normalization throw/return an error if the resulting titleNorm
is empty to avoid false positives; keep the duration comparison logic
(parseDurationString, trackSec, r.durationInSec) unchanged.
- add createStream override: searches soundcloud by title+author and streams from there, bypassing youtube cdn ip blocks causing 1-second track cycling - add null-check on extractors.register() return value with warnlog - fix applysnapshot to use track.setmetadata() (metadata is getter-only in discord-player, direct assignment threw typeerror) - fix flaky twitch timing test: use behavioral assertion instead of delta - bump bot to v2.6.54
- version.ts: catch file read errors and fall back to 'unknown' - version.spec.ts: use end-anchored semver regex - playerFactory: validate soundcloud results by title+duration before streaming (±15s tolerance, normalized title substring match) - readme: add /version command docs and youtube audio routing notes
- add inline unit tests for parsedurationstring: m:ss, h:mm:ss, undefined, empty, and invalid input cases - add streamviasoundcloud validation logic tests: title match, duration tolerance, no-duration fallback, first valid candidate selection - add version execute error handling tests: readversion throws falls back to unknown, success path uses returned version
Titles consisting entirely of non-ASCII characters (e.g. CJK) were
stripped to an empty string by the norm() regex, causing every
SoundCloud result to match via String.includes('').
Falls back to the lowercased raw title when the ASCII-only normalization
result is empty. Also updates README Latest Release to v2.6.54 and adds
a regression test for the edge case.
971a275 to
95bd19d
Compare
|
All actionable comments addressed: non-ASCII normalization guard added, README version updated, version.ts try-catch fallback added, streamViaSoundCloud improved with 5 candidates and title/duration validation.
|
This branch was successfully deployed
1 participant
Summary
googlevideo.com) blocks hosting provider IPs even with a validpo_token. The CDN was returning 403 responses thatdiscord-player-youtubeisilently treated as audio, causing tracks to cycle every ~1 second. Fixed by injecting acreateStreamoverride that searches SoundCloud by title+author and streams from there — bypassing CDN blocking entirely while keeping YouTube metadata/search.applySnapshotMetadataTypeError fixed:Track.metadatais a getter-only property indiscord-player. Direct assignment was throwingTypeError: Cannot set property metadata. Replaced withtrack.setMetadata().player.extractors.register()returnsnull(without throwing) whenactivate()fails. Added null-check +warnLog.twitch/index.spec.tstiming assertion (elapsed >= 10ms) was returning 9ms on CI, blocking all deploys viaworkflow_run. Replaced with behavioral assertion using aresolvedflag.Test plan
deploy.ymlworkflow after CI succeeds/play <youtube-url>produces audible audio in voice channel/versionreturns2.6.54Summary by CodeRabbit
New Features
/versionslash command (ephemeral reply showing current bot version)Bug Fixes
Documentation
/versionand streaming behavior notes