Repository navigation
fix(bot): restore yt-dlp pipe stream for youtube audio playback - #418
Conversation
The --get-url approach returns a googlevideo URL that discord-player cannot reliably consume via FFmpeg in its audio pipeline. Restore the original working approach: spawn yt-dlp with -o - and return proc.stdout directly as a Readable stream. This was the last known working approach before the stream reliability regressions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughRefactored yt-dlp integration from URL resolution via Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/bot/src/handlers/player/playerFactory.ts (1)
2-2: Usenode:streamprefix for built-in modules.Per Node.js ESM best practices and the SonarCloud hint, prefer the
node:prefixed import for built-in modules.🔧 Suggested fix
-import type { Readable } from 'stream' +import type { Readable } from 'node:stream'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bot/src/handlers/player/playerFactory.ts` at line 2, Update the built-in module import to use the Node.js "node:" prefix: replace the import of the Readable type currently from 'stream' with the equivalent from 'node:stream' (the import line referencing Readable in playerFactory.ts). This aligns with ESM best practices and SonarCloud hints—ensure the import statement uses "node:stream" and keep the type-only import form.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/bot/src/handlers/player/playerFactory.ts`:
- Around line 43-60: The getYtDlpStream function currently returns proc.stdout
but doesn't propagate process errors to the returned Readable; attach handlers
to the child process (proc.on('error') and proc.on('close'/'exit')) to create an
Error when the process fails (non-zero exit code or runtime error) and call
stream.destroy(err) so consumers receive an error event; change the return to
use a local const stream = proc.stdout as Readable and in both the 'error' and
the 'close'/'exit' handlers call stream.destroy(new Error(...)) with a clear
message including the exit code or original error to surface failures to
discord-player and other consumers.
---
Nitpick comments:
In `@packages/bot/src/handlers/player/playerFactory.ts`:
- Line 2: Update the built-in module import to use the Node.js "node:" prefix:
replace the import of the Readable type currently from 'stream' with the
equivalent from 'node:stream' (the import line referencing Readable in
playerFactory.ts). This aligns with ESM best practices and SonarCloud
hints—ensure the import statement uses "node:stream" and keep the type-only
import form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a9c1ccc6-57b3-4d25-a3fe-89e2f4904d8c
📒 Files selected for processing (3)
packages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.tspackages/bot/tests/handlers/player/playerFactory.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: SonarCloud Scan
- GitHub Check: Quality Gates
🧰 Additional context used
📓 Path-based instructions (16)
**/*.{js,jsx,ts,tsx,vue,html}
📄 CodeRabbit inference engine (.cursor/rules/accessibility-openness.mdc)
Provide accessible UI components using semantic HTML and ARIA attributes where necessary
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/dependency-injection.mdc)
**/*.{ts,tsx,js,jsx}: Prefer constructor injection for classes that require dependencies
Avoid global mutable singletons unless necessary
Use explicit interfaces for external dependencies to make testing easier
**/*.{ts,tsx,js,jsx}: Include required references in PRs/code for non-trivial logic: TypeScript (official docs), MDN (JavaScript reference), and official docs for any runtime/framework/libraries used (e.g., Node.js, React) as applicable.
Before assuming behavior of an API, include the doc link and a ≤25-word quote when the change relies on it.
**/*.{ts,tsx,js,jsx}: Prefer named exports for clear usage and easier refactors in TypeScript/JavaScript
Keep import order consistent: external first, then internal modules
Remove dead code and unused imports
**/*.{ts,tsx,js,jsx}: Use PascalCase naming convention for React/UI components
Use camelCase naming convention for variables and functions
Use UPPER_SNAKE_CASE naming convention for constants
Maintain consistent import grouping and ordering within the project, keeping third-party imports separate from local imports
For external data sources (HTTP, database), always validate and sanitize input using type guards or schema validators
**/*.{ts,tsx,js,jsx}: Use Prettier with no semicolons, single quotes, 4-space indent, 80 character width
Files must not exceed 250 lines and this is enforcedImplement TypeScript typecheck and linter in CI quality checks
**/*.{ts,tsx,js,jsx}: Use TypeScript for enhanced type safety
Implement error handling and error logging
Avoid commenting code unless extremely necessary - code should explain itself with descriptive names
Leave NO todos, placeholders or missing pieces in the code
Variables and functions must use camelCase
Constants must use UPPER_SNAKE_CASE
Use arrow functions for methods and computed properties
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements
Maintain consistent import grouping/order: external imports first, then...
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
**/*.{js,jsx,ts,tsx}: Never throw strings. ThrowError(or typed subclasses) with descriptive messages
Include causal error ascausewhen available for better debugging
Define clear, stable error codes (e.g.,ERR_AUTH_EXPIRED,ERR_NETWORK_TIMEOUT)
Provide optional metadata (e.g.,details,retryable,status,correlationId) in error objects
Use domain error classes per area (e.g.,AuthenticationError,ValidationError,NetworkError)
Log errors with structure (message, code, stack, cause, correlationId, user context where appropriate)
MarkretryablevsnonRetryableerrors where helpful for operations
Set timeouts and handle aborts/cancellations; avoid dangling requests in API/network code
Implement backoff for transient failures; avoid infinite retries
Map HTTP status → domain errors; 4xx vs 5xx behave differently (e.g., retry for 5xx/network)
**/*.{js,jsx,ts,tsx}: Use functional components with hooks in React/React Native. Avoid class components.
Keep components focused on a single responsibility; extract complex logic into custom hooks.
Keep state local when possible. Use Context/Zustand/Redux only when necessary for state management.
If props or state traverse more than 3 levels, consider using context or a feature-scoped store instead of prop drilling.
Use performance optimization techniques:React.memo,useMemo,useCallback,Suspense(web), and virtualization for long lists; avoid unnecessary re-renders.
Web accessibility: use semantic HTML, labels, focus management, keyboard navigation, andaria-*attributes as needed.
React Native accessibility: use accessibility props (accessible,accessibilityLabel), proper roles and labels.
Identify and extract repetitive UI components proactively tocomponents/with clear props and minimal coupling.
Web styles: prefer co-located styles or design system tokens; avoid global style leakage.
React Native styles: preferStyleSheet.create, design tokens, and theme providers; avoid in...
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)
**/*.{test,spec}.{js,jsx,ts,tsx}: Test behavior, not implementation. Prefer Testing Library utilities for testing React/React Native components.
For React Native tests: mock native modules and test component interactions and accessibility labels.
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
Introduce interfaces at module boundaries to enable testing and substitutions
**/*.{ts,tsx}: Avoid usinganytype in TypeScript. If unavoidable, useunknownwith type guards and justify with a code comment
Preferinterfacefor defining public object shapes in TypeScript, usetypefor unions and utility types
Use TypeScript utility types such asPartial,Pick,Omit,Readonly, andRecordwhen appropriate
UseI{Name}naming convention for interfaces in TypeScript
UseT{Name}naming convention for type aliases and utility types in TypeScript
**/*.{ts,tsx}: Functions must be less than 50 lines with cyclomatic complexity less than 10
Do not useanytypes - ESLint enforces this at error level
**/*.{ts,tsx}: Prefer types over interfaces for most cases
Don't ever useany- type safety always
Avoid enums; use const objects instead
For complex types, create a separate file to declare them and import them
Avoid usinganytype; if unavoidable, useunknownwith type guards and justify with code comment
Preferinterfacefor public API shapes; usetypefor unions and utility types
Use TypeScript utility types (Partial, Pick, Omit, Readonly, Record)
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
**/*.{test,spec}.{ts,tsx,js,jsx}: Test behavior, not implementation details
Prefer unit tests for core logic; add integration tests at meaningful boundaries
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.ts
**/*.{test,spec}.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/testing-quality.mdc)
**/*.{test,spec}.{js,ts,jsx,tsx}: Use Jest + a React testing library for unit and component tests as applicable
Test behavior, not implementation details
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/documentation.mdc)
**/*.{js,ts,tsx,jsx}: Minimize comments in code; explain the 'why' when non-obvious, let code express the 'what' through clear naming
Document trade-offs briefly when deviating from ideal patterns
**/*.{js,ts,tsx,jsx}: Store secrets, ports, and hosts in environment variables (.env,.env.example) and never hardcode them
Avoid redundant or decorative AI comments; code should be self-explanatory and only commented when logic is non-obvious; prefer refactoring over lengthy commentsNever hardcode secrets, IPs, or ports; use
.envanddocs/for required configuration variables
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
packages/bot/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
packages/bot/**/*.{ts,tsx}: UseuseMainPlayer()fromdiscord-playerto access the player instance; do not instantiate player directly
Do not duplicate queue or player state outside Discord Player; use shared services from@lucky/sharedfor persistent data like track history and session information
UseerrorLoganddebugLogfrom@lucky/shared/utilsfor logging throughout the bot package
Use embed and reply utilities from@lucky/sharedfor consistent message formatting and error sanitization across the bot
Use services from@lucky/shared(DatabaseService, Redis client) for database and cache access; do not instantiate Prisma or Redis directly in the bot package
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
packages/bot/**
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
The
botpackage depends onsharedand contains Discord bot commands and player handlers using Discord.js and Discord Player
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.{js,mjs,ts,mts}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Use Node.js version ≥22 with ESM (ECMAScript modules) only; no CommonJS
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
{packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}}
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
Add or adjust unit and integration tests when changing behavior; follow existing patterns in
packages/*/testsand roottests/directories
Files:
packages/bot/tests/handlers/player/playerFactory.test.ts
**/*.{spec,test}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/quality.mdc)
**/*.{spec,test}.{ts,tsx,js,jsx}: Use Jest for unit and integration tests
Test behavior, not implementation details
Run unit, integration tests, and coverage report in CI quality checks
Files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.ts
packages/bot/src/handlers/player/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-discord-bot.mdc)
Track handling, errors, and lifecycle must be managed through dedicated handlers in
packages/bot/src/handlers/player/(trackHandlers, errorHandlers, lifecycleHandlers)
Files:
packages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/quality.mdc)
Unit tests must use naming convention
*.spec.ts
Files:
packages/bot/src/handlers/player/playerFactory.spec.ts
packages/bot/src/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/subagent-discord.mdc)
Use
@lucky/sharedfor database, Redis, logging, and embed utilities instead of implementing them locally
Files:
packages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
🧠 Learnings (11)
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Use `useMainPlayer()` from `discord-player` to access the player instance; do not instantiate player directly
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/src/handlers/player/**/*.{ts,tsx} : Track handling, errors, and lifecycle must be managed through dedicated handlers in `packages/bot/src/handlers/player/` (trackHandlers, errorHandlers, lifecycleHandlers)
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.tspackages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:38.098Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-backend.mdc:0-0
Timestamp: 2026-03-09T20:21:38.098Z
Learning: Applies to packages/backend/tests/**/*.ts : Follow existing patterns for unit and integration tests in `packages/backend/tests/`
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.ts
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to {packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}} : Add or adjust unit and integration tests when changing behavior; follow existing patterns in `packages/*/tests` and root `tests/` directories
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.tspackages/bot/src/handlers/player/playerFactory.spec.ts
📚 Learning: 2026-03-15T21:57:49.951Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-15T21:57:49.951Z
Learning: When working on unit tests, Jest ESM mocks, or fixing disabled tests, use the `testing-lucky` skill
Applied to files:
packages/bot/tests/handlers/player/playerFactory.test.ts
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details
Applied to files:
packages/bot/src/handlers/player/playerFactory.spec.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/**/*.ts : Use existing voice/queue/guild validators before manipulating player or queue state
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:20:47.877Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-discord-bot.mdc:0-0
Timestamp: 2026-03-09T20:20:47.877Z
Learning: Applies to packages/bot/**/*.{ts,tsx} : Do not duplicate queue or player state outside Discord Player; use shared services from `lucky/shared` for persistent data like track history and session information
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/music/commands/**/*.ts : Use `.cursor/skills/music-queue-player/SKILL.md` for play, queue, skip, volume commands and player lifecycle management
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to packages/bot/** : The `bot` package depends on `shared` and contains Discord bot commands and player handlers using Discord.js and Discord Player
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
📚 Learning: 2026-03-09T20:21:52.065Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-discord.mdc:0-0
Timestamp: 2026-03-09T20:21:52.065Z
Learning: Applies to packages/bot/src/functions/{general,music,download}/commands/**/*.ts : Apply `.cursor/rules/lucky-discord-bot.mdc` rules for Discord bot commands and player implementation
Applied to files:
packages/bot/src/handlers/player/playerFactory.ts
🪛 GitHub Check: SonarCloud Code Analysis
packages/bot/src/handlers/player/playerFactory.ts
[warning] 2-2: Prefer node:stream over stream.
🔇 Additional comments (6)
packages/bot/src/handlers/player/playerFactory.ts (1)
104-114: LGTM!The
createStreamsignature correctly reflects the dual return type, and the conditional routing between piped streams (YouTube) and passthrough URLs (other sources) is clear and well-structured.packages/bot/tests/handlers/player/playerFactory.test.ts (3)
88-123: LGTM!The test correctly validates that
yt-dlpis spawned with the expected pipe arguments (-f bestaudio/best,-o -) and stdio configuration for YouTube URLs.
125-156: LGTM!Good test coverage verifying that
proc.stdoutis returned as the stream for YouTube URLs.
158-186: LGTM!The assertion that spawn call count doesn't increase for non-YouTube URLs correctly validates the passthrough behavior.
packages/bot/src/handlers/player/playerFactory.spec.ts (2)
60-83: LGTM!The argument and stdio configuration assertions correctly reflect the new piping approach.
85-120: LGTM!The createStream routing logic tests properly validate YouTube URL detection and passthrough behavior for non-YouTube sources.
| const getYtDlpStream = (url: string): Readable => { | ||
| debugLog({ message: `yt-dlp piping audio stream: ${url}` }) | ||
| const proc = spawn( | ||
| 'yt-dlp', | ||
| ['-f', 'bestaudio/best', '-o', '-', '--no-warnings', '--quiet', url], | ||
| { stdio: ['ignore', 'pipe', 'pipe'] }, | ||
| ) | ||
|
|
||
| proc.stderr?.on('data', (data: Buffer) => { | ||
| warnLog({ message: `yt-dlp stderr: ${data.toString().trim()}` }) | ||
| }) | ||
|
|
||
| proc.on('error', (err) => { | ||
| errorLog({ message: 'yt-dlp process error:', error: err }) | ||
| }) | ||
|
|
||
| return proc.stdout as Readable | ||
| } |
There was a problem hiding this comment.
Process errors don't propagate to the stream consumer.
If yt-dlp exits with a non-zero code or encounters a runtime error, the returned stream silently ends without signaling an error. The discord-player pipeline will receive incomplete/truncated data with no indication of failure, causing silent playback issues.
Consider destroying the stream with the error so consumers can handle it:
🛠️ Proposed fix to propagate errors
const getYtDlpStream = (url: string): Readable => {
debugLog({ message: `yt-dlp piping audio stream: ${url}` })
const proc = spawn(
'yt-dlp',
['-f', 'bestaudio/best', '-o', '-', '--no-warnings', '--quiet', url],
{ stdio: ['ignore', 'pipe', 'pipe'] },
)
+
+ const stdout = proc.stdout as Readable
proc.stderr?.on('data', (data: Buffer) => {
warnLog({ message: `yt-dlp stderr: ${data.toString().trim()}` })
})
proc.on('error', (err) => {
errorLog({ message: 'yt-dlp process error:', error: err })
+ stdout.destroy(err)
+ })
+
+ proc.on('close', (code) => {
+ if (code !== 0 && code !== null) {
+ const err = new Error(`yt-dlp exited with code ${code}`)
+ errorLog({ message: 'yt-dlp non-zero exit:', error: err })
+ stdout.destroy(err)
+ }
})
- return proc.stdout as Readable
+ return stdout
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/bot/src/handlers/player/playerFactory.ts` around lines 43 - 60, The
getYtDlpStream function currently returns proc.stdout but doesn't propagate
process errors to the returned Readable; attach handlers to the child process
(proc.on('error') and proc.on('close'/'exit')) to create an Error when the
process fails (non-zero exit code or runtime error) and call stream.destroy(err)
so consumers receive an error event; change the return to use a local const
stream = proc.stdout as Readable and in both the 'error' and the 'close'/'exit'
handlers call stream.destroy(new Error(...)) with a clear message including the
exit code or original error to surface failures to discord-player and other
consumers.
|
The --get-url approach returns a googlevideo URL that discord-player cannot reliably consume via FFmpeg in its audio pipeline. Restore the original working approach: spawn yt-dlp with -o - and return proc.stdout directly as a Readable stream. This was the last known working approach before the stream reliability regressions.
This branch was successfully deployed
1 participant
Summary
getYtDlpStream()which spawnsyt-dlp -f bestaudio/best -o -and returnsproc.stdoutas aReadabledirectly to discord-player--get-url/execFileapproach that returned a googlevideo URL string — this was already identified as broken in a prior commit ("fix: pipe yt-dlp audio stream instead of resolving url") and was accidentally re-introducedcheckYtDlpAvailability()to fall back to native YoutubeiExtractor IOS client when yt-dlp is not installedRoot Cause
discord-player's audio pipeline cannot reliably consume a raw googlevideo URL string passed from
createStream. The pipe stream approach (returningproc.stdout) was the original working solution that was previously reverted without understanding why it worked.Test plan
Summary by CodeRabbit
Refactor
Tests
Bug Fixes