fix: use fake timers in ReminderService.spec to prevent race condition

[LucasSantana-Dev]

Summary

Fixes the flaky getDueReminders test that failed intermittently due to a race condition between two Date.now() calls ~1ms apart.

Root Cause

The test captured the current time with const now = new Date() at line 150, then called the service method which internally called Date.now() during execution. If the system clock advanced 1ms between these calls, the assertion .toBeLessThanOrEqual(now.getTime()) would fail intermittently.

Solution

Use jest.useFakeTimers() to freeze time during the test, ensuring both timestamp calls see identical values. This is the standard pattern for Date-based tests and prevents any clock drift during execution.

Verification

Ran the test suite 5 times in a row - all passed:

• Run 1: 8 passed
• Run 2: 8 passed
• Run 3: 8 passed
• Run 4: 8 passed
• Run 5: 8 passed

Closes #1713

---

Summary by cubic

Stabilizes the getDueReminders test in ReminderService by freezing time with jest.useFakeTimers() and guaranteeing cleanup via an afterEach jest.useRealTimers() inside that suite. Eliminates the 1 ms Date.now() race and prevents fake-timer leaks; closes #1713.

^{Written for commit 97a8646. Summary will update on new commits.}

Summary by CodeRabbit

• Tests
  • Improved reminder test reliability by consistently managing mocked and real timers.
  • Prevented timer state from carrying over between reminder test cases.

[coderabbitai]

📝 Walkthrough

Walkthrough

The reminder service test imports afterEach, enables fake timers for getDueReminders, and restores real timers after each test.

Changes

Reminder test timing

Layer / File(s)	Summary
Isolate due-reminder timers packages/shared/src/services/ReminderService.spec.ts	The test enables Jest fake timers before capturing the current time, while an afterEach hook restores real timers.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR satisfies #1713 by freezing time in the test and restoring real timers afterward.
Out of Scope Changes check	✅ Passed	The change is limited to the targeted test flake fix and adds no unrelated scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main fix: using fake timers in ReminderService.spec to avoid the flaky race condition.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1713-reminderservice-clock-race

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Failed to generate code suggestions for PR

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/shared/src/services/ReminderService.spec.ts">

<violation number="1" location="packages/shared/src/services/ReminderService.spec.ts:177">
P2: The fake-timer cleanup via `jest.useRealTimers()` will be skipped if any preceding assertion fails, leaking fake timers to subsequent tests. Consider wrapping the test body in a `try/finally` block, or better, use a scoped `afterEach` inside the `describe('getDueReminders')` block to guarantee cleanup regardless of assertion failures.

This is a low-risk concern today (the downstream tests use fixed-date strings), but it's a fragile pattern that can cause hard-to-debug flaky failures when the test suite evolves.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

<sub>Auto-approved: Test-only change: uses fake timers to fix a flaky race condition in ReminderService tests. No production code or logic impacted.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud