Repository navigation
chore: release 2.34.0 - #1754
Merged
Merged
Conversation
📝 WalkthroughWalkthroughRelease metadata was updated from version 2.33.1 to 2.33.2, and ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
the
dependencies
|
Failed to generate code suggestions for PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Auto-approved: Release PR updating version numbers and changelog. No source code changes.
Re-trigger cubic
|
Size Change: +1.07 kB (+0.22%) Total Size: 494 kB 📦 View Changed
ℹ️ View Unchanged
|
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
from
July 9, 2026 19:10
604f588 to
0187195
Compare
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
8 times, most recently
from
July 10, 2026 05:05
e7ec196 to
d843303
Compare
1 of 2 tasks
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
from
July 10, 2026 13:11
d843303 to
345fedb
Compare
LucasSantana-Dev
added a commit
that referenced
this pull request
Jul 10, 2026
## Summary - \`bundle-size.yml\`'s pnpm shim (added in #1722) causes \`preactjs/compressed-size-action\` to run a pnpm *recursive* build once pnpm is on PATH, since this repo declares an npm \`workspaces\` field. pnpm needs a \`pnpm-workspace.yaml\` for that, which doesn't exist here — fails with "packages field missing or empty". - Only surfaced now because #1754 (release PR) is the first PR since #1722 merged to touch \`package.json\` (version bump), hitting the workflow's path filter for the first time. - Fix: drop the pnpm setup step — npm's native workspaces support runs the \`build\` script fine without it. ## Test plan - [x] CI green on this PR (bundle-size workflow re-runs with the fix) - [ ] #1754 picks this up via update-branch and its compressed-size check passes <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed the `pnpm` setup from `.github/workflows/bundle-size.yml` so `preactjs/compressed-size-action` no longer switches to a `pnpm` recursive build in this `npm`-managed repo. The action now runs the `build` script via `npm` workspaces, resolving the "packages field missing or empty" error from the absent `pnpm-workspace.yaml`. <sup>Written for commit 7e50496. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/LucasSantana-Dev/Lucky/pull/1759?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
from
July 10, 2026 13:21
345fedb to
ab4b899
Compare
This was referenced Jul 10, 2026
LucasSantana-Dev
added a commit
that referenced
this pull request
Jul 10, 2026
## Summary - Root cause of release PR #1754's persistent \`compressed-size\` failure ("packages field missing or empty"): \`pnpm-workspace.yaml\` only declared \`allowBuilds\`, never a \`packages:\` list. pnpm 9 requires \`packages:\` even for a non-recursive \`pnpm run <script>\` at the workspace root. - Reproduced locally with \`npx pnpm@9 run build\` — failed identically until \`packages: ['packages/*']\` was added. - #1759 (merged) removed the workflow's pnpm setup step as a workaround, on the theory pnpm itself was the problem — but \`compressed-size-action\` picks pnpm regardless once it sees the root \`pnpm-lock.yaml\` (used for the documented alt \`pnpm install\` dev workflow in CONTRIBUTING.md), so removing the setup step just changed the failure to "Unable to locate executable file: pnpm". Restoring that step now that the actual cause is fixed. ## Test plan - [x] Reproduced the original failure and the fix locally with pnpm 9 (\`npx pnpm@9 run build\`) - [ ] CI green on this PR - [ ] #1754 picks this up via update-branch and its compressed-size check passes <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the `compressed-size` CI job by adding the missing `packages` field in `pnpm-workspace.yaml` and restoring the `pnpm` setup in the bundle-size workflow. Also adds supply-chain guardrails to the workspace config without affecting CI. - **Bug Fixes** - Added `packages: ['packages/*']` to `pnpm-workspace.yaml` (required by `pnpm@9` even for root `pnpm run`). - Restored `pnpm` setup so `preactjs/compressed-size-action` can run (it auto-picks `pnpm` due to the root `pnpm-lock.yaml`). - **Refactors** - Hardened `pnpm-workspace.yaml` with `blockExoticSubdeps`, `minimumReleaseAge`, and `trustPolicy: no-downgrade`; ignored by CI’s `pnpm@9`, effective on newer local `pnpm`. <sup>Written for commit 88f8692. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/LucasSantana-Dev/Lucky/pull/1760?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Improved automated bundle-size checks by standardizing their package manager setup. * Expanded workspace configuration to improve dependency consistency and package management safeguards. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
4 times, most recently
from
July 10, 2026 17:11
ab9569b to
0bfab3a
Compare
LucasSantana-Dev
force-pushed
the
release-please--branches--main
branch
from
July 10, 2026 17:20
0bfab3a to
38a1435
Compare
LucasSantana-Dev
enabled auto-merge (squash)
July 10, 2026 17:23
|
LucasSantana-Dev
added
autorelease: tagged
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img](https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a){kind=link}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
2.34.0
2.34.0 (2026-07-10)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.