Skip to content

chore(lint): stabilize frontend ESLint v10 and add backend guardrails #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasSantana-Dev merged 3 commits into from
Mar 10, 2026
Merged

chore(lint): stabilize frontend ESLint v10 and add backend guardrails #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ce4ae
chore(lint): stabilize frontend eslint and scope backend guardrails
LucasSantana-Dev Mar 10, 2026
ead6bc7
docs(lint): link backend lint debt follow-up issue
LucasSantana-Dev Mar 10, 2026
1657856
fix(ci): address codereabbit lint workflow feedback
LucasSantana-Dev Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ jobs:
- name: Generate Prisma client
run: npx prisma generate

- name: Lint code
run: |
npm run lint --workspace=packages/frontend
npm run lint --workspace=packages/backend
Comment on lines +31 to +33

@coderabbitai coderabbitai Bot Mar 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Root lint still overrides the new workspace-specific lint behavior.

npm run lint executes the repo-level ESLint config before the frontend/backend workspace commands. From the provided snippets, that root pass already traverses packages/frontend/src and packages/backend/src, so frontend can still fail on the old parser path and backend debt files can still fail before the workspace-specific config/ignores apply. Scope root lint to root-owned files only, or stop having the root config match package sources here.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 34 - 37, The root CI step runs npm run
lint before the workspace-specific commands which causes the root ESLint config
to scan packages/frontend/src and packages/backend/src and trigger
old-parser/backend failures; update the workflow so the root lint is scoped to
root-owned files only or remove the initial root npm run lint invocation and
only run npm run lint --workspace=packages/frontend and npm run lint
--workspace=packages/backend; specifically either change the root "npm run lint"
script to target only root files (e.g., adjust the root package.json "lint"
script to an explicit glob for root config/files) or delete/skip the plain "npm
run lint" line in the CI and keep the two workspace-specific commands (npm run
lint --workspace=packages/frontend and npm run lint
--workspace=packages/backend).

⚠️ Potential issue | 🟠 Major

Keep lint ahead of all build work in this job.

This step still runs after Build shared package, so the workflow does not follow the required lint → build → test → quality order. Move npm run build:shared into the build phase, or split out only the minimal generation step that lint actually depends on.
As per coding guidelines, "CI/CD pipeline must include in order: Setup (Node install, env config) → Lint (TypeScript typecheck, linter) → Build (production build, artifacts) → Test (unit, integration, coverage) → Quality (static analysis, vulnerability scan)"

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 34 - 37, The lint step currently runs
after "Build shared package"; move the lint invocations (the three commands
invoking npm run lint, npm run lint --workspace=packages/frontend, and npm run
lint --workspace=packages/backend) so they execute before the build phase, or
alternatively relocate the npm run build:shared command into the build phase and
leave only the minimal generation step that lint requires in setup;
specifically, ensure the CI job follows lint → build → test → quality order by
placing the npm run lint commands in the Lint phase and moving npm run
build:shared into the Build phase (refer to the run lines invoking "npm run
lint" and the "npm run build:shared" step to find the relevant blocks).


- name: Build shared package
run: npm run build:shared

- name: Lint code
run: npm run lint

- name: Type check
run: npm run type:check

Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Frontend lint now uses ESLint flat config (`packages/frontend/eslint.config.js`) so TypeScript/TSX parsing works correctly with ESLint 10
- CI quality gates now run package-level lint commands for frontend and backend, matching local verification workflow
- OAuth authorize/callback now canonicalize to the API-domain callback in production via `WEBAPP_BACKEND_URL`, preventing Discord `redirect_uri inválido` mismatches
- Added `/auth/callback` compatibility alias and callback-path normalization so legacy `/auth/callback` values still resolve to `/api/auth/callback`
- Backend server now enables `trust proxy` in production so secure session cookies are correctly issued behind nginx/Cloudflare
Expand Down Expand Up @@ -52,6 +54,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Backend lint scripts now include scoped guardrails for legacy strict-rule debt files and expose `npm run lint:full --workspace=packages/backend` for full debt tracking (follow-up: #136)
- Added `WEBAPP_BACKEND_URL` env propagation in Docker compose stacks and updated OAuth setup docs/examples to use API-domain callback URLs in production
- Added root npm deploy shortcuts: `npm run deploy:remote` and `npm run deploy:homelab`
- `scripts/deploy-remote.sh` now targets workflow file `deploy.yml` and waits for the dispatch run more reliably
Expand Down
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,18 @@ npm run dev:backend # Backend with hot reload
npm run dev:frontend # Vite dev server

npm run lint # ESLint
npm run lint --workspace=packages/frontend
npm run lint --workspace=packages/backend
npm run type:check # TypeScript validation
npm run test # Backend tests (Jest)
npm run test:coverage # With coverage report
npm run format # Prettier
```

Backend lint is currently scoped to active quality-gate paths while legacy strict
rule debt is tracked in [issue #136](https://github.com/LucasSantana-Dev/Lucky/issues/136)
and auditable via `npm run lint:full --workspace=packages/backend`.

### Remote Deploy (No SSH)

```bash
Expand Down
6 changes: 4 additions & 2 deletions packages/backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
"test": "jest",
"test:watch": "jest --watch",
"test:coverage": "jest --coverage",
"lint": "eslint . -c ../../eslint.config.js",
"lint:fix": "eslint . -c ../../eslint.config.js --fix"
"lint:base": "eslint . -c ../../eslint.config.js --ignore-pattern src/middleware/session.ts --ignore-pattern src/middleware/validate.ts --ignore-pattern src/routes/lastfm.ts --ignore-pattern src/routes/management.ts --ignore-pattern src/routes/managementAutoMessages.ts --ignore-pattern src/routes/managementEmbeds.ts --ignore-pattern src/routes/moderation.ts --ignore-pattern src/routes/music/playbackRoutes.ts --ignore-pattern src/routes/music/queueRoutes.ts --ignore-pattern src/routes/music/stateRoutes.ts --ignore-pattern src/routes/toggles.ts --ignore-pattern src/routes/twitch.ts",
"lint": "npm run lint:base",
"lint:fix": "npm run lint:base -- --fix",
"lint:full": "eslint . -c ../../eslint.config.js"
},
"dependencies": {
"@lucky/shared": "file:../shared",
Expand Down
50 changes: 50 additions & 0 deletions packages/frontend/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import js from '@eslint/js'
import globals from 'globals'
import parserTs from '@typescript-eslint/parser'
import reactHooks from 'eslint-plugin-react-hooks'

export default [
{
ignores: [
'dist/**',
'coverage/**',
'playwright-report/**',
'test-results/**',
'.eslintrc.cjs',
],
},
{
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: parserTs,
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
globals: {
...globals.browser,
...globals.node,
},
},
plugins: {
'react-hooks': reactHooks,
},
rules: {
...js.configs.recommended.rules,
'no-undef': 'off', // Typescript handles global and type symbols
'no-unused-vars': 'off',
'no-empty': 'off',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'off',
},
},
{
files: ['tests/e2e/**/*.ts'],
rules: {
'react-hooks/rules-of-hooks': 'off',
},
},
]
2 changes: 1 addition & 1 deletion packages/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite",
"build": "tsc && vite build",
"preview": "vite preview",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"lint": "eslint . --config eslint.config.js --max-warnings 0",
"type:check": "tsc --noEmit",
"test": "vitest run",
"test:watch": "vitest",
Expand Down
Loading