Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/music/music_main: play tracks regardless of volume #2171

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Dec 30, 2024

Resolves #2170.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

This ensures tracks will always be played even if the game is muted - similar to TR1.

@lahm86 lahm86 added OG bug A bug in original game TR2 labels Dec 30, 2024
@lahm86 lahm86 self-assigned this Dec 30, 2024
@lahm86 lahm86 requested review from a team as code owners December 30, 2024 18:32
@lahm86 lahm86 requested review from rr-, walkawayy and aredfan and removed request for a team December 30, 2024 18:32
Copy link

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you. 👍

@rr-
Copy link
Collaborator

rr- commented Dec 30, 2024

Thanks!

This ensures tracks will always be played even if the game is muted.

Resolves LostArtefacts#2170.
@lahm86 lahm86 force-pushed the issue-2170-fix-muted-game branch from 459a0fa to 1a13dee Compare December 30, 2024 19:18
@lahm86 lahm86 merged commit 87ec227 into LostArtefacts:develop Dec 30, 2024
6 checks passed
@lahm86 lahm86 deleted the issue-2170-fix-muted-game branch December 30, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OG bug: volume 0 can kill music
3 participants