Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: volume 0 can kill music #2170

Closed
aredfan opened this issue Dec 30, 2024 · 0 comments · Fixed by #2171
Closed

OG bug: volume 0 can kill music #2170

aredfan opened this issue Dec 30, 2024 · 0 comments · Fixed by #2171
Assignees
@lahm86
Labels
OG bug A bug in original game TR2

Comments

@aredfan
Copy link
Collaborator

aredfan commented Dec 30, 2024

Steps to reproduce:

  1. play 0
  2. open the inventory
  3. go into sound options and set the music volume to 0
  4. /title
  5. open the sound options and increase the music volume, you'll find there's no music playing
@aredfan aredfan added OG bug A bug in original game TR2 labels Dec 30, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 30, 2024
@lahm86
tr2/music/music_main: play tracks regardless of volume
459a0fa 
This ensures tracks will always be played even if the game is muted.

Resolves LostArtefacts#2170.
@lahm86 lahm86 self-assigned this Dec 30, 2024
@lahm86 lahm86 moved this to In progress in TRX Dev tracker Dec 30, 2024
@lahm86 lahm86 mentioned this issue Dec 30, 2024
Merged
3 tasks
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 30, 2024
@lahm86
tr2/music/music_main: play tracks regardless of volume
1a13dee 
This ensures tracks will always be played even if the game is muted.

Resolves LostArtefacts#2170.
lahm86 added a commit that referenced this issue Dec 30, 2024
@lahm86
tr2/music/music_main: play tracks regardless of volume
87ec227 
This ensures tracks will always be played even if the game is muted.

Resolves #2170.
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
OG bug A bug in original game TR2
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/music/music_main: play tracks regardless of volume lahm86/TRX
2 participants
@lahm86 @aredfan