Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passport animate in is too fast when exiting to main menu #1704

Closed
Richard-L opened this issue Oct 10, 2024 · 3 comments · Fixed by #1835
Closed

Passport animate in is too fast when exiting to main menu #1704

Richard-L opened this issue Oct 10, 2024 · 3 comments · Fixed by #1835
Assignees
@rr-
Labels
TR2 TRX bug A bug with TRX

Comments

@Richard-L
Copy link
Collaborator

It's so fast that you basically don't see it.

2024-10-11.00-32-36.mp4
@Richard-L Richard-L added TR2 TRX bug A bug with TRX labels Oct 10, 2024
@Richard-L
Copy link
Collaborator Author

I could test OG now to determine bug origin, and it's not present when using Tomb2.exe

@rr- rr- moved this to Ready in TRX Dev tracker Oct 21, 2024
@walkawayy
Copy link
Collaborator

@Richard-L can you test again on the latest development snapshot? I can't reproduce this. Also maybe @aredfan could check.

rr- added a commit that referenced this issue Nov 5, 2024
@rr-
tr2/inventory: fix fast spinout animation
5699694 
Resolves #1704.

This was especially evident with FMVs that don't depend on the clock -
m_LastCounter held old time data, making the game try to make up for the
perceived large difference, and skip ahead by many frames at once.
@rr- rr- mentioned this issue Nov 5, 2024
Merged
2 tasks
rr- added a commit that referenced this issue Nov 5, 2024
@rr-
tr2/inventory: fix fast spinout animation
2b97234 
Resolves #1704.

This was especially evident with FMVs that don't depend on the clock -
m_LastCounter held old time data, making the game try to make up for the
perceived large difference, and skip ahead by many frames at once.
@rr- rr- moved this from Ready to In progress in TRX Dev tracker Nov 5, 2024
@rr- rr- self-assigned this Nov 5, 2024
@rr- rr- closed this as completed in #1835 Nov 5, 2024
@rr- rr- closed this as completed in 1a3fad5 Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Nov 5, 2024
@Richard-L
Copy link
Collaborator Author

@Richard-L can you test again on the latest development snapshot? I can't reproduce this. Also maybe @aredfan could check.

Sorry I wasn't able to verify but I'm sure it's fine 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rr- rr-

Labels
TR2 TRX bug A bug with TRX
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/inventory: fix fast spinout animation LostArtefacts/TRX
3 participants
@rr- @Richard-L @walkawayy