Skip to content

add amf patches#6

Merged
ReenigneArcher merged 5 commits intonightlyfrom
add/amf-patches
Dec 2, 2022
Merged

add amf patches#6
ReenigneArcher merged 5 commits intonightlyfrom
add/amf-patches

Conversation

@ReenigneArcher
Copy link
Member

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the add/amf-patches branch 14 times, most recently from 407df10 to b341a07 Compare November 25, 2022 17:01
For some reason patches fail to apply on the Windows runner unless `--ignore-whitespace` is used.
@psyke83
Copy link
Contributor

psyke83 commented Nov 30, 2022

I've been doing some tests without this patch set. While amfenc does work, there are intermittent cases in which moonlight-qt will suddenly stop updating video (last image stays frozen), and sometimes will connect to a black screen, usually when a game is running in fullscreen. So, the IDR patch is probably still needed, but I'm not sure if the colour patch is necessary or what it changes.

I've also tested unpatched ffmpeg against LizardByte/Sunshine#516, and it doesn't resolve the issues mentioned above.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review November 30, 2022 21:00
@ReenigneArcher ReenigneArcher merged commit 4fe5637 into nightly Dec 2, 2022
@ReenigneArcher ReenigneArcher deleted the add/amf-patches branch December 2, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants