Send valid frame type value in frame header#516
Merged
ReenigneArcher merged 2 commits intoLizardByte:nightlyfrom Dec 16, 2022
Merged
Send valid frame type value in frame header#516ReenigneArcher merged 2 commits intoLizardByte:nightlyfrom
ReenigneArcher merged 2 commits intoLizardByte:nightlyfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sunshine currently sends a hardcoded frame header with an invalid frame type value (
0x104) thatmoonlight-common-cknows to ignore (otherwise it asserts on unknown frame types). Most of the frame header is unknown, but send a valid frame type value now that we understand that part of the header (andmoonlight-common-cuses it for reference frame invalidation handling).Screenshot
Issues Fixed or Closed
Type of Change
Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.