Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix hardcoded usd currency #467

Merged

Conversation

rubenandre
Copy link
Contributor

@rubenandre rubenandre commented Feb 2, 2022

rubenandre 🐛 Fix Quick rubenandre /fix-hardcoded-usd-cryptowatchlist-widget → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 1 Unchecked Tasks

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Bugfix

Overview

The Crypto Watch List use an hardcoded string "usd" to call findCurrencySymbol, so even the currency price will be in the user selected currency, in the UI will always show "$"

Screenshot (if applicable)

  • Before changes:

conf.yml file
image

UI
image

  • After Changes

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@rubenandre rubenandre requested a review from Lissy93 as a code owner February 2, 2022 19:41
@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: e3c7dc0

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61fade7b8019ed00087535d7

😎 Browse the preview: https://deploy-preview-467--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Feb 2, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@Lissy93 Lissy93 merged commit b0c493f into Lissy93:master Feb 2, 2022
@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Feb 2, 2022
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants