Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Add new coincheck wallet to known.json - Closes #588 #589

Merged
merged 4 commits into from
May 3, 2018
Merged

Add new coincheck wallet to known.json - Closes #588 #589

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e18924a
Add new coincheck wallet to known.json
Nazgolze Apr 26, 2018
9b2810f
Rephrasing - Old old to just old
Nazgolze Apr 27, 2018
5044b41
Merge branch '2.0.0' into 588-topaccounts-update
Nazgolze Apr 30, 2018
e6b1872
Merge branch '2.0.0' into 588-topaccounts-update
MichalTuleja May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions known.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
"14175575863689886451L" : { "owner": "Adviser Assets", "description": "LiskHQ" },
"5726759782318848681L" : { "owner": "Lisk Foundation", "description": "LiskHQ" },
"15841793714384967784L" : { "owner": "Lisk Community Assets", "description": "LiskHQ" },
"3040783849904107057L" : { "owner": "Coincheck.com", "description": "Old Wallet" },
"3040783849904107057L" : { "owner": "Coincheck.com", "description": "Old old Wallet" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to wording this differently 😅

Copy link
Contributor

@MichalTuleja MichalTuleja Apr 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in the English language, but wouldn't just Former (hot/cold/main) wallet sound better? :)
Also, it would make sense to merge that change with the branch 1.6.1. It seems to be released sooner than 2.0.0 and it'll be part of 2.1.0 in the future.

"6300322192409448238L" : { "owner": "Iconomi ICO", "description": "Main Wallet"},
"11737606468871099380L" : { "owner" : "Changelly", "description" : "Main Wallet" },
"15441526754256992144L" : { "owner" : "HitBTC.com", "description" : "Hot Wallet" },
"2797034409072178585L" : { "owner" : "BitBay.net", "description" : "Withdrawal Wallet" },
"15610359283786884938L" : { "owner" : "Binance", "description" : "Hot Wallet" },
"14367838290034827614L" : { "owner" : "Coincheck.com", "description" : "Main Wallet" }
"14367838290034827614L" : { "owner" : "Coincheck.com", "description" : "Old Wallet" },
"16293716040102736949L" : { "owner" : "Coincheck.com", "description" : "Main Wallet"}
}