This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Add new coincheck wallet to known.json - Closes #588 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nazgolze
commented
Apr 26, 2018
known.json
Outdated
| @@ -13,11 +13,12 @@ | |||
| "14175575863689886451L" : { "owner": "Adviser Assets", "description": "LiskHQ" }, | |||
| "5726759782318848681L" : { "owner": "Lisk Foundation", "description": "LiskHQ" }, | |||
| "15841793714384967784L" : { "owner": "Lisk Community Assets", "description": "LiskHQ" }, | |||
| "3040783849904107057L" : { "owner": "Coincheck.com", "description": "Old Wallet" }, | |||
| "3040783849904107057L" : { "owner": "Coincheck.com", "description": "Old old Wallet" }, | |||
There was a problem hiding this comment.
I'm open to wording this differently 😅
There was a problem hiding this comment.
I'm not an expert in the English language, but wouldn't just Former (hot/cold/main) wallet sound better? :)
Also, it would make sense to merge that change with the branch 1.6.1. It seems to be released sooner than 2.0.0 and it'll be part of 2.1.0 in the future.
MichalTuleja
changed the title
MichalTuleja
approved these changes
May 3, 2018
|
Please check if it is merged with 1.6.1 as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
known.json needed an update to identify 16293716040102736949L
How did I fix it?
added the entry for 16293716040102736949L
Review checklist