Conversation
- get rid of some anno warnings - add display components (in prep for moving it from js to lua) - add filter function - allow 2nd stream for any platform
Nadoxis
reviewed
Jul 4, 2024
Contributor
|
The rest looks ok to me, don't know all the specific behaviors like legacy and stuff tho, but I trust you on this ;) |
Nadoxis
reviewed
Jul 4, 2024
Collaborator
|
Is it still in draft? Considering the PR title |
Rathoz
reviewed
Jul 8, 2024
hjpalpha
changed the title
Rathoz
reviewed
Jul 8, 2024
Rathoz
reviewed
Jul 9, 2024
- let js add the ` - ` with the same criteria as before - display streams if finished is not set but the time switch has already happened --> it will again show the date together with the stream but without dash and countdown
Collaborator
Would it not be better to hide the steams in JS for this scenario? That's at least what I had in mind |
Collaborator
Author
it requires quite a bit of changes though Lua-Modules/javascript/commons/Countdown.js Lines 32 to 33 in 3756685 and rebuild it entirely there in addition it mirrors current behaviour 1:1 now we could leave it as oos for a future PR |
Rathoz
changed the title
Rathoz
reviewed
Jul 15, 2024
Co-authored-by: Rikard Blixt <rikardblixt@gmail.com>
Rathoz
reviewed
Jul 15, 2024
Rathoz
reviewed
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per discussion in #4363 refactor the countdown stuff in a way that moves the stream building out of js into lua.
Also allows to call the stream icon building from outside of Module:Countdown.
How did you test this change?
on the deprecated secret commons
https://*****.liquipedia.net/commons/User:Hjpalpha/countdown(mind css for infobox icons is broken on that wiki, hence the icons looking badly)