feat(MatchTicker): add new match ticker display style#4363
Merged
Conversation
hjpalpha
reviewed
Jun 21, 2024
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
Nadoxis
commented
Jun 25, 2024
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
Nadoxis
changed the title
hjpalpha
reviewed
Jun 26, 2024
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
what is the placeholder on the right supposed to show?
also i personally think the winner should be highlighted somehow to make clear it is the winner
(personally i am fine with kicking the gradient bg stuff fwiw, just think that some indication should be given)
overall i like the new design, looks clean :)
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The placeholder is supposed to show either the date or the countdown. Here it shows nothing since the matches in devs are old and not marked as finished, will give some tests on live to see if it behaves correctly. For the winner, you're right I will put the winner in bold for now and we can see later on to improve the visibility over this! |
liquidely
reviewed
Jun 28, 2024
liquidely
reviewed
Jun 28, 2024
liquidely
reviewed
Jun 28, 2024
Rathoz
reviewed
Jul 8, 2024
components/match_ticker/commons/match_ticker_display_components.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Jul 8, 2024
Rathoz
reviewed
Jul 8, 2024
Rathoz
changed the title
added 2 commits
July 15, 2024 12:28
hjpalpha
approved these changes
Jul 15, 2024
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Jul 15, 2024
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
…s_new.lua Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
…s into ticker-custom-dota
Rathoz
reviewed
Jul 15, 2024
Rathoz
reviewed
Jul 15, 2024
components/match_ticker/commons/match_ticker_display_components_new.lua
Outdated
Show resolved
Hide resolved
…s_new.lua Co-authored-by: Rikard Blixt <rikardblixt@gmail.com>
Rathoz
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is setting up the new Match Ticker structure and visuals we want to use for the Dota2 Main Page. It will most likely be extended to other pages and wikis, but the scope of this one is only this context.
How did you test this change?
In my dev environment: http://killian.wiki.tldev.eu/rocketleague/index.php?title=Template:GameList/Dev
Currently testing it on live to see how it would look like