This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Added TabularRegressionData extending TabularData #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanmichael
requested review from
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 91.25% 91.27% +0.02%
==========================================
Files 114 117 +3
Lines 7224 7234 +10
==========================================
+ Hits 6592 6603 +11
+ Misses 632 631 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tchaton
reviewed
Jul 13, 2021
Co-authored-by: thomas chaton <[email protected]>
|
Hello @sumanmichael! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-13 12:01:19 UTC |
Co-authored-by: thomas chaton <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…module' into feature/tabular_regression_data_module
for more information, see https://pre-commit.ci
ethanwharris
changed the title
sumanmichael
added a commit
to sumanmichael/lightning-flash
that referenced
this pull request
Aug 10, 2021
…Universe#574)" This reverts commit c318e4a
ananyahjha93
pushed a commit
that referenced
this pull request
Oct 29, 2021
* Revert "Added TabularRegressionData extending TabularData (#574)" This reverts commit c318e4a * added DataModule, PreProcess, DataSource for TabularForecasting * added TABULAR_FORECASTING_BACKBONES * [WIP] added model.py in tabular forecasting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates * Updates * Try fix * Updates * Rename to TabularClassificationData * Updates * Fix embedding sizes * Fixes and add example * Updates * Switch to an adapter * Small fixes * Add inference error * Add inference and refactor * Add interpertation example * Fix broken tests * Small fixes and add some tests * Updates * Update CHANGELOG.md * Add provider * Update flash/core/integrations/pytorch_forecasting/adapter.py Co-authored-by: Jirka Borovec <[email protected]> * Update flash/core/integrations/pytorch_forecasting/adapter.py Co-authored-by: Jirka Borovec <[email protected]> * Update on comments Co-authored-by: Ethan Harris <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ethan Harris <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Created TabularRegressionData DataModule
TabularRegressionData has a lot common with TabularData in tabular/classification/data.py.
Here's what I did.
Fixes #527
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃