Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: re-adding Chrf implementation #2701

Merged
merged 4 commits into from
Aug 29, 2024
Merged

text: re-adding Chrf implementation #2701

merged 4 commits into from
Aug 29, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 28, 2024

This reverts commit 663f06d.

What does this PR do?

re-adding Chrf temp drooped in #2668 & reopen #2697

Hold for:

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2701.org.readthedocs.build/en/2701/

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 85.53459% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39%. Comparing base (ef22554) to head (b5e4559).
Report is 107 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (ef22554) and HEAD (b5e4559). Click for more details.

HEAD has 152 uploads less than BASE
Flag BASE (ef22554) HEAD (b5e4559)
Windows 8 3
python3.8 8 3
cpu 58 20
torch1.13.1+cpu 9 3
macOS 11 4
python3.10 15 5
torch2.0.1 6 2
torch2.0.1+cpu 9 3
torch1.12.1+cpu 3 1
Linux 39 13
python3.9 27 9
torch1.10.2+cpu 3 1
torch1.11.0+cpu 3 1
python3.11 8 3
torch2.4.0 3 1
torch2.3.1+cpu 6 2
torch2.1.2+cpu 3 1
torch2.2.2+cpu 6 2
torch2.4.0+cu121 3 1
torch2.4.0+cpu 2 1
torch1.13.1 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2701     +/-   ##
========================================
- Coverage      69%     39%    -29%     
========================================
  Files         316     316             
  Lines       17745   17897    +152     
========================================
- Hits        12185    7025   -5160     
- Misses       5560   10872   +5312     

@m-popovic
Copy link
Contributor

I approve re-implementation of chrF under Apache licence

@Borda Borda requested a review from lantiga August 29, 2024 07:31
@lantiga
Copy link
Contributor

lantiga commented Aug 29, 2024

Thank you @m-popovic! I suggest we reintroduce the code with a clear note that says that

  • the code is derived from [link to repo]
  • the original author and copyright holder has agreed to relicense the derived code as Apache 2.0 [+ link to this conversation]

Let's avoid retaining mentions of the GPL license explicitly in our source code here, as automated scanners may still flag it.

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @m-popovic

for reference: #2665
cc @kkoehncke

@mergify mergify bot added the ready label Aug 29, 2024
@Borda Borda changed the title text: re-adding Chrf implementation [hold] text: re-adding Chrf implementation Aug 29, 2024
@Borda Borda merged commit 773fb92 into master Aug 29, 2024
61 checks passed
@Borda Borda deleted the add/chfr branch August 29, 2024 15:10
@SkafteNicki SkafteNicki mentioned this pull request Sep 8, 2024
Borda added a commit that referenced this pull request Sep 11, 2024
* update licence

This reverts commit 663f06d.

---------

Co-authored-by: Maja Popovic <[email protected]>
(cherry picked from commit 773fb92)
Borda added a commit that referenced this pull request Sep 13, 2024
* update licence

This reverts commit 663f06d.

---------

Co-authored-by: Maja Popovic <[email protected]>
(cherry picked from commit 773fb92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants