-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text: re-adding Chrf implementation #2701
Conversation
This reverts commit 663f06d.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
========================================
- Coverage 69% 39% -29%
========================================
Files 316 316
Lines 17745 17897 +152
========================================
- Hits 12185 7025 -5160
- Misses 5560 10872 +5312 |
I approve re-implementation of chrF under Apache licence |
Thank you @m-popovic! I suggest we reintroduce the code with a clear note that says that
Let's avoid retaining mentions of the GPL license explicitly in our source code here, as automated scanners may still flag it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again @m-popovic
for reference: #2665
cc @kkoehncke
* update licence This reverts commit 663f06d. --------- Co-authored-by: Maja Popovic <[email protected]> (cherry picked from commit 773fb92)
* update licence This reverts commit 663f06d. --------- Co-authored-by: Maja Popovic <[email protected]> (cherry picked from commit 773fb92)
This reverts commit 663f06d.
What does this PR do?
re-adding Chrf temp drooped in #2668 & reopen #2697
Hold for:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2701.org.readthedocs.build/en/2701/