Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: temp drop Chrf implementation #2668

Merged
merged 11 commits into from
Aug 2, 2024
Merged

text: temp drop Chrf implementation #2668

merged 11 commits into from
Aug 2, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 2, 2024

What does this PR do?

let's remove the Chrf implementation until the licensing is clearly addressed/resolved
closes #2665

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2668.org.readthedocs.build/en/2668/

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Text labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39%. Comparing base (8d84cf4) to head (3960f55).
Report is 108 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8d84cf4) and HEAD (3960f55). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (8d84cf4) HEAD (3960f55)
python3.8 3 2
cpu 22 18
torch1.13.1+cpu 3 1
Linux 13 9
python3.9 8 6
torch1.10.2+cpu 1 0
torch2.0.1+cpu 3 2
python3.10 5 4
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2668     +/-   ##
========================================
- Coverage      69%     39%    -30%     
========================================
  Files         316     316             
  Lines       17881   17729    -152     
========================================
- Hits        12331    6891   -5440     
- Misses       5550   10838   +5288     

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 2, 2024
src/torchmetrics/text/chrf.py Outdated Show resolved Hide resolved
src/torchmetrics/text/chrf.py Outdated Show resolved Hide resolved
@Borda Borda merged commit 663f06d into master Aug 2, 2024
59 of 65 checks passed
@Borda Borda deleted the chrf branch August 2, 2024 14:39
@Borda Borda mentioned this pull request Aug 2, 2024
Borda added a commit that referenced this pull request Aug 2, 2024
---
Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 663f06d)
Borda added a commit that referenced this pull request Aug 2, 2024
---
Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 663f06d)
Borda added a commit that referenced this pull request Aug 20, 2024
stancld added a commit that referenced this pull request Aug 28, 2024
* Revert "text: temp drop `Chrf` implementation (#2668)"

This reverts commit 663f06d.

* update licence

---------

Co-authored-by: Maja Popovic <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
@Borda Borda mentioned this pull request Aug 28, 2024
5 tasks
Borda added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPL 2.0 License detected in functional/text/chrf.py
3 participants