-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text: temp drop Chrf
implementation
#2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
justusschock,
lantiga,
SkafteNicki and
stancld
as code owners
August 2, 2024 11:09
github-actions
bot
added
documentation
Improvements or additions to documentation
topic: Text
labels
Aug 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2668 +/- ##
========================================
- Coverage 69% 39% -30%
========================================
Files 316 316
Lines 17881 17729 -152
========================================
- Hits 12331 6891 -5440
- Misses 5550 10838 +5288 |
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Aug 2, 2024
Borda
commented
Aug 2, 2024
Borda
commented
Aug 2, 2024
justusschock
approved these changes
Aug 2, 2024
lantiga
approved these changes
Aug 2, 2024
Closed
Borda
added a commit
that referenced
this pull request
Aug 2, 2024
--- Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 663f06d)
Borda
added a commit
that referenced
this pull request
Aug 2, 2024
--- Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 663f06d)
4 tasks
stancld
added a commit
that referenced
this pull request
Aug 28, 2024
* Revert "text: temp drop `Chrf` implementation (#2668)" This reverts commit 663f06d. * update licence --------- Co-authored-by: Maja Popovic <[email protected]> Co-authored-by: Daniel Stancl <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
let's remove the Chrf implementation until the licensing is clearly addressed/resolved
closes #2665
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2668.org.readthedocs.build/en/2668/