Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in ergas calculation #2498

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Fix error in ergas calculation #2498

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dec3ee3
fix error in formula
SkafteNicki Apr 12, 2024
939f1b3
Merge branch 'master' into bugfix/ergas
SkafteNicki Apr 12, 2024
f8e4ae1
fix doctests
SkafteNicki Apr 13, 2024
5613e12
Merge branch 'bugfix/ergas' of https://github.com/Lightning-AI/torchm…
SkafteNicki Apr 13, 2024
c2c64e1
changelog
SkafteNicki Apr 13, 2024
f761462
Merge branch 'master' into bugfix/ergas
SkafteNicki Apr 13, 2024
4d21347
fix other doctests
SkafteNicki Apr 13, 2024
81c25cb
Merge branch 'bugfix/ergas' of https://github.com/Lightning-AI/torchm…
SkafteNicki Apr 13, 2024
a6db3ba
Merge branch 'master' into bugfix/ergas
SkafteNicki Apr 15, 2024
b4a59d5
Merge branch 'master' into bugfix/ergas
SkafteNicki Apr 15, 2024
c580d19
Merge branch 'master' into bugfix/ergas
Borda Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchmetrics/functional/image/ergas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _ergas_compute(
rmse_per_band = torch.sqrt(sum_squared_error / (h * w))
mean_target = torch.mean(target, dim=2)

ergas_score = 100 * ratio * torch.sqrt(torch.sum((rmse_per_band / mean_target) ** 2, dim=1) / c)
ergas_score = 100 / ratio * torch.sqrt(torch.sum((rmse_per_band / mean_target) ** 2, dim=1) / c)
return reduce(ergas_score, reduction)


Expand Down
2 changes: 1 addition & 1 deletion tests/unittests/image/test_ergas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def _reference_ergas(
rmse_per_band = torch.sqrt(sum_squared_error / (h * w))
mean_target = torch.mean(sk_target, dim=2)
# compute ergas score
ergas_score = 100 * ratio * torch.sqrt(torch.sum((rmse_per_band / mean_target) ** 2, dim=1) / c)
ergas_score = 100 / ratio * torch.sqrt(torch.sum((rmse_per_band / mean_target) ** 2, dim=1) / c)
# reduction
if reduction == "sum":
return torch.sum(ergas_score)
Expand Down
Loading