Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in ergas calculation #2498

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Fix error in ergas calculation #2498

merged 11 commits into from
Apr 15, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 12, 2024

What does this PR do?

Fixes #2497
Fixes #2416

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2498.org.readthedocs.build/en/2498/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Apr 12, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Apr 12, 2024
@SkafteNicki SkafteNicki changed the title fix error in formula Fix error in ergas calculation Apr 12, 2024
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how the tests are passing before and now with two different computation...

@SkafteNicki
Copy link
Member Author

Wondering how the tests are passing before and now with two different computation...

Because the reference implementation was also written by us (because no reference seems to exist) which had the same computational bug

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Merging #2498 (c580d19) into master (5892316) will decrease coverage by 31%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2498     +/-   ##
========================================
- Coverage      69%     38%    -31%     
========================================
  Files         307     307             
  Lines       17396   17396             
========================================
- Hits        11981    6659   -5322     
- Misses       5415   10737   +5322     

@mergify mergify bot added the ready label Apr 13, 2024
@SkafteNicki SkafteNicki enabled auto-merge (squash) April 15, 2024 10:35
@mergify mergify bot removed the has conflicts label Apr 15, 2024
@SkafteNicki SkafteNicki merged commit f656e5a into master Apr 15, 2024
62 checks passed
@SkafteNicki SkafteNicki deleted the bugfix/ergas branch April 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ERGAS Error in ERGAS metric
4 participants