Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SensitivityAtSpecificity metric #2217

Merged
merged 69 commits into from
Feb 14, 2024

Conversation

oguz-hanoglu
Copy link
Contributor

@oguz-hanoglu oguz-hanoglu commented Nov 16, 2023

What does this PR do?

Fixes the remaining part of #971
It basically follows the same code structure with this pull request and make the necessary modifications.
Repos like tensorflow include both SensitivityAtSpecificity and SpecificityAtSensitivity, whereas Torchmetrics is missing SensitivityAtSpecificity.

The github discussion at #971 ends with "Feel free to implement the other variant SensitivityAtSpecificity if you guys are interested."

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section? (OH: no such a section, is this a test?)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review SpecificityAtSensitivity is already included in TorchMetrics. This PR introduces the SensitivityAtSpecificity Metric.

Did you have fun?

[X] Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2217.org.readthedocs.build/en/2217/

@SkafteNicki SkafteNicki requested a review from lantiga as a code owner November 26, 2023 18:12
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 26, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Nov 28, 2023
@mergify mergify bot removed the has conflicts label Nov 28, 2023
@mergify mergify bot removed the has conflicts label Nov 29, 2023
@mergify mergify bot added the ready label Feb 6, 2024
@SkafteNicki
Copy link
Member

@Borda yes I know. The weird part is that it is assertion errors meaning that the code is running but giving wrong results. So some pytorch operator has changed behaviour since v1.10

@Borda
Copy link
Member

Borda commented Feb 13, 2024

we can also allow this method only for newer PT

@mergify mergify bot removed the ready label Feb 14, 2024
@mergify mergify bot added the ready label Feb 14, 2024
@Borda Borda merged commit 442c463 into Lightning-AI:master Feb 14, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready topic: Classif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants