-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SensitivityAtSpecificity metric #2217
Merged
Borda
merged 69 commits into
Lightning-AI:master
from
oguz-hanoglu:sensitivity_specificity
Feb 14, 2024
Merged
Add SensitivityAtSpecificity metric #2217
Borda
merged 69 commits into
Lightning-AI:master
from
oguz-hanoglu:sensitivity_specificity
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordered similarly, duplicates removed.
oguz-hanoglu
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
November 16, 2023 15:24
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 26, 2023
@Borda yes I know. The weird part is that it is assertion errors meaning that the code is running but giving wrong results. So some pytorch operator has changed behaviour since v1.10 |
we can also allow this method only for newer PT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the remaining part of #971
It basically follows the same code structure with this pull request and make the necessary modifications.
Repos like tensorflow include both SensitivityAtSpecificity and SpecificityAtSensitivity, whereas Torchmetrics is missing SensitivityAtSpecificity.
The github discussion at #971 ends with "Feel free to implement the other variant SensitivityAtSpecificity if you guys are interested."
Before submitting
PR review
SpecificityAtSensitivity is already included in TorchMetrics. This PR introduces the SensitivityAtSpecificity Metric.Did you have fun?
[X] Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2217.org.readthedocs.build/en/2217/